Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Make coverity happy ...................................................................... core: Make coverity happy Some recent changes have introduced a construct that forces the java compiler to infer the type of a generic method from its use inside the condition of an if, for example: if(Config.GetValue(ConfigValues.ExternalSchedulerEnabled)) { ... } The usual (which doesn't mean nice) syntax for this is the following: if(Config.<Boolean> GetValue(ConfigValues.ExternalSchedulerEnabled)) { ... } While the recently introduced syntax is nicer, unfortunatelly it makes coverity choke. This patch reverts to the old style, just to make coverity happy. Change-Id: I2eb133de6fab92eaaf0edd8a99af2fc406f6b088 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2eb133de6fab92eaaf0edd8a99af2fc406f6b088 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Ohad Basan <obasan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server