From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: private VmCommand#cdPathWindowsToLinux(String, String)
......................................................................
core: private VmCommand#cdPathWindowsToLinux(String, String)
This method is an internal implementation detail of
VmCommand#cdPathWindowsToLinux(String, Guid, Guid), and as such
should not be used in other contexts.
This patch cleans up RunVmCommandTest to mock
getIsoPrefix(Guid, Guid) directly instead of setting up a convoluted
doAnswer behavior and changes this method to be private, as it ought
to be.
Change-Id: I643352a4d00afdb62d219f372b98a25b513d1709
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
2 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/68371
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I643352a4d00afdb62d219f372b98a25b513d1709
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>