Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin,userportal: Optimize syntax checker handling ...................................................................... webadmin,userportal: Optimize syntax checker handling 1. access to (search) syntax checker instance is now provided through Configurator#getSyntaxChecker * UserPortalConfigurator#getSyntaxChecker returns null (not available in UserPortal context) * WebAdminConfigurator#getSyntaxChecker returns instance obtained via SyntaxCheckerFactory 2. removed SearchableListModel#syntaxChecker field along with related code (instance initialization, getter) 3. modified SearchableListModel#isSearchValidForServerSideSorting to access syntax checker through Configurator * in UserPortal context, syntax checker will be null and above method will simply return true * in WebAdmin context, syntax checker will be non-null and existing behavior will be retained 4. modified SearchSuggestModel to access syntax checker through Configurator 5. removed unused SyntaxCheckerFactory#getUISyntaxChecker This patch improves performance of UserPortal while keeping existing behavior of WebAdmin (where syntax checker is used in SearchableListModel#isSearchValidForServerSideSorting). Change-Id: Iab7f369fa26452fe49c57f99dc53919a2bad0412 Bug-Url: https://bugzilla.redhat.com/1223836 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 6 files changed, 30 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/41284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab7f369fa26452fe49c57f99dc53919a2bad0412 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: automation@ovirt.org