Change in ovirt-engine[master]: core: Remove GlusterUtilTest redundant mocking
From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GlusterUtilTest redundant mocking ...................................................................... core: Remove GlusterUtilTest redundant mocking Remove redundant mocking that is not required by the test and does nothing but confuse the reader. Note that one the redundant mocks were removed, it became clear that EXPECTED_MAP was only used in a single method, so it was converted to a local variable. Change-Id: I7419ccb7afeaebee68ca3ffa69cfd212656ac907 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java 1 file changed, 4 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/70226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7419ccb7afeaebee68ca3ffa69cfd212656ac907 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review