Daniel Erez has submitted this change and it was merged. Change subject: core: Stop image IO permissions before changing its status. ...................................................................... core: Stop image IO permissions before changing its status. Currently, a request for deleting an image upload ticket is being made AFTER the image's engine status is changed, which is problematic in cases where the engine shuts down right after saving the image's state, not revoking the write permissions. This can give the user permissions to write data to a legal image if the upload is completed, which we do not allow. Change-Id: I4628dc3f7af404bb898a4e68dd3fbf9c2fd0be31 Signed-off-by: Amit Aviram <aaviram@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/55625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4628dc3f7af404bb898a4e68dd3fbf9c2fd0be31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>