Maor Lipchuk has submitted this change and it was merged. Change subject: core:Remove multiple columns in group by to use view ...................................................................... core:Remove multiple columns in group by to use view The following patch removes group by which is used for disks. The group by is being done to use array for storage for disk, and it is done on three columns. Since the view use many columns each time a new column is added we need to add it to the group by, which cause the views to be large and ugly. The suggested fix is to use a view specifically for storage which use those three columns, and use join on it when ever it is used. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Change-Id: I273c423009f4718bc527a6155745fda757771303 --- M backend/manager/dbscripts/create_views.sql 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I273c423009f4718bc527a6155745fda757771303 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;