Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImage.hasRawBlock() ...................................................................... core: DiskImage.hasRawBlock() isRawBlock() is used to check whether a DiskImage needs refreshing on VDSM's side before an action is performed on it. Theoretically, a DiskImage can have several copies on several domains, and only some of them may be block domains (thus requiring a refresh). This patch removes the assumption that the block domain would necessarily be the first domain returned in getStorageTypes() and instead checks all the domains to see if at least one of them is a block domain. Currently, this situation is only possible for templates, which don't participate in Live Merging, so this patch is more of a future-proofing effort than an actual bugfix. Change-Id: Ief879683c433e52efcf4c2d2dc43db81f0475835 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImage.java 3 files changed, 12 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief879683c433e52efcf4c2d2dc43db81f0475835 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>