Arik Hadas has submitted this change and it was merged. Change subject: core: Remove VmTemplateCommand#executeCommand ...................................................................... core: Remove VmTemplateCommand#executeCommand Throwing a NotImplementedException isn't a useful behavior - its just a stub implementation intended to mark that whoever extends this class should override this method. A much better way to do this is to declare the class abstract (as it already is), and leave this method unimplemented, so overriding it is checked in compile time. Change-Id: Ia96bf6ddfd5ca194a70f86742be609ec8a400d4e Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96bf6ddfd5ca194a70f86742be609ec8a400d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>