Change in ovirt-engine[master]: core: OsValueAutoCompleterTest completions

From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: core: OsValueAutoCompleterTest completions ...................................................................... core: OsValueAutoCompleterTest completions Initialize the static data member in a static block instead of reinitializing it every instance of the test. This is not only faster, but also makes debugging these tests much easier, as it's clear where the map instance is created and populated. Change-Id: I8255fca5b7fd9a1f002b14fea11b09f30c0d78a0 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/71661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8255fca5b7fd9a1f002b14fea11b09f30c0d78a0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review