Omer Frenkel has submitted this change and it was merged. Change subject: core: Incorrect check of VirtIO-SCSI status on VM update ...................................................................... core: Incorrect check of VirtIO-SCSI status on VM update If VirtIO-SCSI device is to be enabled on VM update, cluster and OS compatibility must be verified. If getParameters().isVirtioScsiEnabled() is null, that means the current device status must be preserved. In this case, cluster and OS compatibility must be verified, if VirtIO-SCSI device is currently enabled. This logic is correctly implemented in UpdateVmCommand.isVirtioScsiEnabled() method, so we use it instead of incorrect condition used previously. Change-Id: I459256da7df4ef0f6662479df2d6d0a6cabc001b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219697 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I459256da7df4ef0f6662479df2d6d0a6cabc001b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud@redhat.com> Gerrit-Reviewer: automation@ovirt.org