Omer Frenkel has submitted this change and it was merged. Change subject: core: use String instead of StringBuilder in SysprepHandler (#873742) ...................................................................... core: use String instead of StringBuilder in SysprepHandler (#873742) SysprepHandler uses StringBuilder as it is a string: it creates new instances for replacements. this patch changes StringBuilder to String to make it clear to the user it is regular string that need to be set. also added return value to populateSysPrepDomainProperties as it manipulates the string inside it as well, caused changes to domain, user and pass in the sysprep file to be lost. Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490 Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=873742 Signed-off-by: Omer Frenkel <ofrenkel@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 2 files changed, 27 insertions(+), 32 deletions(-) Approvals: Omer Frenkel: Verified Maor Lipchuk: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com>