Tal Nisan has submitted this change and it was merged. Change subject: core: Extract check for floating disk in AddDiskCommand ...................................................................... core: Extract check for floating disk in AddDiskCommand The check whether a disk is floating (i.e. will not be attached to a VM) is repeated 3 times within the class and was extracted to a method for better readability The method isVmExist() was inlined as well as the terminology there is confusing since the method checks whether the VM exists only in case of a non floating disk Change-Id: Ib836b82389f45de2b206fbf67e1ea8e7e36935c8 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib836b82389f45de2b206fbf67e1ea8e7e36935c8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>