Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix quota check for Add-Template
......................................................................
core: Fix quota check for Add-Template
It is possible to create a template even if quota has no sufficient
resources for the disk. The internal disk list in the command was
created only after the quota consumption parameters were checked. This
only happens when calling the command from REST API since the UI
initialize the disk list.
The getQuotaStorageConsumptionParameters() method was changed so that if
the internal disk list was not initialized it will be taken directly
from the vm disk list.
Change-Id: I48bffa41aa8a049a184b8cde262ad9c7f9b3baff
Bug-Url:
https://bugzilla.redhat.com/913551
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/12394
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48bffa41aa8a049a184b8cde262ad9c7f9b3baff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>