Moti Asayag has submitted this change and it was merged. Change subject: core: validator - include range as constraint message ...................................................................... core: validator - include range as constraint message when using a @ConfiguredRange it is best to include in the CDA message the actual range that was used and this patch add a constraint violations message - which is interpolated on as a CDA variable to use so now use ${range} in your AppErrors messages SOME_RANGE_ERROR=input out of range ${range} Change-Id: Icc8813288958fdc9a66548c3a013a928d370e28c Signed-off-by: Roy Golan <rgolan@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ConfiguredRangeValidator.java 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc8813288958fdc9a66548c3a013a928d370e28c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server