Oved Ourfali has submitted this change and it was merged.
Change subject: core : Support tokens with special characters
......................................................................
core : Support tokens with special characters
Get rid of splitting search expr by [@: ] which does not support
namespaces that have a space (in dc def for example dc=My Company)
This patch gets the correct search string to be sent to the AD by:
a. Remove ADUSER@/ADGROUP@ from the search string
b. For each existing profile try to test if the search string
starts with it. If so then remove 'PROFILE_NAME:' from the
search string
c. For existing namespaces in selected profile try to test if
search string starts with it. If so then remove 'NAMESPACE:'
from search string
d. Send the query
Also this patch allows to use "#" in string values.
Change-Id: I2464227376eb2e6ee0b5ada2ced21278675b7572
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1096175
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
2 files changed, 53 insertions(+), 14 deletions(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/43127
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2464227376eb2e6ee0b5ada2ced21278675b7572
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org