Alona Kaplan has submitted this change and it was merged. Change subject: engine: "dual mode" on vm with agent should be reported as "virtio" ...................................................................... engine: "dual mode" on vm with agent should be reported as "virtio" vnic with "dual mode" on vm with an agent should be reported to the vdsm as "virtio" only. Currently, there is a leftover code that prepares also an interface with "rtl8139" type. But does nothing with it. So there is not a real bug, just a code fix. Also, the vm.getHasAgent() returned false even if there is an agent on the vm. The cause of the bug is that the guest-agent-version was updated in the RunVmCommand.attachCd method only if there was an active ISO domain in the dc. In this patch the guest agent version update was moved to the runVm method to make sure the version is always updated when trying to run the vm. Change-Id: I072ee66172027d5b4bea1b0ff2f0033d69bf6111 Bug-Url: https://bugzilla.redhat.com/923889 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 2 insertions(+), 9 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072ee66172027d5b4bea1b0ff2f0033d69bf6111 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com>