Arik Hadas has submitted this change and it was merged.
Change subject: core: Fix of "virtual" memory hot (un)plug
......................................................................
core: Fix of "virtual" memory hot (un)plug
Previously engine record of current memory was updated during each
attempt of memory hot (un)plug if the vm was in state PoweringUp
(probably all others than Up or Down).
This path changes UpdateVmCommand#hotSetMemory() method
* Renamed to 'updateCurrentMemory' because it is (and was) used
even if VM is not running.
* If vm is not running, new value of memory is set.
* Otherwise if VM is not up, old value of memory kept.
* Otherwise if memory has changed, attempt to hot plug is fired to VDSM and memory is
set
according to result of VDSM operation.
Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d
Bug-Url:
https://bugzilla.redhat.com/1311899
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 37 insertions(+), 16 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/54739
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>