Allon Mureinik has submitted this change and it was merged. Change subject: core: persist LUN with correct volume_group_id ...................................................................... core: persist LUN with correct volume_group_id When saving a LUN object to the db, we specify what is the needed volume group. In case of an existing LUN - its volume group id would be updated to the new given value. In case that the given LUN isn't in the DB, it'll be saved. This patch ensures that the saved LUN would be saved with the given volume_group_id. NOTES: The motivation for this change is that in cases in which we get the LUN info from VDSM and the LUN is part of an existing VG, saving it with unknown VG to the system will prevent removal of the LUN when it won't be used anymore by the system and might cause confusion and inconsistency. Change-Id: Ia4404b0d17b107208e5ec00c688db305ba0e65fe Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4404b0d17b107208e5ec00c688db305ba0e65fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com>