Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding maximum limitation for image chain. ...................................................................... core: Adding maximum limitation for image chain. Due to the maximum path length, snapshots operations start to fail around the 98th image in the chain. Currently, this is an expected failure as the actual link to the underlying image grows as it walks the chain. When that point is reached, snapshots fail and the VM won't migrate/restart. The engine should limit that number of images for a chain to avoid failures Change-Id: Ib8607dd84bc789c3478aa8d008bedeae40e21a95 Bug-Url: https://bugzilla.redhat.com/1348405 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 71 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8607dd84bc789c3478aa8d008bedeae40e21a95 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>