From Martin Sivák <msivak@redhat.com>:

Martin Sivák has submitted this change and it was merged. Change subject: he: he agent/broker do not really need root privileges ...................................................................... he: he agent/broker do not really need root privileges Earlier, due to compatibility with SysV, both he agent and he broker had to be started with root priviliges and drop them after start. Now, in wonderful systemd world, it can be done externally, with proper systemd configuration, so we do not need that code anymore. Removing daemon support code (including related options) completely makes startup part clearer and seems to be pretty safe, as RHEL/CenOS/Fedora is using systemd at the moment, so daemonization could be done where it belongs - on systemd side. Ubuntu uses upstart, which provides similar functionality. Change-Id: I4e9fe03ce1bfc89421cadd88976f89efc529855f Bug-Url: https://bugzilla.redhat.com/1286568 Signed-off-by: Denis Chaplygin <dchaplyg@redhat.com> --- M initscripts/Makefile.am M initscripts/ovirt-ha-agent.service.in M initscripts/ovirt-ha-broker.service.in A initscripts/ovirt-hosted-engine-ha-tmpfiles.conf.in M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/agent/agent.py M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/broker/broker.py M ovirt_hosted_engine_ha/broker/constants.py.in 9 files changed, 32 insertions(+), 141 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9fe03ce1bfc89421cadd88976f89efc529855f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey@redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>