Tal Nisan has submitted this change and it was merged.
Change subject: core: CommandBaseTest @InjectMocks
......................................................................
core: CommandBaseTest @InjectMocks
Cleaned up the code by using a single instance (where possible) and
injecting mocks to it.
Note that the sessionDataContainer member from the base had to be
spied so Mockito will pick it up and inject it too.
Change-Id: I9237395c1bd40168bfba2a7759ae0ebe68acfe97
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java
2 files changed, 8 insertions(+), 17 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/65198
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9237395c1bd40168bfba2a7759ae0ebe68acfe97
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>