From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RestoreStatelessVmCommand DAO usage
......................................................................
core: RestoreStatelessVmCommand DAO usage
The DAOs methods that return Lists guarantee that if they don't
retrieve any data they return an empty List, not a null.
Checking such a DAO call's result for nullability is redundant at best
and confusing at worst.
Change-Id: I84702bf5ee82c1f55aa2886d839b228b69b3242c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/68675
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84702bf5ee82c1f55aa2886d839b228b69b3242c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>