From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Chaning default cluster attachment for external networks
......................................................................
webadmin: Chaning default cluster attachment for external networks
Until now the external networks were by default not attached to any cluster
when creating, nor was it possible to attach it.
This was very confusing for users.
This patch changes this, attaching an external network to all clusters,
when an external network is created.
It is now also possible to attach/unattach the network from/to clusters.
Enabling attaching/unattaching is important as not all the clusters
could be configured for a given external network.
The 'required' attribute for a network on a cluster stays disabled for
the external network, as an external network can not be a required network.
Whenever a change to the external status changes, we need to set all the
cluster's isAttached values again, in case the user has modified any of
them.
Change-Id: Ic335c4f5bf53da5ce0c3dd48b5e807950a801c16
Bug-Url:
https://bugzilla.redhat.com/1373477
Bug-Url:
https://bugzilla.redhat.com/1383449
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/67877
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic335c4f5bf53da5ce0c3dd48b5e807950a801c16
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>