Juan Hernandez has submitted this change and it was merged. Change subject: core: Add external identifier to DbUser ...................................................................... core: Add external identifier to DbUser We currently store users and groups in the database using the DbUser entity, and this entity uses the identifier provided by the LDAP server as its primary key. This assumes that the identifiers provided by LDAP servers are unique, even those provided by different LDAP servers, which isn't correct. This change adds a new "ExternalId" attribute to DbUser intended to store the identifier used by the LDAP server, so in the future we will be able to use an unique identifier generated by the engine. Change-Id: Iaf81ba87a178f3d275ed172e82b0036635f1a28f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com&gt; --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0620_add_external_id_to_users.sql M packaging/dbscripts/user_sp.sql 8 files changed, 153 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf81ba87a178f3d275ed172e82b0036635f1a28f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server