Liron Aravot has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainWithOvfUpdate - locks ...................................................................... core: DeactivateStorageDomainWithOvfUpdate - locks The lock taken by the command should be released at the end of the endAction() method, therfore we should avoid passing it to the child command (so it won't be released by it). Also, avoid releasing the in memory lock while there are still tasks. Change-Id: Id8199e372d72f673aeb7b16d12cc8f5ffa043117 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8199e372d72f673aeb7b16d12cc8f5ffa043117 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server