Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean ActionVersionMap's DAO ...................................................................... core: Clean ActionVersionMap's DAO ActionVersionMap's are not (and should not!) be update from within the application, only by upgrade scripts. Hence, there's no reason to have a DAO that can manipulate them, and these methods are indeed not used outside of the test's scope. This patch removes these redundant methods, as well as the stored procedures that back them up. Change-Id: Iff6f8ea4a8ee81c60d983a6973bb3334d3e883a0 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDaoTest.java M packaging/dbscripts/action_version_map_sp.sql 4 files changed, 0 insertions(+), 99 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff6f8ea4a8ee81c60d983a6973bb3334d3e883a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>