2:07 p.m.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: DOM flag to guard user interaction
......................................................................
webadmin,userportal: DOM flag to guard user interaction
Both WebAdmin and UserPortal are single-page web applications
comprised of multiple places (UI states). Transitions between
application's places are triggered either via UI interaction
(e.g. clicking a main tab) or via manual URL change.
Once the application starts transitioning from one place to
another, user interaction should be avoided. For human users,
this is accomplished via invisible "glass" overlay [1] that
effectively blocks user-triggered DOM events (e.g. click)
from reaching application's UI.
[1] com.gwtplatform.mvp.client.RootPresenter.RootView#glass
For automated test scripts, checking for "glass" overlay can
be unnecessarily complex. This patch ensures that DOM <body>
flag (data attribute) is set to reflect the current status
of the application:
<!-- Avoid DOM interaction, application busy -->
<body data-app-status="busy">
<!-- Proceed with DOM interaction, application ready -->
<body data-app-status="ready"> ... </body>
Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc
Bug-Url: https://bugzilla.redhat.com/1150581
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/LockInteractionManager.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/47049
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I214493322774cf7727433c3a63d6ebfa7d3177cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
3388
days inactive
3388
days old
0 comments
1 participants
participants (1)
-
tnisan＠redhat.com