Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - CommandStep/FINALIZING step ...................................................................... core: CommandBase - CommandStep/FINALIZING step This patch prevents adding a finalizing step to steps added by overriding getCommandStep(). The finalizing step is currently used for steps and not for jobs only in very specific cases in which also validation and execution steps are added to a step/sub step. When command is adding a step by overriding getCommandStep() its intended to add a "simple" step as replacement to the async tasks added steps when jobs are used instead of tasks therefore there's no need to add a finalizing step when the step was added by getCommandStep(). Change-Id: I9c6d7a5aebfbfa176fca5e8d90b6127ee7cc7a5f Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c6d7a5aebfbfa176fca5e8d90b6127ee7cc7a5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>