Change in ovirt-engine[master]: webadmin: Reimplement VmSnapshotsListModel#imagesSubtract

From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Reimplement VmSnapshotsListModel#imagesSubtract ...................................................................... webadmin: Reimplement VmSnapshotsListModel#imagesSubtract Reimplement imagesSubtract using IdsPredicate instead of boiler-plate for loops. As an added bonus, this implementation only traverses each list once, instead of performing a nested loop. Change-Id: I2d53792c94ba978018054e44d7d61af577b4ed01 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d53792c94ba978018054e44d7d61af577b4ed01 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review