From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ImageTranferDao#getAllIds
......................................................................
core: Remove unused ImageTranferDao#getAllIds
ImageTransferDao#getAllIds was never used since the day it was
introduced, and it doesn't seem as though there are any plans to ever
use it, not to mention the fact the same functionality can easily be
obtained by existing methods:
imageTransferDao.getAll()
.stream()
.map(BusinessEntity::getId)
.collect(Collectors.toList());
This patch removes this unused method from the interface, its
implementation and the underlying stored procedure that implements its
logic.
Change-Id: Iedd95a5377dad641bb908c216201cc638fc3c6cf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java
M packaging/dbscripts/image_transfers_sp.sql
3 files changed, 0 insertions(+), 28 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Amit Aviram: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/68678
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedd95a5377dad641bb908c216201cc638fc3c6cf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>