From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix: Json RPC interfaces do not depend on XML interfaces
......................................................................
Fix: Json RPC interfaces do not depend on XML interfaces
Previously json RPC interfaces imported vdsmxmlrpcInterface
which imports vdsm.vdscli.
This throws an exception in newer version of vdsm,
where the vdsm.vdscli module is removed.
Patch which removed the module:
https://gerrit.ovirt.org/#/c/72767/
Change-Id: I79159b237c456d3ce9fee87340eb1404449c126c
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/75075
Continuous-Integration: Jenkins CI
Reviewed-by: Jenny Tokar <jtokar(a)redhat.com>
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
---
M mom/HypervisorInterfaces/Makefile.am
A mom/HypervisorInterfaces/vdsmCommon.py
M mom/HypervisorInterfaces/vdsmjsonrpcInterface.py
M mom/HypervisorInterfaces/vdsmjsonrpcbulkInterface.py
M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py
M mom/HypervisorInterfaces/vdsmxmlrpcbulkInterface.py
6 files changed, 63 insertions(+), 46 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Looks good to me, but someone else must approve
Andrej Krejcir: Verified
--
To view, visit
https://gerrit.ovirt.org/75075
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79159b237c456d3ce9fee87340eb1404449c126c
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>