Alona Kaplan has submitted this change and it was merged. Change subject: userportal,webadmin: refactored badly overgrown method to more understandable parts ...................................................................... userportal,webadmin: refactored badly overgrown method to more understandable parts • method broken into three methods: ◦ method checking if there's valid operation for first operand. ◦ method handling unary operation applied on first operand ◦ method handling binary operations. • removed unnecessary elses to reduce indentation • overloaded operationFor methods moved close together • 'instanceof BondNetworkInterfaceModel' is performed on closer superclass (NetworkInterfaceModel) instead of NetworkItemModel to allow move casting to caller method (handleBinaryOperation) and altered one (binaryOperationWithNetworkInterfaceModelOperand) can deal only with NetworkInterfaceModel and not with NetworkItemModel. Change-Id: Ie84e1c7fb7324279b5a8687d1ad6ffc605f921a0 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 2 files changed, 187 insertions(+), 129 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84e1c7fb7324279b5a8687d1ad6ffc605f921a0 Gerrit-PatchSet: 95 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: automation@ovirt.org