Allon Mureinik has submitted this change and it was merged. Change subject: userportal: fix possible NPE in % progress bar ...................................................................... userportal: fix possible NPE in % progress bar DoublePercentageProgressBar unboxes valueA and valueB (into fakeA and fakeB, respectively), and only then checks if they were null. If either of them is indeed null, we will get a NullPointerException from the outboxing, and won't even reach the null check. This patch moves the relevant code into the null-safe condition. Change-Id: Id7a65802cc79a698863899085189ea80fcc6d57f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.java 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/12334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7a65802cc79a698863899085189ea80fcc6d57f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: ofri masad <omasad@redhat.com>