Tal Nisan has submitted this change and it was merged. Change subject: core: Remove duplicate code in HotPlugDiskToVmCommandTest ...................................................................... core: Remove duplicate code in HotPlugDiskToVmCommandTest All tests are mocking DiskDao and VmDao in the command either directly or by calling another method, moved those to the setup method. Inlined the oneline method mockVMDao Change-Id: I18cec31ac2842145d2a106f36671968d547d4c16 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 3 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18cec31ac2842145d2a106f36671968d547d4c16 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>