February 2015 - Kimchi-devel - oVirt List Archives

[PATCH] issue #512: Attach the function "showMessage" to the UI grid class
by Crístian Viana 24 Feb '15

24 Feb '15

The JavaScript "class" kimchi.widget.Grid (which renders the packages and repositories list) lacks the function "showMessage" (which displays a message inside the grid). The function itself is already declared but it isn't attached to the class, so it cannot be used. When an error happens while reading the update packages or repositories list, that function is supposed to be executed, however it doesn't exist in the class and nothing is displayed. Attach the function "showMessage" to its corresponding class so it can be used correctly. In order to test this patch, create a failing scenario to get the update packages list and open the tab "Hosts". Without this patch, the update grid will be empty; with this patch, an error message will be displayed in the update grid. On Fedora, the failing scenario can be created by running "sudo yum update" (when there are packages to be updated) and not confirming the update, so Yum leaves a lock preventing other simultaneous operations to be executed. Fix issue #512 ("Software updates" doesn't show available updates). Signed-off-by: Crístian Viana <vianac(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.grid.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/js/src/kimchi.grid.js b/ui/js/src/kimchi.grid.js index 26e05d5..6365d5c 100644 --- a/ui/js/src/kimchi.grid.js +++ b/ui/js/src/kimchi.grid.js @@ -522,6 +522,7 @@ kimchi.widget.Grid.prototype = (function() { setData: setData, getSelected: getSelected, reload: reload, - destroy: destroy + destroy: destroy, + showMessage: showMessage }; })(); -- 2.1.0

2 1

[PATCH v2 0/2] ISO Scan grammar fix
by Christy Perez 24 Feb '15

24 Feb '15

Change "It will take long time" to "This may take a long time." Christy Perez (2): Fix iso scan warning's EN grammar Cleaning up fuzzy translation strings after make po/de_DE.po | 117 ++++++++++++++++++++++++---------------------- po/en_US.po | 94 +++++++++++++++++++------------------ po/es_ES.po | 117 ++++++++++++++++++++++++---------------------- po/fr_FR.po | 121 +++++++++++++++++++++++++----------------------- po/it_IT.po | 117 ++++++++++++++++++++++++---------------------- po/ja_JP.po | 118 ++++++++++++++++++++++++---------------------- po/kimchi.pot | 97 +++++++++++++++++++------------------- po/ko_KR.po | 117 ++++++++++++++++++++++++---------------------- po/pt_BR.po | 117 ++++++++++++++++++++++++---------------------- po/ru_RU.po | 117 ++++++++++++++++++++++++---------------------- po/zh_CN.po | 31 ++++++++----- po/zh_TW.po | 121 +++++++++++++++++++++++++----------------------- ui/pages/i18n.json.tmpl | 2 +- 13 files changed, 681 insertions(+), 605 deletions(-) -- 2.1.0

2 3

[PATCH] Fix iso scan warning's EN grammar
by Christy Perez 24 Feb '15

24 Feb '15

The patch is the manual changes only, without running the make commands. There are a lot of other translation changes that will be pulled in after a make, so I'm leaving that step out for simplicity when reviewing this patch. If needed, I can run make and re-submit after review. Signed-off-by: Christy Perez <christy(a)linux.vnet.ibm.com> --- po/de_DE.po | 2 +- po/en_US.po | 2 +- po/es_ES.po | 2 +- po/fr_FR.po | 2 +- po/it_IT.po | 2 +- po/ja_JP.po | 2 +- po/kimchi.pot | 2 +- po/ko_KR.po | 2 +- po/pt_BR.po | 2 +- po/ru_RU.po | 2 +- po/zh_CN.po | 2 +- po/zh_TW.po | 2 +- ui/pages/i18n.json.tmpl | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/po/de_DE.po b/po/de_DE.po index 5116d1f..a730040 100644 --- a/po/de_DE.po +++ b/po/de_DE.po @@ -1466,7 +1466,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "Dies ist keine g��ltige ISO-Datei." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "Dies wird einige Zeit dauern. M��chten Sie fortfahren?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/en_US.po b/po/en_US.po index 05ca48a..8c3aeda 100644 --- a/po/en_US.po +++ b/po/en_US.po @@ -1338,7 +1338,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "" -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/es_ES.po b/po/es_ES.po index 573dc03..f9c26fe 100644 --- a/po/es_ES.po +++ b/po/es_ES.po @@ -1485,7 +1485,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "No es un archivo ISO v��lido." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "Tardar�� mucho tiempo. ��Desea continuar?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/fr_FR.po b/po/fr_FR.po index 715d612..ad3abb2 100644 --- a/po/fr_FR.po +++ b/po/fr_FR.po @@ -1502,7 +1502,7 @@ msgstr "Aucune ISO d��tect��e" msgid "This is not a valid ISO file." msgstr "Ce n'est pas un fichier ISO valide." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "Cela va prendre un long moment. Voulez-vous continuer ?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/it_IT.po b/po/it_IT.po index 1746bed..759f4a2 100644 --- a/po/it_IT.po +++ b/po/it_IT.po @@ -1454,7 +1454,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "Non �� un file ISO valido." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "Richieder�� molto tempo. Continuare?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/ja_JP.po b/po/ja_JP.po index f9fe5ee..c28d764 100644 --- a/po/ja_JP.po +++ b/po/ja_JP.po @@ -1463,7 +1463,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "�� ISO ��" -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "��?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/kimchi.pot b/po/kimchi.pot index 1923fad..f2456f3 100755 --- a/po/kimchi.pot +++ b/po/kimchi.pot @@ -1338,7 +1338,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "" -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/ko_KR.po b/po/ko_KR.po index 0f6f530..2d01193 100644 --- a/po/ko_KR.po +++ b/po/ko_KR.po @@ -1395,7 +1395,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "�� ISO �� ." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "�� . ��?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/pt_BR.po b/po/pt_BR.po index 898ee5d..10ac33e 100644 --- a/po/pt_BR.po +++ b/po/pt_BR.po @@ -1513,7 +1513,7 @@ msgstr "Nenhuma ISO encontrada" msgid "This is not a valid ISO file." msgstr "Esse n��o �� um arquivo ISO v��lido." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "Isso vai levar um longo tempo. Deseja continuar?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/ru_RU.po b/po/ru_RU.po index fa8d121..8233e99 100644 --- a/po/ru_RU.po +++ b/po/ru_RU.po @@ -1396,7 +1396,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "�� ISO." -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "�� . ��?" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/zh_CN.po b/po/zh_CN.po index 82d2980..a307e3b 100644 --- a/po/zh_CN.po +++ b/po/zh_CN.po @@ -1372,7 +1372,7 @@ msgstr "��ISO��" msgid "This is not a valid ISO file." msgstr "��ISO��" -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "��" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/po/zh_TW.po b/po/zh_TW.po index a12a56e..776bd52 100644 --- a/po/zh_TW.po +++ b/po/zh_TW.po @@ -1343,7 +1343,7 @@ msgstr "" msgid "This is not a valid ISO file." msgstr "�� ISO ��" -msgid "It will take long time. Do you want to continue?" +msgid "This may take a long time. Do you want to continue?" msgstr "��" msgid "This will permanently delete the template. Would you like to continue?" diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl index a4a6dd5..b170d26 100644 --- a/ui/pages/i18n.json.tmpl +++ b/ui/pages/i18n.json.tmpl @@ -58,7 +58,7 @@ "KCHTMPL6002E": "$_("This is not a valid ISO file.")", - "KCHTMPL6002M": "$_("It will take long time. Do you want to continue?")", + "KCHTMPL6002M": "$_("This may take a long time. Do you want to continue?")", "KCHTMPL6003M": "$_("This will permanently delete the template. Would you like to continue?")", "KCHHOST6001E": "$_("Unable to shut down system as there are some virtual machines running!")", -- 2.1.0

2 4

[PATCH 0/3] *** Improved support for Arch Linux ***
by Alan Jenkins 24 Feb '15

24 Feb '15

Hey guys, These patches improve support for Arch Linux within Kimchi. They add support for detecting the Arch Linux distribution's releases and mark it as a modern distribution to enable Kimchi to automatically turn on support for virtio-net with Arch Linux virtual machines. I however still have yet to find the code that is able to identify a distribution from a disk image, could someone point me in the direction of that code? Thanks, Alan Jenkins Alan Jenkins (3): Add Arch Linux entry to isoinfo. Add modern entry for Arch Linux. Added Arch Icon. src/kimchi/isoinfo.py | 1 + src/kimchi/osinfo.py | 2 +- ui/images/icon-arch.png | Bin 0 -> 3868 bytes 3 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 ui/images/icon-arch.png -- 2.2.2

4 18

[PATCH] Set allocation=capacity when creating images in logical pools
by Christy Perez 24 Feb '15

24 Feb '15

If allocation is set to 0 for images in logical storage, they cannot be used. You may see an error similar to: /dev/VMs_Storage_R5/ed229d7b-5248-4499-8758-43069dd79fe7-0.img: \ read failed after 0 of 65536 at 21474770944: Input/output error When attempting to access the image. When using the image, the guest may report that it is unable to write to the disk (I/O error). Signed-off-by: Christy Perez <christy(a)linux.vnet.ibm.com> --- src/kimchi/vmtemplate.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/kimchi/vmtemplate.py b/src/kimchi/vmtemplate.py index d4fbe8b..ef41d0a 100644 --- a/src/kimchi/vmtemplate.py +++ b/src/kimchi/vmtemplate.py @@ -202,8 +202,12 @@ def to_volume_list(self, vm_uuid): 'capacity': d['size'], 'format': fmt, 'path': '%s/%s' % (storage_path, volume)} - info['allocation'] = 0 if fmt in ['qcow2', 'raw'] \ - else info['capacity'] + + if 'logical' == self._get_storage_type() or \ + fmt not in ['qcow2', 'raw']: + info['allocation'] = info['capacity'] + else: + info['allocation'] = 0 if 'base' in d: info['base'] = dict() -- 2.1.0

3 2

[PATCH] Disable SSL on nginx
by Tulio Magno Quites Machado Filho 24 Feb '15

24 Feb '15

This patch helps to protect Kimchi against CVE-2014-3566 by completely disabling SSLv3 on nginx. --- src/nginx.conf.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nginx.conf.in b/src/nginx.conf.in index b5d207f..ed926a3 100644 --- a/src/nginx.conf.in +++ b/src/nginx.conf.in @@ -52,6 +52,7 @@ http { ssl_certificate ${cert_pem}; ssl_certificate_key ${cert_key}; + ssl_protocols TLSv1 TLSv1.1 TLSv1.2; add_header Strict-Transport-Security "max-age=31536000; includeSubdomains;"; add_header X-Frame-Options DENY; -- 2.1.0

3 2

[PATCH] Set Arch Linux PNG image to be used on frontend always.
by Paulo Vital 19 Feb '15

19 Feb '15

Signed-off-by: Paulo Vital <pvital(a)gmail.com> --- ui/css/theme-default/template_add.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ui/css/theme-default/template_add.css b/ui/css/theme-default/template_add.css index e58bccb..580a3f3 100644 --- a/ui/css/theme-default/template_add.css +++ b/ui/css/theme-default/template_add.css @@ -199,6 +199,11 @@ background-image: url(../../images/icon-gentoo.png); } +.iso-icon.arch { + background-image: url(../../images/icon-arch.png); +} + + .list-iso { overflow: hidden; margin: 5px; -- 2.1.4

3 2

[DISCUSSION] If virbr0 is an existent bridge, libvirt will fail to create default network
by Ramon Medeiros 19 Feb '15

19 Feb '15

Hi Team, i got this issue on https://github.com/kimchi-project/kimchi/issues/556. What we can do: 1) The fix seems to be upstream. But not sure if it will be available soon 2) Run a check, like we do for subnet, to see if it's already created. If not, we can created it and pass to libvirt. -- Ramon Nunes Medeiros Kimchi Developer Software Engineer - Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn(a)br.ibm.com

3 3

[PATCH] Remove Non-ASCII chars from tests when unnecessary
by Christy Perez 16 Feb '15

16 Feb '15

A domain with non-ASCII characters will fail to start. There are several tests that use such characters, and these tests fail. None of the failing tests are required to test the validity of non-ascii characters, so it's best to remove them and create seperate tests explicitly for these chracters. This way we will not be masking actual issues by ignoring an expected failure. The issue was first noticed with libvirt 1.1.3. The character issue is discussed in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1062943 Signed-off-by: Christy Perez <christy(a)linux.vnet.ibm.com> --- tests/test_model.py | 113 +++++++++++++++++++++++++++----------- tests/test_model_network.py | 6 +- tests/test_model_storagepool.py | 26 +++++++++ tests/test_model_storagevolume.py | 1 - 4 files changed, 113 insertions(+), 33 deletions(-) diff --git a/tests/test_model.py b/tests/test_model.py index f80f1c9..aa265f5 100644 --- a/tests/test_model.py +++ b/tests/test_model.py @@ -96,6 +96,45 @@ def test_vm_info(self): self.assertEquals([], info['groups']) self.assertTrue(info['persistent']) + + @unittest.skipUnless(utils.running_as_root(), 'Must be run as root') + def test_non_ascii_vm_name(self): + inst = model.Model(objstore_loc=self.tmp_store) + + with RollbackContext() as rollback: + vol_params = {'name': u'test-vol', 'capacity': 1024} + task = inst.storagevolumes_create(u'default', vol_params) + rollback.prependDefer(inst.storagevolume_delete, u'default', + vol_params['name']) + inst.task_wait(task['id']) + task = inst.task_lookup(task['id']) + self.assertEquals('finished', task['status']) + vol = inst.storagevolume_lookup(u'default', vol_params['name']) + + # Create template + params = {'name': 'test', 'disks': [{'base': vol['path'], + 'size': 1}], + 'cdrom': self.kimchi_iso} + inst.templates_create(params) + rollback.prependDefer(inst.template_delete, 'test') + + # Create VM with non-ascii char name + params = {'name': u'пeω-∨м', 'template': '/templates/test'} + inst.vms_create(params) + rollback.prependDefer(inst.vm_delete, u'пeω-∨м') + + vms = inst.vms_get_list() + self.assertTrue(u'пeω-∨м' in vms) + + # Start VM + # Note: This fails with libvirt > 1.1.3 + inst.vm_start(u'пeω-∨м') + info = inst.vm_lookup(u'пeω-∨м') + self.assertEquals('running', info['state']) + + vms = inst.vms_get_list() + self.assertFalse(u'пeω-∨м' in vms) + @unittest.skipUnless(utils.running_as_root(), 'Must be run as root') def test_vm_lifecycle(self): inst = model.Model(objstore_loc=self.tmp_store) @@ -620,6 +659,18 @@ def test_template_storage_customise(self): params = {'storagepool': '/storagepools/default'} inst.template_update('test', params) + def test_non_ascii_template_create(self): + inst = model.Model('test:///default', + objstore_loc=self.tmp_store) + + with RollbackContext() as rollback: + params = {'name': u'пeω-teмplate', 'memory': 1024, 'cpus': 1, + 'cdrom': self.kimchi_iso} + inst.templates_create(params) + rollback.prependDefer(inst.template_delete, u'пeω-teмplate') + info = inst.template_lookup(u'пeω-teмplate') + self.assertEquals(info['name'], u'пeω-teмplate') + @unittest.skipUnless(utils.running_as_root(), 'Must be run as root') def test_template_create(self): inst = model.Model('test:///default', @@ -737,7 +788,7 @@ def test_template_update(self): inst.network_activate(net_name) rollback.prependDefer(inst.network_deactivate, net_name) - net_name = u'kīмсhī-пet' + net_name = u'kimchi-net' net_args = {'name': net_name, 'connection': 'nat', 'subnet': '127.0.20.0/24'} @@ -764,7 +815,7 @@ def test_template_update(self): self.assertEquals("default", info["networks"][0]) params = {'name': 'new-test', 'memory': 1024, 'cpus': 1, - 'networks': ['default', 'test-network', u'kīмсhī-пet']} + 'networks': ['default', 'test-network', u'kimchi-net']} inst.template_update('new-test', params) info = inst.template_lookup('new-test') for key in params.keys(): @@ -792,7 +843,7 @@ def test_template_update(self): self.assertEquals('some-vm', inst.vms_create(params)) rollback.prependDefer(inst.vm_delete, 'some-vm') - iface_args = {'type': 'network', 'network': u'kīмсhī-пet'} + iface_args = {'type': 'network', 'network': u'kimchi-net'} mac = inst.vmifaces_create('some-vm', iface_args) self.assertEquals(17, len(mac)) @@ -865,52 +916,52 @@ def test_vm_edit(self): self.assertRaises(OperationFailed, inst.vm_update, 'kimchi-vm1', {'name': 'kimchi-vm2'}) - params = {'name': u'пeω-∨м', 'cpus': 4, 'memory': 2048} + params = {'name': u'new-vm', 'cpus': 4, 'memory': 2048} inst.vm_update('kimchi-vm1', params) rollback.prependDefer(utils.rollback_wrapper, inst.vm_delete, - u'пeω-∨м') - self.assertEquals(info['uuid'], inst.vm_lookup(u'пeω-∨м')['uuid']) - info = inst.vm_lookup(u'пeω-∨м') + u'new-vm') + self.assertEquals(info['uuid'], inst.vm_lookup(u'new-vm')['uuid']) + info = inst.vm_lookup(u'new-vm') for key in params.keys(): self.assertEquals(params[key], info[key]) # change only VM users - groups are not changed (default is empty) users = inst.users_get_list()[:3] - inst.vm_update(u'пeω-∨м', {'users': users}) - self.assertEquals(users, inst.vm_lookup(u'пeω-∨м')['users']) - self.assertEquals([], inst.vm_lookup(u'пeω-∨м')['groups']) + inst.vm_update(u'new-vm', {'users': users}) + self.assertEquals(users, inst.vm_lookup(u'new-vm')['users']) + self.assertEquals([], inst.vm_lookup(u'new-vm')['groups']) # change only VM groups - users are not changed (default is empty) groups = inst.groups_get_list()[:2] - inst.vm_update(u'пeω-∨м', {'groups': groups}) - self.assertEquals(users, inst.vm_lookup(u'пeω-∨м')['users']) - self.assertEquals(groups, inst.vm_lookup(u'пeω-∨м')['groups']) + inst.vm_update(u'new-vm', {'groups': groups}) + self.assertEquals(users, inst.vm_lookup(u'new-vm')['users']) + self.assertEquals(groups, inst.vm_lookup(u'new-vm')['groups']) # change VM users and groups by adding a new element to each one users.append(pwd.getpwuid(os.getuid()).pw_name) groups.append(grp.getgrgid(os.getgid()).gr_name) - inst.vm_update(u'пeω-∨м', {'users': users, 'groups': groups}) - self.assertEquals(users, inst.vm_lookup(u'пeω-∨м')['users']) - self.assertEquals(groups, inst.vm_lookup(u'пeω-∨м')['groups']) + inst.vm_update(u'new-vm', {'users': users, 'groups': groups}) + self.assertEquals(users, inst.vm_lookup(u'new-vm')['users']) + self.assertEquals(groups, inst.vm_lookup(u'new-vm')['groups']) # change VM users (wrong value) and groups # when an error occurs, everything fails and nothing is changed - self.assertRaises(InvalidParameter, inst.vm_update, u'пeω-∨м', + self.assertRaises(InvalidParameter, inst.vm_update, u'new-vm', {'users': ['userdoesnotexist'], 'groups': []}) - self.assertEquals(users, inst.vm_lookup(u'пeω-∨м')['users']) - self.assertEquals(groups, inst.vm_lookup(u'пeω-∨м')['groups']) + self.assertEquals(users, inst.vm_lookup(u'new-vm')['users']) + self.assertEquals(groups, inst.vm_lookup(u'new-vm')['groups']) # change VM users and groups (wrong value) # when an error occurs, everything fails and nothing is changed - self.assertRaises(InvalidParameter, inst.vm_update, u'пeω-∨м', + self.assertRaises(InvalidParameter, inst.vm_update, u'new-vm', {'users': [], 'groups': ['groupdoesnotexist']}) - self.assertEquals(users, inst.vm_lookup(u'пeω-∨м')['users']) - self.assertEquals(groups, inst.vm_lookup(u'пeω-∨м')['groups']) + self.assertEquals(users, inst.vm_lookup(u'new-vm')['users']) + self.assertEquals(groups, inst.vm_lookup(u'new-vm')['groups']) # change VM users and groups by removing all elements - inst.vm_update(u'пeω-∨м', {'users': [], 'groups': []}) - self.assertEquals([], inst.vm_lookup(u'пeω-∨м')['users']) - self.assertEquals([], inst.vm_lookup(u'пeω-∨м')['groups']) + inst.vm_update(u'new-vm', {'users': [], 'groups': []}) + self.assertEquals([], inst.vm_lookup(u'new-vm')['users']) + self.assertEquals([], inst.vm_lookup(u'new-vm')['groups']) def test_multithreaded_connection(self): def worker(): @@ -1090,19 +1141,19 @@ def test_delete_running_vm(self): inst.templates_create(params) rollback.prependDefer(inst.template_delete, 'test') - params = {'name': u'kīмсhī-∨м', 'template': u'/templates/test'} + params = {'name': 'kimchi-vm', 'template': u'/templates/test'} inst.vms_create(params) rollback.prependDefer(utils.rollback_wrapper, inst.vm_delete, - u'kīмсhī-∨м') + 'kimchi-vm') - inst.vm_start(u'kīмсhī-∨м') + inst.vm_start('kimchi-vm') rollback.prependDefer(utils.rollback_wrapper, inst.vm_poweroff, - u'kīмсhī-∨м') + 'kimchi-vm') - inst.vm_delete(u'kīмсhī-∨м') + inst.vm_delete('kimchi-vm') vms = inst.vms_get_list() - self.assertFalse(u'kīмсhī-∨м' in vms) + self.assertFalse('kimchi-vm' in vms) @unittest.skipUnless(utils.running_as_root(), 'Must be run as root') def test_vm_list_sorted(self): diff --git a/tests/test_model_network.py b/tests/test_model_network.py index 5dbe54d..c61f37c 100644 --- a/tests/test_model_network.py +++ b/tests/test_model_network.py @@ -99,6 +99,10 @@ class NetworkTests(unittest.TestCase): def setUp(self): self.request = partial(request, host, ssl_port) + def test_non_ascii_net_names(self): + net = {'name': u'kīмсhī-пet', 'connection': 'isolated'} + _do_network_test(self, model, net) + def test_get_networks(self): networks = json.loads(self.request('/networks').read()) self.assertIn('default', [net['name'] for net in networks]) @@ -127,7 +131,7 @@ def test_get_networks(self): def test_network_lifecycle(self): # Verify all the supported network type - networks = [{'name': u'kīмсhī-пet', 'connection': 'isolated'}, + networks = [{'name': u'kimchi-net', 'connection': 'isolated'}, {'name': u'nat-network', 'connection': 'nat'}, {'name': u'subnet-network', 'connection': 'nat', 'subnet': '127.0.100.0/24'}] diff --git a/tests/test_model_storagepool.py b/tests/test_model_storagepool.py index eabf875..35c62fc 100644 --- a/tests/test_model_storagepool.py +++ b/tests/test_model_storagepool.py @@ -60,6 +60,32 @@ class StoragepoolTests(unittest.TestCase): def setUp(self): self.request = partial(request, host, ssl_port) + def test_non_ascii_storagepool_name(self): + storagepools = json.loads(self.request('/storagepools').read()) + self.assertIn('default', [pool['name'] for pool in storagepools]) + + with RollbackContext() as rollback: + name = u'kīмсhī-storagepool' + req = json.dumps({'name': name, 'type': 'dir', + 'path': '/var/lib/libvirt/images/test_pool'}) + resp = self.request('/storagepools', req, 'POST') + rollback.prependDefer(model.storagepool_delete, name) + + self.assertEquals(201, resp.status) + + # Verify pool information + resp = self.request('/storagepools/%s' % name.encode("utf-8")) + p = json.loads(resp.read()) + keys = [u'name', u'state', u'capacity', u'allocated', + u'available', u'path', u'source', u'type', + u'nr_volumes', u'autostart', u'persistent'] + self.assertEquals(sorted(keys), sorted(p.keys())) + self.assertEquals(name, p['name']) + resp = self.request('/storagepools/%s/activate' % name.encode('utf-8'), req, 'POST') + rollback.prependDefer(model.storagepool_deactivate, name) + p = json.loads(resp.read()) + self.assertEquals('active', p['state']) + def test_get_storagepools(self): storagepools = json.loads(self.request('/storagepools').read()) self.assertIn('default', [pool['name'] for pool in storagepools]) diff --git a/tests/test_model_storagevolume.py b/tests/test_model_storagevolume.py index a3c3ce3..39531e9 100644 --- a/tests/test_model_storagevolume.py +++ b/tests/test_model_storagevolume.py @@ -1,4 +1,3 @@ -# -*- coding: utf-8 -*- # # Project Kimchi # -- 2.1.0

1 1

Scrum meeting on Feb. 18th cancelled
by Aline Manera 13 Feb '15

13 Feb '15

Hi folks, As I mentioned in the last scrum meeting, I will be out next week for the Linux Foundation Collaboration Summit where I will do a presentation about Kimchi. Because that we will not have the usual scrum meeting on Feb 18th. Regards, Aline Manera

1 0

[PATCH 0/2] Issue #556: Unable to create bridge virbr0: File already exists
by Ramon Medeiros 12 Feb '15

12 Feb '15

Discovery which bridge is available and pass it when creating the default network pool. Ramon Medeiros (2): Implement function to discover which bridge name is available Pass bridge name on NAT network creation src/kimchi/model/networks.py | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) -- 1.8.3.1

1 2

[PATCH] Fix issue #589: Add listener to remove Kimchi leftovers
by Aline Manera 12 Feb '15

12 Feb '15

If Kimchi is stopped before it gets completely up, it can leave some leftovers on system due the Feature tests. So add a listener to cherrypy server to clean up any leftovers when server is stopped. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- src/kimchi/kvmusertests.py | 19 ++++++++----------- src/kimchi/model/config.py | 27 +++++++++++++++++++++++++-- src/kimchi/model/featuretests.py | 21 +++++++++++++-------- 3 files changed, 46 insertions(+), 21 deletions(-) diff --git a/src/kimchi/kvmusertests.py b/src/kimchi/kvmusertests.py index 408706d..37a80d7 100644 --- a/src/kimchi/kvmusertests.py +++ b/src/kimchi/kvmusertests.py @@ -18,18 +18,18 @@ import platform import psutil -import uuid import libvirt from kimchi.rollbackcontext import RollbackContext +KVMUSERTEST_VM_NAME = "KVMUSERTEST_VM" + class UserTests(object): SIMPLE_VM_XML = """ <domain type='kvm'> - <name>%(vm_name)s</name> - <uuid>%(vm_uuid)s</uuid> + <name>%(name)s</name> <memory unit='KiB'>262144</memory> <os> <type arch='%(arch)s'>hvm</type> @@ -43,22 +43,19 @@ class UserTests(object): if cls.user: return cls.user - vm_uuid = uuid.uuid1() - vm_name = "kimchi_test_%s" % vm_uuid arch = 'ppc64' if platform.machine() == 'ppc64le' \ else platform.machine() - xml = cls.SIMPLE_VM_XML % {'vm_name': vm_name, 'vm_uuid': vm_uuid, - 'arch': arch} + xml = cls.SIMPLE_VM_XML % {'name': KVMUSERTEST_VM_NAME, 'arch': arch} with RollbackContext() as rollback: conn = libvirt.open(None) rollback.prependDefer(conn.close) - dom = conn.defineXML(xml) - rollback.prependDefer(dom.undefine) - dom.create() + dom = conn.createXML(xml, + flags=libvirt.VIR_DOMAIN_START_AUTODESTROY) rollback.prependDefer(dom.destroy) - with open('/var/run/libvirt/qemu/%s.pid' % vm_name) as f: + filename = '/var/run/libvirt/qemu/%s.pid' % KVMUSERTEST_VM_NAME + with open(filename) as f: pidStr = f.read() p = psutil.Process(int(pidStr)) diff --git a/src/kimchi/model/config.py b/src/kimchi/model/config.py index 6a7df41..1c43360 100644 --- a/src/kimchi/model/config.py +++ b/src/kimchi/model/config.py @@ -1,7 +1,7 @@ # # Project Kimchi # -# Copyright IBM, Corp. 2014 +# Copyright IBM, Corp. 2014-2015 # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -27,7 +27,8 @@ from kimchi.config import find_qemu_binary, get_version from kimchi.distroloader import DistroLoader from kimchi.exception import NotFoundError from kimchi.model.debugreports import DebugReportsModel -from kimchi.model.featuretests import FeatureTests +from kimchi.model.featuretests import FeatureTests, FEATURETEST_POOL_NAME +from kimchi.model.featuretests import FEATURETEST_VM_NAME from kimchi.repositories import Repositories from kimchi.screenshot import VMScreenshot from kimchi.swupdate import SoftwareUpdate @@ -61,6 +62,28 @@ class CapabilitiesModel(object): # It is needed because some features tests depends on the server cherrypy.engine.subscribe('start', self._set_capabilities) + # Subscribe function to clean any Kimchi leftovers + cherrypy.engine.subscribe('stop', self._clean_leftovers) + + def _clean_leftovers(self): + conn = self.conn.get() + FeatureTests.disable_libvirt_error_logging() + try: + dom = conn.lookupByName(FEATURETEST_VM_NAME) + dom.undefine() + except Exception: + # Any exception can be ignored here + pass + + try: + pool = conn.storagePoolLookupByName(FEATURETEST_POOL_NAME) + pool.undefine() + except Exception: + # Any exception can be ignored here + pass + + FeatureTests.enable_libvirt_error_logging() + def _set_capabilities(self): kimchi_log.info("*** Running feature tests ***") conn = self.conn.get() diff --git a/src/kimchi/model/featuretests.py b/src/kimchi/model/featuretests.py index 5a45990..6ffdf4a 100644 --- a/src/kimchi/model/featuretests.py +++ b/src/kimchi/model/featuretests.py @@ -25,17 +25,19 @@ import socket import subprocess import threading - from lxml.builder import E - from kimchi.rollbackcontext import RollbackContext from kimchi.utils import kimchi_log, run_command +FEATURETEST_VM_NAME = "FEATURETEST_VM" +FEATURETEST_POOL_NAME = "FEATURETEST_POOL" + + ISO_STREAM_XML = """ <domain type='%(domain)s'> - <name>ISO_STREAMING</name> + <name>%(name)s</name> <memory unit='KiB'>1048576</memory> <os> <type arch='%(arch)s'>hvm</type> @@ -57,7 +59,7 @@ ISO_STREAM_XML = """ SIMPLE_VM_XML = """ <domain type='%(domain)s'> - <name>A_SIMPLE_VM</name> + <name>%(name)s</name> <memory unit='KiB'>10240</memory> <os> <type arch='%(arch)s'>hvm</type> @@ -67,7 +69,7 @@ SIMPLE_VM_XML = """ SCSI_FC_XML = """ <pool type='scsi'> - <name>TEST_SCSI_FC_POOL</name> + <name>%(name)s</name> <source> <adapter type='fc_host' wwnn='1234567890abcdef' wwpn='abcdef1234567890'/> </source> @@ -105,7 +107,8 @@ class FeatureTests(object): domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' arch = 'ppc64' if platform.machine() == 'ppc64le' \ else platform.machine() - xml = ISO_STREAM_XML % {'domain': domain_type, 'protocol': protocol, + xml = ISO_STREAM_XML % {'name': FEATURETEST_VM_NAME, + 'domain': domain_type, 'protocol': protocol, 'arch': arch} try: FeatureTests.disable_libvirt_error_logging() @@ -176,7 +179,8 @@ class FeatureTests(object): try: FeatureTests.disable_libvirt_error_logging() pool = None - pool = conn.storagePoolDefineXML(SCSI_FC_XML, 0) + pool_xml = SCSI_FC_XML % {'name': FEATURETEST_POOL_NAME} + pool = conn.storagePoolDefineXML(pool_xml, 0) except libvirt.libvirtError as e: if e.get_error_code() == 27: # Libvirt requires adapter name, not needed when supports to FC @@ -196,7 +200,8 @@ class FeatureTests(object): domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' arch = 'ppc64' if platform.machine() == 'ppc64le' \ else platform.machine() - dom = conn.defineXML(SIMPLE_VM_XML % {'domain': domain_type, + dom = conn.defineXML(SIMPLE_VM_XML % {'name': FEATURETEST_VM_NAME, + 'domain': domain_type, 'arch': arch}) rollback.prependDefer(dom.undefine) try: -- 2.1.0

3 3

[PATCH] Fix issue #591: Get the right arch for MockModel
by Aline Manera 12 Feb '15

12 Feb '15

Use osinfo information to get the properly arch information when creating a VM for feature tests. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- src/kimchi/model/featuretests.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/kimchi/model/featuretests.py b/src/kimchi/model/featuretests.py index 5a45990..c9a0c78 100644 --- a/src/kimchi/model/featuretests.py +++ b/src/kimchi/model/featuretests.py @@ -20,15 +20,13 @@ import cherrypy import libvirt import lxml.etree as ET -import platform import socket import subprocess import threading - from lxml.builder import E - +from kimchi import osinfo from kimchi.rollbackcontext import RollbackContext from kimchi.utils import kimchi_log, run_command @@ -103,8 +101,8 @@ class FeatureTests(object): @staticmethod def libvirt_supports_iso_stream(conn, protocol): domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' - arch = 'ppc64' if platform.machine() == 'ppc64le' \ - else platform.machine() + arch = osinfo.defaults['arch'] + arch = 'ppc64' if arch == 'ppc64le' else arch xml = ISO_STREAM_XML % {'domain': domain_type, 'protocol': protocol, 'arch': arch} try: @@ -194,8 +192,8 @@ class FeatureTests(object): FeatureTests.disable_libvirt_error_logging() rollback.prependDefer(FeatureTests.enable_libvirt_error_logging) domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' - arch = 'ppc64' if platform.machine() == 'ppc64le' \ - else platform.machine() + arch = osinfo.defaults['arch'] + arch = 'ppc64' if arch == 'ppc64le' else arch dom = conn.defineXML(SIMPLE_VM_XML % {'domain': domain_type, 'arch': arch}) rollback.prependDefer(dom.undefine) -- 2.1.0

2 2

Question about KVM domain not available on trusty
by Thierry Fauck＠linux.vnet.ibm.com 11 Feb '15

11 Feb '15

I forgot, on trusty, qemu-kvm doesn't exist as is, and when I try to create a template I get errors like: libvirt: QEMU Driver error : unsupported configuration: Domain requires KVM, but it is not available. Check that virtualization is enabled in the host BIOS, and host configuration is setup to load the kvm modules. So 2 issues there - in trusty get a proper qemu version to avoid messages error: internal error: process exited while connecting to monitor: Warning: Disabling some instructions which are not emulated by TCG (0x0, 0x4) qemu: hardware error: qemu: could not load LPAR rtas '(null)' - in kimchi, detect if kvm not a valid domain type then use qemu Does that sound an issue ? - do you want me to code that ? Thanks -- Thierry Fauck @ linux.vnet.ibm

3 4

[PATCH V3] UI: Add widget messagebar with sample
by Wen Wang 11 Feb '15

11 Feb '15

V2 -> V3: Rename the sample file and add the license. V1 -> V2: Add a parameter "dismissTime" that allow delay time as well as "never" for the dismiss time. Signed-off-by: Wen Wang <wenwang(a)linux.vnet.ibm.com> --- ui/css/theme-default/messagebar-flat.css | 64 ++++++++++++++++++++++++++++ ui/js/widgets/messagebar-flat.js | 71 ++++++++++++++++++++++++++++++++ ui/js/widgets/samples/messagebar.html | 49 ++++++++++++++++++++++ 3 files changed, 184 insertions(+) create mode 100644 ui/css/theme-default/messagebar-flat.css create mode 100644 ui/js/widgets/messagebar-flat.js create mode 100644 ui/js/widgets/samples/messagebar.html diff --git a/ui/css/theme-default/messagebar-flat.css b/ui/css/theme-default/messagebar-flat.css new file mode 100644 index 0000000..d5efc8e --- /dev/null +++ b/ui/css/theme-default/messagebar-flat.css @@ -0,0 +1,64 @@ +/* + * Project Kimchi + * + * Copyright IBM, Corp. 2015 + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +.messagebar { + height: 30px; +} + +.messagebar .messagebar-text { + text-align: left; + vertical-align: 50%; +} + +.messagebar .messageHead { + display: inline-block; + width: 5px; + height: 30px; +} + +.messagebar-close { + line-height: 30px; + vertical-align: middle; + margin-right: 10px; + cursor: pointer; + float: right; +} + +.green { + background-color: #DAE6CB; +} + +.dark-green { + background-color: #89C53A; +} + +.yellow { + background-color: #F1E3C2; +} + +.dark-yellow { + background-color: #FDB60D; +} + +.red { + background-color: #EAC3C7; +} + +.dark-red { + background-color: #D81227; +} \ No newline at end of file diff --git a/ui/js/widgets/messagebar-flat.js b/ui/js/widgets/messagebar-flat.js new file mode 100644 index 0000000..203d194 --- /dev/null +++ b/ui/js/widgets/messagebar-flat.js @@ -0,0 +1,71 @@ +/* + * Project Kimchi + * + * Copyright IBM, Corp. 2015 + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/* +* Usage: + $(selector).messagebarFlat({ + content: "Test", //message you want to show in the messagebar + color: "red", //Three color supported: "red", "yellow" and "green", + dismissTime: 3000 //when set to "never", the messagebar will never disappear. + // Or setting it to numbers for the dismiss time you want to delay. + }); +*/ + +(function($) { + $.widget("kimchi.messagebarFlat", { + options : { + content : null, + color : "red", + dismissTime: 3000 + }, + + _create: function() { + var now = this._getTime(); + var that = this; + $("<div class='messagebar'><span class='messageHead'></span>" + + "<span class='messagebar-text'> " + this.options.content +": " + now + "</span></div>") + .addClass(this.options.color) + .appendTo(that.element); + $(".messageHead").addClass("dark-" + this.options.color); + $("<span class='messagebar-close icon-cancel-circled'></span>").on("click", function() { + that.destroy(); + }).appendTo($(".messagebar")); + var dismissDelay = this.options.dismissTime; + if (dismissDelay != "never") { + setTimeout(function() { + that.destroy() + }, dismissDelay); + } + }, + + _getTime: function() { + var CT = new Date(); + var currentDate = CT.getDate() + "/" + CT.getMonth()+1 + "/" +CT.getFullYear(); + var currentTime = CT.getHours() + ":" + CT.getMinutes() + ":" + CT.getSeconds(); + var now = currentDate + " " + currentTime; + return now; + }, + + destroy: function() { + var that = this; + that.element.fadeOut("normal", function() { + that.element.remove(); + }); + } + }); +})(jQuery); \ No newline at end of file diff --git a/ui/js/widgets/samples/messagebar.html b/ui/js/widgets/samples/messagebar.html new file mode 100644 index 0000000..b0aa600 --- /dev/null +++ b/ui/js/widgets/samples/messagebar.html @@ -0,0 +1,49 @@ + + +<!DOCTYPE html> +<html> + <head> + <meta charset="UTF-8"> + <title>Sample of messagebar</title> + <meta http-equiv="X-UA-Compatible" content="IE=edge"/> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes" /> + <link rel="stylesheet" href="../../../css/fontello/css/fontello.css"> + <link rel="stylesheet" href="../../../css/fontello/css/animation.css"> + <link rel="stylesheet" href="../../../libs/themes/base/jquery-ui.min.css"> + <link rel="stylesheet" href="../../../css/theme-default/messagebar-flat.css"> + <script src="../../../libs/jquery-1.10.0.min.js"></script> + <script src="../../../libs/jquery-ui.min.js"></script> + <script src="../messagebar-flat.js"></script> + </head> + <body> + <div class="message"></div> + <script> + $(document).ready(function() { + $(".message").messagebarFlat({ + content: "This is a test", + color: "red", + dismissTime: 1000 + }); + }); + </script> + </body> + +</html> -- 2.1.0

3 3

[PATCH] Old version of ppc64_cpu command doesn't support option --threads-per-core
by thierry＠linux.vnet.ibm.com 10 Feb '15

10 Feb '15

From: Thierry FAUCK - IBM LTC <thierry(a)linux.vnet.ibm.com> Old version of ppc64_cpu command doesn't support option --threads-per-core and raises a start message ValueError: invalid literal for int() with base 10: 'information)' Solution is to get info from lscpu which sounds accurate Remove dependency to qemu-kvm Signed-off-by: Thierry FAUCK - IBM LTC <thierry(a)linux.vnet.ibm.com> modified: contrib/DEBIAN/control.in modified: src/kimchi/model/cpuinfo.py --- contrib/DEBIAN/control.in | 1 - src/kimchi/model/cpuinfo.py | 20 +++++++++++++++----- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in index 069e14b..776b033 100644 --- a/contrib/DEBIAN/control.in +++ b/contrib/DEBIAN/control.in @@ -14,7 +14,6 @@ Depends: python-cherrypy3 (>= 3.2.0), libvirt-bin, nfs-common, python-m2crypto, - qemu-kvm, python-pam, python-parted, python-psutil (>= 0.6.0), diff --git a/src/kimchi/model/cpuinfo.py b/src/kimchi/model/cpuinfo.py index 3411ef5..d43f21f 100644 --- a/src/kimchi/model/cpuinfo.py +++ b/src/kimchi/model/cpuinfo.py @@ -80,11 +80,21 @@ class CPUInfoModel(object): out, error, rc = run_command(['ppc64_cpu', '--cores-on']) if not rc: self.cores_available = int(out.split()[-1]) - out, error, rc = run_command(['ppc64_cpu', '--threads-per-core']) - if not rc: - self.threads_per_core = int(out.split()[-1]) - self.sockets = self.cores_present/self.threads_per_core - self.cores_per_socket = self.cores_present/self.sockets + try: + out, error, rc = run_command(['ppc64_cpu', '--threads-per-core']) + if not rc: + self.threads_per_core = int(out.split()[-1]) + self.sockets = self.cores_present/self.threads_per_core + self.cores_per_socket = self.cores_present/self.sockets + except: + out, error, rc = run_command(['sh', '-c', 'lscpu | + grep "Thread(s) per core:"']) + if not rc: + self.cores_present = int(out.split()[-1]) + out, error, rc = run_command(['sh', '-c', 'lscpu | + grep "Core(s) per socket:"']) + if not rc: + self.cores_available = int(out.split()[-1]) else: # Intel or AMD self.guest_threads_enabled = True -- 1.7.9.5

4 4

[PATCH] Eliminate name collision for feature tests' VMs
by Christy Perez 06 Feb '15

06 Feb '15

If Kimchi's startup is interrupted for some reason, a VM created during the feature tests may be left defined. When this happens, the next time Kimchi is started it will fail with an error that the domain already exists (for example, "libvirtError: operation failed: domain 'A_SIMPLE_VM' already exists with uuid e6fccea8-f7ed-4320-a4cb-b85217d23985"). This patch just uses the same uuid-based name scheme as was already in the user tests (kvmusertests.py). That gives a miniscule chance for name collision. Signed-off-by: Christy Perez <christy(a)linux.vnet.ibm.com> --- src/kimchi/model/featuretests.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/kimchi/model/featuretests.py b/src/kimchi/model/featuretests.py index 5a45990..aa8d709 100644 --- a/src/kimchi/model/featuretests.py +++ b/src/kimchi/model/featuretests.py @@ -24,6 +24,7 @@ import socket import subprocess import threading +import uuid from lxml.builder import E @@ -35,7 +36,7 @@ ISO_STREAM_XML = """ <domain type='%(domain)s'> - <name>ISO_STREAMING</name> + <name>'%(name)s'</name> <memory unit='KiB'>1048576</memory> <os> <type arch='%(arch)s'>hvm</type> @@ -57,7 +58,7 @@ SIMPLE_VM_XML = """ <domain type='%(domain)s'> - <name>A_SIMPLE_VM</name> + <name>'%(name)s'</name> <memory unit='KiB'>10240</memory> <os> <type arch='%(arch)s'>hvm</type> @@ -105,8 +106,10 @@ def libvirt_supports_iso_stream(conn, protocol): domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' arch = 'ppc64' if platform.machine() == 'ppc64le' \ else platform.machine() + vm_uuid = uuid.uuid1() + vm_name = "ISO_STREAM_%s" % vm_uuid xml = ISO_STREAM_XML % {'domain': domain_type, 'protocol': protocol, - 'arch': arch} + 'arch': arch, 'name': vm_name} try: FeatureTests.disable_libvirt_error_logging() dom = conn.defineXML(xml) @@ -196,8 +199,11 @@ def has_metadata_support(conn): domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' arch = 'ppc64' if platform.machine() == 'ppc64le' \ else platform.machine() + vm_uuid = uuid.uuid1() + vm_name = "A_SIMPLE_VM_%s" % vm_uuid dom = conn.defineXML(SIMPLE_VM_XML % {'domain': domain_type, - 'arch': arch}) + 'arch': arch, + 'name': vm_name}) rollback.prependDefer(dom.undefine) try: dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, -- 1.9.3

2 5

Doubt Bug 121401 - LTCTest: Build36: Takes time to list "Device path" for logical pool creation
by Ramon Medeiros 06 Feb '15

06 Feb '15

Hi Team, i was debugging this bug and found that this query is taking so much time: pvs = subprocess.Popen( ["pvs", "--unbuffered", "--nameprefixes", "--noheadings", "-o", "vg_name", devNodePath], devNodePath is a partition or a disk (e.g. /dev/sdc or /dev/mpathe1) The goal in this command is search the volume group that this partition belongs to. On machines that has inconsistent volume groups, it takes a long time to retrieve the information. Can i cache this information before querying all partitions? Or there is other way to query this info faster? -- Ramon Nunes Medeiros Kimchi Developer Software Engineer - Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn(a)br.ibm.com

2 2

[PATCH] Issue #569: Deactive logical pool cause vm failed to start
by gouzongmei＠163.com 06 Feb '15

06 Feb '15

From: Zongmei Gou <gouzongmei(a)163.com> Deactive logical pool cause vm failed to start while storage of the vm is in this logical pool. Storage pool's "deactive" action call libvirt "StoragePoolDestroy" function which causes different result on different pool type.Once the pool is destroyed, the 'dir' type pool remains its target path and images while the 'logical' type pool deletes its target path and images. This patch make deactive logical pool action failed while exists vm(s) linked to this pool. --- src/kimchi/i18n.py | 1 + src/kimchi/model/storagepools.py | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/src/kimchi/i18n.py b/src/kimchi/i18n.py index 4ab08d1..08bfe38 100644 --- a/src/kimchi/i18n.py +++ b/src/kimchi/i18n.py @@ -188,6 +188,7 @@ messages = { "KCHPOOL0035E": _("Unable to delete pool %(name)s as it is associated with some templates"), "KCHPOOL0036E": _("A volume group named '%(name)s' already exists. Please, choose another name to create the logical pool."), "KCHPOOL0037E": _("Unable to update database with deep scan information due error: %(err)s"), + "KCHPOOL0038E": _("Unable to deactivate pool %(name)s. There are some virtual machines %(vms)s linked to this pool."), "KCHVOL0001E": _("Storage volume %(name)s already exists"), "KCHVOL0002E": _("Storage volume %(name)s does not exist in storage pool %(pool)s"), diff --git a/src/kimchi/model/storagepools.py b/src/kimchi/model/storagepools.py index b85f3b4..c42b62e 100644 --- a/src/kimchi/model/storagepools.py +++ b/src/kimchi/model/storagepools.py @@ -18,6 +18,7 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA import libvirt +import os from kimchi.scan import Scanner from kimchi.exception import InvalidOperation, MissingParameter @@ -27,6 +28,8 @@ from kimchi.model.host import DeviceModel from kimchi.model.libvirtstoragepool import StoragePoolDef from kimchi.utils import add_task, kimchi_log, pool_name_from_uri, run_command from kimchi.xmlutils.utils import xpath_get_text +from kimchi.model.vms import VMModel, VMsModel +from kimchi.xmlutils.disk import get_vm_disk_info, get_vm_disks ISO_POOL_NAME = u'kimchi_isos' @@ -230,6 +233,24 @@ class StoragePoolModel(object): source[key] = res return source + def _get_vms_attach_to_a_storagepool(self, pool_name): + # find out vm(s) the vol(s) of this pool attached to. + pool = self.get_storagepool(pool_name, self.conn) + xml = pool.XMLDesc(0) + + vms = [] + pool_path = xpath_get_text(xml, "/pool/target/path")[0] + vms_list = VMsModel.get_vms(self.conn) + for vm in vms_list: + dom = VMModel.get_vm(vm, self.conn) + storages = get_vm_disks(dom) + for disk in storages.keys(): + d_info = get_vm_disk_info(dom, disk) + if pool_path == os.path.split(d_info['path'])[0]: + vms.append(vm) + break + return sorted(vms) + def _nfs_status_online(self, pool, poolArgs=None): if not poolArgs: xml = pool.XMLDesc(0) @@ -378,6 +399,13 @@ class StoragePoolModel(object): raise OperationFailed("KCHPOOL0033E", {'name': name, 'server': source['addr']}) return + elif (pool_type == 'logical' and + self._get_storagepool_vols_num(pool) > 0): + # can not deactive if vol(s) exists, because destroy + # logical pool will cause the vol deleted. + vms = self._get_vms_attach_to_a_storagepool(name) + raise InvalidOperation('KCHPOOL0038E', {'name': name, + 'vms': ', '.join(vms)}) try: persistent = pool.isPersistent() pool.destroy() -- 1.8.3.1

2 1

[PATCH v2] Kimchi: Old version of ppc64_cpu command doesn't support option --threads-per-core V2 Correct missing \ in kimchi/model/cpuinfo.py V1 Old version of ppc64_cpu command doesn't support option --threads-per-core and raises a start message ValueError: invalid literal for int() with base 10: 'information)' Solution is to get info from lscpu which sounds accurate
by thierry＠linux.vnet.ibm.com 06 Feb '15

06 Feb '15

From: Thierry FAUCK - IBM LTC <thierry(a)linux.vnet.ibm.com> Remove dependency to qemu-kvm Signed-off-by: Thierry FAUCK - IBM LTC <thierry(a)linux.vnet.ibm.com> modified: contrib/DEBIAN/control.in modified: src/kimchi/model/cpuinfo.py --- contrib/DEBIAN/control.in | 1 - src/kimchi/model/cpuinfo.py | 20 +++++++++++++++----- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in index 069e14b..776b033 100644 --- a/contrib/DEBIAN/control.in +++ b/contrib/DEBIAN/control.in @@ -14,7 +14,6 @@ Depends: python-cherrypy3 (>= 3.2.0), libvirt-bin, nfs-common, python-m2crypto, - qemu-kvm, python-pam, python-parted, python-psutil (>= 0.6.0), diff --git a/src/kimchi/model/cpuinfo.py b/src/kimchi/model/cpuinfo.py index 3411ef5..d43f21f 100644 --- a/src/kimchi/model/cpuinfo.py +++ b/src/kimchi/model/cpuinfo.py @@ -80,11 +80,21 @@ class CPUInfoModel(object): out, error, rc = run_command(['ppc64_cpu', '--cores-on']) if not rc: self.cores_available = int(out.split()[-1]) - out, error, rc = run_command(['ppc64_cpu', '--threads-per-core']) - if not rc: - self.threads_per_core = int(out.split()[-1]) - self.sockets = self.cores_present/self.threads_per_core - self.cores_per_socket = self.cores_present/self.sockets + try: + out, error, rc = run_command(['ppc64_cpu', '--threads-per-core']) + if not rc: + self.threads_per_core = int(out.split()[-1]) + self.sockets = self.cores_present/self.threads_per_core + self.cores_per_socket = self.cores_present/self.sockets + except: + out, error, rc = run_command(['sh', '-c', 'lscpu | + grep "Thread(s) per core:"']) + if not rc: + self.cores_present = int(out.split()[-1]) + out, error, rc = run_command(['sh', '-c', 'lscpu | + grep "Core(s) per socket:"']) + if not rc: + self.cores_available = int(out.split()[-1]) else: # Intel or AMD self.guest_threads_enabled = True -- 1.7.9.5

1 0

[PATCH] Make VMs for tests auto-destroy'd and transient
by Christy Perez 06 Feb '15

06 Feb '15

If Kimchi's startup is interrupted for some reason, a VM created during the feature tests may be left defined. When this happens, the next time Kimchi is started it will fail with an error that the domain already exists (for example, "libvirtError: operation failed: domain 'A_SIMPLE_VM' already exists with uuid e6fccea8-f7ed-4320-a4cb-b85217d23985"). About the new flag: "If the VIR_DOMAIN_START_AUTODESTROY flag is set, the guest domain will be automatically destroyed when the virConnectPtr object is finally released. This will also happen if the client application crashes / loses its connection to the libvirtd daemon. Any domains marked for auto destroy will block attempts at migration, save-to-file, or snapshots." This patch also changes the memory in the test VMs, due to the fact that the domain will be started, and some platforms (Power is a known example) require at least 128M of memory for a guest. Signed-off-by: Christy Perez <christy(a)linux.vnet.ibm.com> --- src/kimchi/kvmusertests.py | 5 ++--- src/kimchi/model/featuretests.py | 14 ++++++++------ 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/kimchi/kvmusertests.py b/src/kimchi/kvmusertests.py index 408706d..3abf148 100644 --- a/src/kimchi/kvmusertests.py +++ b/src/kimchi/kvmusertests.py @@ -54,9 +54,8 @@ def probe_user(cls): with RollbackContext() as rollback: conn = libvirt.open(None) rollback.prependDefer(conn.close) - dom = conn.defineXML(xml) - rollback.prependDefer(dom.undefine) - dom.create() + dom = conn.createXML(xml, + flags=libvirt.VIR_DOMAIN_START_AUTODESTROY) rollback.prependDefer(dom.destroy) with open('/var/run/libvirt/qemu/%s.pid' % vm_name) as f: pidStr = f.read() diff --git a/src/kimchi/model/featuretests.py b/src/kimchi/model/featuretests.py index 5a45990..ef7dcc5 100644 --- a/src/kimchi/model/featuretests.py +++ b/src/kimchi/model/featuretests.py @@ -58,7 +58,7 @@ SIMPLE_VM_XML = """ <domain type='%(domain)s'> <name>A_SIMPLE_VM</name> - <memory unit='KiB'>10240</memory> + <memory unit='KiB'>131072</memory> <os> <type arch='%(arch)s'>hvm</type> <boot dev='hd'/> @@ -109,8 +109,9 @@ def libvirt_supports_iso_stream(conn, protocol): 'arch': arch} try: FeatureTests.disable_libvirt_error_logging() - dom = conn.defineXML(xml) - dom.undefine() + dom = conn.createXML(xml, + flags=libvirt.VIR_DOMAIN_START_AUTODESTROY) + dom.destroy() return True except libvirt.libvirtError, e: kimchi_log.error(e.message) @@ -196,9 +197,10 @@ def has_metadata_support(conn): domain_type = 'test' if conn.getType().lower() == 'test' else 'kvm' arch = 'ppc64' if platform.machine() == 'ppc64le' \ else platform.machine() - dom = conn.defineXML(SIMPLE_VM_XML % {'domain': domain_type, - 'arch': arch}) - rollback.prependDefer(dom.undefine) + dom = conn.createXML(SIMPLE_VM_XML % {'domain': domain_type, + 'arch': arch}, + flags=libvirt.VIR_DOMAIN_START_AUTODESTROY) + rollback.prependDefer(dom.destroy) try: dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, "<metatest/>", KIMCHI_NAMESPACE, -- 1.9.3

2 2

[PATCH] Bugfix: Kimchi: Better to list storage pool paths
by Wen Wang 05 Feb '15

05 Feb '15

Fix the defect that kimchi could not show the storage path properly when it's too long. Signed-off-by: Wen Wang <wenwang(a)linux.vnet.ibm.com> --- ui/css/theme-default/storage.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/css/theme-default/storage.css b/ui/css/theme-default/storage.css index e0ab290..b6df3c2 100644 --- a/ui/css/theme-default/storage.css +++ b/ui/css/theme-default/storage.css @@ -50,7 +50,7 @@ .storage-text { font-size: 12px; - height: 18px; + min-height: 18px; padding: 10px; color: #999999; font-weight: bold; -- 2.1.0

3 3

[PATCH V2] UI: Add widget messagebar with sample
by Wen Wang 05 Feb '15

05 Feb '15

V1 -> V2: Add a parameter "dismissTime" that allow delay time as well as "never" for the dismiss time. Signed-off-by: Wen Wang <wenwang(a)linux.vnet.ibm.com> --- ui/css/theme-default/messagebar-flat.css | 64 ++++++++++++++++++++ ui/js/widgets/messagebar-flat.js | 71 +++++++++++++++++++++++ ui/js/widgets/samples/messagebar-flat-sample.html | 34 +++++++++++ 3 files changed, 169 insertions(+) create mode 100644 ui/css/theme-default/messagebar-flat.css create mode 100644 ui/js/widgets/messagebar-flat.js create mode 100644 ui/js/widgets/samples/messagebar-flat-sample.html diff --git a/ui/css/theme-default/messagebar-flat.css b/ui/css/theme-default/messagebar-flat.css new file mode 100644 index 0000000..d5efc8e --- /dev/null +++ b/ui/css/theme-default/messagebar-flat.css @@ -0,0 +1,64 @@ +/* + * Project Kimchi + * + * Copyright IBM, Corp. 2015 + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +.messagebar { + height: 30px; +} + +.messagebar .messagebar-text { + text-align: left; + vertical-align: 50%; +} + +.messagebar .messageHead { + display: inline-block; + width: 5px; + height: 30px; +} + +.messagebar-close { + line-height: 30px; + vertical-align: middle; + margin-right: 10px; + cursor: pointer; + float: right; +} + +.green { + background-color: #DAE6CB; +} + +.dark-green { + background-color: #89C53A; +} + +.yellow { + background-color: #F1E3C2; +} + +.dark-yellow { + background-color: #FDB60D; +} + +.red { + background-color: #EAC3C7; +} + +.dark-red { + background-color: #D81227; +} \ No newline at end of file diff --git a/ui/js/widgets/messagebar-flat.js b/ui/js/widgets/messagebar-flat.js new file mode 100644 index 0000000..203d194 --- /dev/null +++ b/ui/js/widgets/messagebar-flat.js @@ -0,0 +1,71 @@ +/* + * Project Kimchi + * + * Copyright IBM, Corp. 2015 + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/* +* Usage: + $(selector).messagebarFlat({ + content: "Test", //message you want to show in the messagebar + color: "red", //Three color supported: "red", "yellow" and "green", + dismissTime: 3000 //when set to "never", the messagebar will never disappear. + // Or setting it to numbers for the dismiss time you want to delay. + }); +*/ + +(function($) { + $.widget("kimchi.messagebarFlat", { + options : { + content : null, + color : "red", + dismissTime: 3000 + }, + + _create: function() { + var now = this._getTime(); + var that = this; + $("<div class='messagebar'><span class='messageHead'></span>" + + "<span class='messagebar-text'> " + this.options.content +": " + now + "</span></div>") + .addClass(this.options.color) + .appendTo(that.element); + $(".messageHead").addClass("dark-" + this.options.color); + $("<span class='messagebar-close icon-cancel-circled'></span>").on("click", function() { + that.destroy(); + }).appendTo($(".messagebar")); + var dismissDelay = this.options.dismissTime; + if (dismissDelay != "never") { + setTimeout(function() { + that.destroy() + }, dismissDelay); + } + }, + + _getTime: function() { + var CT = new Date(); + var currentDate = CT.getDate() + "/" + CT.getMonth()+1 + "/" +CT.getFullYear(); + var currentTime = CT.getHours() + ":" + CT.getMinutes() + ":" + CT.getSeconds(); + var now = currentDate + " " + currentTime; + return now; + }, + + destroy: function() { + var that = this; + that.element.fadeOut("normal", function() { + that.element.remove(); + }); + } + }); +})(jQuery); \ No newline at end of file diff --git a/ui/js/widgets/samples/messagebar-flat-sample.html b/ui/js/widgets/samples/messagebar-flat-sample.html new file mode 100644 index 0000000..5ab4c73 --- /dev/null +++ b/ui/js/widgets/samples/messagebar-flat-sample.html @@ -0,0 +1,34 @@ + + + +<!DOCTYPE html> +<html> + <head> + <meta charset="UTF-8"> + <title>Sample of messagebar</title> + <meta http-equiv="X-UA-Compatible" content="IE=edge"/> + <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes" /> + <link rel="stylesheet" href="../../../css/fontello/css/fontello.css"> + <link rel="stylesheet" href="../../../css/fontello/css/animation.css"> + <link rel="stylesheet" href="../../../libs/themes/base/jquery-ui.min.css"> + <link rel="stylesheet" href="../../../css/theme-default/messagebar-flat.css"> + <script src="../../../libs/jquery-1.10.0.min.js"></script> + <script src="../../../libs/jquery-ui.min.js"></script> + <script src="../messagebar-flat.js"></script> + </head> + <body> + <div class="message"></div> + <script> + $(document).ready(function() { + $(".message").messagebarFlat({ + content: "This is a test", + color: "red", + dismissTime: 1000 + }); + }); + </script> + </body> + +</html> -- 2.1.0

2 5

[v3 0/2] UI: Tabs Widget(With Sample)
by huoyuxin＠linux.vnet.ibm.com 05 Feb '15

05 Feb '15

From: Yu Xin Huo <huoyuxin(a)linux.vnet.ibm.com> Yu Xin Huo (2): UI: Customize jQuery UI Tabs Widget UI: Tabs Widget Sample ui/css/theme-default/tabs.css | 46 ++++++++++++++++++++++++++ ui/css/theme-default/theme.css | 50 ++++++++++++++++++++++++++++ ui/js/widgets/samples/tabs.html | 68 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 164 insertions(+), 0 deletions(-) create mode 100644 ui/css/theme-default/tabs.css create mode 100644 ui/css/theme-default/theme.css create mode 100644 ui/js/widgets/samples/tabs.html

2 3

[PATCH 0/2] Dialog widget with sample
by Wen Wang 05 Feb '15

05 Feb '15

Dialog widget with sample Wen Wang (2): UI; Add widget of dialog UI: Sample of dialog widget ui/css/theme-default/dialog-flat.css | 67 +++++++++++++++++++ ui/js/widgets/dialog-flat.js | 120 +++++++++++++++++++++++++++++++++++ ui/js/widgets/samples/dialog.html | 51 +++++++++++++++ 3 files changed, 238 insertions(+) create mode 100644 ui/css/theme-default/dialog-flat.css create mode 100644 ui/js/widgets/dialog-flat.js create mode 100644 ui/js/widgets/samples/dialog.html -- 2.1.0

2 3