- Kimchi-devel - oVirt List Archives

[PATCH] [Wok] Adds DataTables.net plugin and Moment.js to Wok
by sguimaraes943＠gmail.com 27 Jun '16

27 Jun '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> Some files are minified. Let me know if they were corrupted by git send-email --no-validate This commit adds DataTables.net jQuery plugin and Moment.js library to Wok. DataTables.net is a table plugin that supports pagination, instance search and multi-column ordering. It also has a responsive module and it is compatible with many different CSS libraries. In this commit it is included a customization for its Bootstrap integration and a default initialization script pre-loaded with Wok styles. Moment.js is a lightweight JavaScript date library for parsing, validating, manipulating, and formatting dates. It is required in order to filter and sort dates properly in Wok User Logs and Ginger Configuration Backup. Samuel Guimarães (1): Adding DataTables.net plugin and Moment.js to Wok configure.ac | 3 + ui/css/Makefile.am | 8 +- ui/css/datatables.bootstrap.css | 243 +++++++++++++++++++++++++++++ ui/css/src/datatables.bootstrap.scss | 289 +++++++++++++++++++++++++++++++++++ ui/js/src/wok.datatables.js | 26 ++++ ui/libs/Makefile.am | 2 +- ui/libs/datatables/Makefile.am | 23 +++ ui/libs/datatables/css/Makefile.am | 21 +++ ui/libs/moment/LICENSE | 22 +++ ui/libs/moment/Makefile.am | 21 +++ ui/pages/login.html.tmpl | 5 + ui/pages/wok-ui.html.tmpl | 5 + 12 files changed, 665 insertions(+), 3 deletions(-) create mode 100644 ui/css/datatables.bootstrap.css create mode 100644 ui/css/src/datatables.bootstrap.scss create mode 100644 ui/js/src/wok.datatables.js create mode 100644 ui/libs/datatables/Makefile.am create mode 100644 ui/libs/datatables/css/Makefile.am create mode 100644 ui/libs/moment/LICENSE create mode 100644 ui/libs/moment/Makefile.am -- 1.9.3

3 3

[PATCH v2] [Wok] Issue #79: All error messages should keep on UI until user dismiss it
by sguimaraes943＠gmail.com 27 Jun '16

27 Jun '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This commit makes all messages closeable by default, removing the fade animation after 10 seconds. A parameter to allow a custom ID for each alert was also added to wok.message function. v2: - Fixed an issue where some alerts were not dismissible; - This commit also fixes a bug where alert "close" buttons would close modal windows. Samuel Guimarães (1): Issue #79: All error messages should keep on UI until user dismiss it ui/js/src/wok.message.js | 69 +++++++++++++++++++++++++----------------------- ui/js/src/wok.window.js | 2 +- 2 files changed, 37 insertions(+), 34 deletions(-) -- 1.8.3.1

3 3

[PATCH] [Kimchi] Do not break the logging of failed requests
by Lucio Correia 27 Jun '16

27 Jun '16

Now that failed requests are also logged, this fix is necessary to avoid breaking the logging itself due to lack of parameters. Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- control/storagevolumes.py | 1 + control/vm/ifaces.py | 1 + control/vms.py | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/control/storagevolumes.py b/control/storagevolumes.py index c3f1c29..c121b5e 100644 --- a/control/storagevolumes.py +++ b/control/storagevolumes.py @@ -46,6 +46,7 @@ class StorageVolumes(AsyncCollection): self.model_args = [self.pool, ] self.log_map = STORAGEVOLUMES_REQUESTS self.log_args.update({ + 'name': '', 'pool': self.pool.encode('utf-8') if self.pool else '', }) diff --git a/control/vm/ifaces.py b/control/vm/ifaces.py index 0cea8b5..7e133a6 100644 --- a/control/vm/ifaces.py +++ b/control/vm/ifaces.py @@ -47,6 +47,7 @@ class VMIfaces(Collection): self.model_args = [self.vm, ] self.log_map = VMIFACES_REQUESTS self.log_args.update({ + 'network': '', 'vm': self.vm.encode('utf-8') if self.vm else '', }) diff --git a/control/vms.py b/control/vms.py index 2339017..b351c72 100644 --- a/control/vms.py +++ b/control/vms.py @@ -55,7 +55,7 @@ class VMs(AsyncCollection): self.role_key = 'guests' self.admin_methods = ['POST'] self.log_map = VMS_REQUESTS - self.log_args.update({'name': ''}) + self.log_args.update({'name': '', 'template': ''}) class VM(Resource): -- 1.9.1

2 1

[PATCH V2] [Wok 0/6] Log failed user requests
by Lucio Correia 27 Jun '16

27 Jun '16

Important: * This patchset depends on [PATCH V2] [Wok 0/3] User Request Log improvements. * This patch requires "[Kimchi] Do not break the logging of failed requests". Otherwise, some tests will be broken. Changes in V2: * Applied review suggestions Lucio Correia (6): Revert "Use past verbs" Parse request before authorization check Use status code 200 for PUT requests on resource Log failed login/logout attempts Log failed user requests Add status code to request log message docs/API/logs.md | 1 + src/wok/control/base.py | 130 ++++++++++++++++++++++-------------------------- src/wok/exception.py | 28 ++++++++--- src/wok/i18n.py | 4 +- src/wok/reqlogger.py | 10 ++-- src/wok/root.py | 44 +++++++++++----- tests/test_api.py | 2 +- 7 files changed, 122 insertions(+), 97 deletions(-) -- 1.9.1

2 12

[Wok] [Accessibility] Free web accessibility course on udacity
by Samuel Henrique De Oliveira Guimaraes 24 Jun '16

24 Jun '16

Hi team, I just saw this link on my front-end development reading list and I think we can learn a lot from it in order to improve Wok/Kimchi/Ginger/Gingerbase user experience. Check this out: https://www.udacity.com/course/web-accessibility--ud891 It is a free course on udacity from Google and based on the program lessons I believe it covers most of the problems that were detected and posted on Github. I think this should come in handy to anyone that is performing accessibility tests or developing new pages for the UI. Regards, Samuel

1 0

Kimchi 2.2 is released!
by Aline Manera 24 Jun '16

24 Jun '16

On behalf of everyone who has worked hard on this release, I am pleased to announce the availability of *Kimchi 2.2*! Kimchi 2.2 depends on *Wok 2.2*! So make sure to have both of them properly installed in your system. Find more information about Wok 2.2 at http://kimchi-project.github.io/wok/downloads/ Among many features, this release includes: ✔ Multiple interfaces support for VEPA network ✔ Create Template without specifying media type ✔ Edit virtual network support ✔ Disable Templates with invalid data ✔ Memory hotplug support for non-NUMA PPC guests ✔ Passthrough macvtap network support ✔ Multi-function PCI hotplug support ✔ Storage volume management support ✔ Bug fixes We have worked hard to ensure that Kimchi runs well on the most popular Linux distributions including: Fedora 23, Ubuntu 16.04, openSUSE LEAP 42.1, and RHEL 7.2. Kimchi uses standard Linux interfaces so it should run well on many other distributions too. You can easily grab this release in tarball format or via git: ✔ https://github.com/kimchi-project/kimchi/archive/2.2.0.tar.gz ✔ git clone --recursivehttps://github.com/kimchi-project/wok.git <recursivehttps://github.com/kimchi-project/wok.git> There are also some packages available for download at: ✔ http://kimchi-project.github.io/kimchi/downloads/ Go ahead! Give it a try and let us know what you think! Regards, Aline Manera

1 0

Wok 2.2 is released!
by Aline Manera 24 Jun '16

24 Jun '16

On behalf of everyone who has worked hard on this release, I am pleased to announce the availability of *Wok 2.2*! Among many features, Wok 2.2 includes: ✔ Asynchronous notification support ✔ Make session timeout configurable ✔ Locale support ✔ Remove TLS v1.0 support ✔ Bug fixes We have worked hard to ensure that Wok runs well on the most popular Linux distributions including: Fedora 23, Ubuntu 16.04, openSUSE LEAP 42.1, and RHEL 7.2. Wok uses standard Linux interfaces so it should run well on many other distributions too. You can easily grab this release in tarball format or via git: ✔ https://github.com/kimchi-project/wok/archive/2.2.0.tar.gz ✔ git clone --recursivehttps://github.com/kimchi-project/wok.git <recursivehttps://github.com/kimchi-project/wok.git> There are also some packages available at: ✔http://kimchi-project.github.io/wok/downloads/ Go ahead! Give it a try and let us know what you think! Regards, Aline Manera

1 0

Re: [Kimchi-devel] [RFC] Replace jQuery Bootgrid with Datatables.net
by Samuel Henrique De Oliveira Guimaraes 23 Jun '16

23 Jun '16

FYI, This is what the Datatables.net would look like with Wok Styles: http://jsfiddle.net/sguimaraes/rrjpcdgv/ Notice that the sort arrows are using FontAwesome icons. Regards, Samuel From: Samuel Henrique De Oliveira Guimaraes Sent: terça-feira, 21 de junho de 2016 18:13 To: Kimchi Devel <kimchi-devel(a)ovirt.org> Subject: [RFC] Replace jQuery Bootgrid with Datatables.net Hi team, As part of the redesign process of some Ginger and Gingerbase panels, one of the main issues is that the jQuery Bootgrid tables are not exactly fitting with the Design Spec. If you compare System Modules and System Services tables with Kimchi they look and feel like part of the same application but if you navigate through Ginger Network and Storage tabs, there are some alignment and spacing issues. Most of these UI glitches could be fixed with plain CSS and / or editing jQuery Bootgrid "formatters" but we already faced some issues with the Software Updates and Network Configuration that required some workarounds that were not documented by jQuery Bootgrid authors. Based on that, I suggested to Aline and Daniel if we could redesign these panels using Datatables.net instead of just shaping Bootgrid with CSS changes that may require rework once or if we update Bootgrid library due security or any other reason. I've mentioned before that we would probably have to update to this library if we decided to use Bootstrap 4 in the future but it seems that we may need to change the library and rewrite some panels a little bit earlier. For the UI development it makes sense to use this library instead of adding "native" sort, filters and paging to wok.datagrid component because it has a larger community, a support board and tons of documented examples. Plus, it already has accessibility improvements that we would have to manually implement to our panels. In the future we could even drop wok.datagrid entirely and port everything that doesn't have a Gallery / List view design pattern to Datatables.net. Here's the plan: 1- jQuery Bootgrid and Datatables.net will coexist within Wok and we will update Ginger panel by panel until there isn't a trace of jQuery Bootgrid. 2- Update Software Updates to Datatables.net 3- Update User Logs to Datatables.net 4- Remove jQuery Bootgrid from Wok 5- Update Kimchi Storage to Datatables.net (at least the main table can be replaced, the Storage Volumes view would have to keep the old wok.datagrid because of the Gallery/List switch) 6- Update Kimchi Network to Datatables.net 7- Rename or rewrite wok.datagrid to something else like wok.gallery-view for Kimchi Guests, Templates and Storage Volumes About Datatables.net: 1- License: https://datatables.net/faqs/index#Licensing<https://datatables.net/faqs/index%23Licensing> 2- Support: Although the license is MIT, they offer a paid and the community support - https://datatables.net/support/index 3- API Examples: https://datatables.net/examples/index 4- Manual: https://datatables.net/manual/index 5- Styling (spoiler alert: they support almost every CSS library): https://datatables.net/examples/styling/bootstrap.html Let me know your opinions. Regards, Samuel

1 0

[PATCH] [Kimchi] Handle URLError exception when creating Template.
by pvital＠linux.vnet.ibm.com 23 Jun '16

23 Jun '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> urllib2 raised URLError when could not access a remote file due to unauthorized access, for example. This patch gives to VMTemplate the ability of handle this exception and raises a relevant error message to user. This patch fixes Issue #959 Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- i18n.py | 1 + vmtemplate.py | 3 +++ 2 files changed, 4 insertions(+) diff --git a/i18n.py b/i18n.py index 2d8390f..b33c6ec 100644 --- a/i18n.py +++ b/i18n.py @@ -52,6 +52,7 @@ messages = { "to file access control lists for '%(user)s' user if possible, or add the " "'%(user)s' to the ISO path group, or (not recommended) 'chmod -R o+x 'path_to_iso'." "Details: %(err)s" ), + "KCHISO0009E": _("Unable to access remote ISO. Details: %(err)s"), "KCHIMG0001E": _("An error occurred when probing image OS information."), "KCHIMG0003E": _("Unable to read image file %(filename)s"), diff --git a/vmtemplate.py b/vmtemplate.py index ef92914..6faf4c5 100644 --- a/vmtemplate.py +++ b/vmtemplate.py @@ -24,6 +24,7 @@ import urlparse import uuid from lxml import etree from lxml.builder import E +from urllib2 import URLError from wok.exception import InvalidParameter, ImageFormatError, IsoFormatError from wok.exception import MissingParameter, OperationFailed @@ -172,6 +173,8 @@ class VMTemplate(object): return iso_img.probe() except IsoFormatError: raise InvalidParameter("KCHISO0001E", {'filename': iso}) + except URLError as e: + raise OperationFailed("KCHISO0009E", {'err': e}) def _get_cdrom_xml(self, libvirt_stream_protocols): if 'cdrom' not in self.info: -- 2.5.5

4 6

[PATCH] [Kimchi] Fixing Opensuse Leap package name
by dhbarboza82＠gmail.com 23 Jun '16

23 Jun '16

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> In Opensuse Leap 42.1, 'python-pillow' is named 'python-Pillow'. This subtle change was enough to break Kimchi RPM install in that system. Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> --- contrib/kimchi.spec.suse.in | 2 +- docs/opensuse-deps.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in index c12bcab..3d0896b 100644 --- a/contrib/kimchi.spec.suse.in +++ b/contrib/kimchi.spec.suse.in @@ -17,7 +17,7 @@ Requires: libvirt-daemon-config-network Requires: python-websockify Requires: python-configobj Requires: novnc -Requires: python-pillow +Requires: python-Pillow Requires: python-parted Requires: python-psutil >= 0.6.0 Requires: python-jsonschema >= 1.3.0 diff --git a/docs/opensuse-deps.md b/docs/opensuse-deps.md index a8763b3..a69dacd 100644 --- a/docs/opensuse-deps.md +++ b/docs/opensuse-deps.md @@ -34,7 +34,7 @@ Runtime Dependencies nfs-client open-iscsi python-parted \ python-libguestfs python-configobj guestfs-tools \ python-websockify novnc python-magic \ - python-paramiko python-pillow + python-paramiko python-Pillow Packages required for UI development ------------------------------------ -- 2.5.5

2 1