Re: [Kimchi-devel] [PATCH 2/2] MockModel refactor: Create MockModel based on Model("test:///default")

On 14-11-2014 13:51, Aline Manera wrote:

+ for res, items in params.iteritems(): + resources = getattr(self, '%s_get_list' % res)() + for i in resources: + if i in items: + continue

What's the purpose of the loops above? AFAIU, the inner loop is useless.

+ def _probe_image(self, path): + return ('unkown', 'unkown')

Shouldn't it be "unknown"? Also, "make check-local" reported one i18n issue.