December 2013 - Kimchi-devel - oVirt List Archives

[V2] spec: Open 8000 and 8001 port by default
by taget＠linux.vnet.ibm.com 24 Dec '13

24 Dec '13

From: Eli Qiao <taget(a)linux.vnet.ibm.com> V2 - V1 changes: 1.Add firewalld sevice configure file kimchid.xml to help open iptables port (Mark) 2.Add Ubuntu iptables rule (Royce) Signed-off-by: Eli Qiao <taget(a)linux.vnet.ibm.com> --- contrib/DEBIAN/control.in | 3 ++- contrib/DEBIAN/postinst | 2 ++ contrib/DEBIAN/postrm | 2 ++ contrib/kimchi.spec.fedora.in | 19 +++++++++++++++++++ contrib/kimchi.spec.suse.in | 10 ++++++++-- contrib/kimchid.service.fedora | 1 + src/Makefile.am | 1 + src/kimchid.xml | 7 +++++++ 8 files changed, 42 insertions(+), 3 deletions(-) create mode 100644 src/kimchid.xml diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in index 380584c..c0ea1f1 100644 --- a/contrib/DEBIAN/control.in +++ b/contrib/DEBIAN/control.in @@ -17,7 +17,8 @@ Depends: python-cherrypy3 (>= 3.2.0), python-psutil (>= 0.6.0), python-ethtool, sosreport, - python-ipaddr + python-ipaddr, + firewalld Build-Depends: Maintainer: Aline Manera <alinefm(a)br.ibm.com> Description: Kimchi web server diff --git a/contrib/DEBIAN/postinst b/contrib/DEBIAN/postinst index c1fc22e..b27205c 100755 --- a/contrib/DEBIAN/postinst +++ b/contrib/DEBIAN/postinst @@ -19,3 +19,5 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA service kimchid start +/usr/bin/firewall-cmd --reload +/usr/bin/firewall-cmd --add-service kimchid diff --git a/contrib/DEBIAN/postrm b/contrib/DEBIAN/postrm index ef90b49..3c70584 100755 --- a/contrib/DEBIAN/postrm +++ b/contrib/DEBIAN/postrm @@ -26,3 +26,5 @@ case "$1" in rm -rf /var/log/kimchi /var/run/kimchi.pid /usr/share/kimchi/ ;; esac + +/usr/bin/firewall-cmd --remove-service kimchid diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in index 14ec359..3a3ca4c 100644 --- a/contrib/kimchi.spec.fedora.in +++ b/contrib/kimchi.spec.fedora.in @@ -34,6 +34,7 @@ BuildRequires: python-unittest2 %if 0%{?with_systemd} Requires: systemd +Requires: firewalld Requires(post): systemd Requires(preun): systemd Requires(postun): systemd @@ -63,6 +64,7 @@ make DESTDIR=%{buildroot} install %if 0%{?with_systemd} # Install the systemd scripts install -Dm 0644 contrib/kimchid.service.fedora %{buildroot}%{_unitdir}/kimchid.service +install -Dm 0640 src/kimchid.xml %{buildroot}%{_prefix}/lib/firewalld/services/kimchid.xml %endif %if 0%{?rhel} == 6 @@ -83,16 +85,32 @@ fi %if 0%{?rhel} == 6 start kimchid +# Add defult iptable rules to open 8000 and 8001 port +iptables -I INPUT -p tcp --dport 8000 -j ACCEPT +iptables -I INPUT -p tcp --dport 8001 -j ACCEPT +service iptables save %else service kimchid start +# Add firewalld rull to open 8000 and 8001 port +/usr/bin/firewall-cmd --reload +/usr/bin/firewall-cmd --add-service kimchid %endif %preun +%if 0%{?rhel} == 6 +iptables -D INPUT -p tcp --dport 8000 -j ACCEPT +iptables -D INPUT -p tcp --dport 8001 -j ACCEPT +service iptables save +%else +/usr/bin/firewall-cmd --remove-service kimchid +%endif + if [ $1 -eq 0 ] ; then # Package removal, not upgrade /bin/systemctl --no-reload disable kimchid.service > /dev/null 2>&1 || : /bin/systemctl stop kimchid.service > /dev/null 2>&1 || : fi + exit 0 @@ -153,6 +171,7 @@ rm -rf $RPM_BUILD_ROOT %if 0%{?with_systemd} %{_unitdir}/kimchid.service +%{_prefix}/lib/firewalld/services/kimchid.xml %endif %if 0%{?rhel} == 6 /etc/init/kimchid.conf diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in index 9051284..dde9dae 100644 --- a/contrib/kimchi.spec.suse.in +++ b/contrib/kimchi.spec.suse.in @@ -46,10 +46,16 @@ install -Dm 0755 contrib/kimchid.sysvinit %{buildroot}%{_initrddir}/kimchid %post service kimchid start chkconfig kimchid on - +# Add iptables rules to open 8000 and 8001 port +iptables -I INPUT -p tcp --dport 8000 -j ACCEPT +iptables -I INPUT -p tcp --dport 8001 -j ACCEPT +service iptables save %preun service kimchid stop - +# Remove iptables rules to open 8000 and 8001 port +iptables -D INPUT -p tcp --dport 8000 -j ACCEPT +iptables -D INPUT -p tcp --dport 8001 -j ACCEPT +service iptables save %clean rm -rf $RPM_BUILD_ROOT diff --git a/contrib/kimchid.service.fedora b/contrib/kimchid.service.fedora index 7abe49b..e39f86b 100644 --- a/contrib/kimchid.service.fedora +++ b/contrib/kimchid.service.fedora @@ -1,6 +1,7 @@ [Unit] Description=Kimchi server Requires=libvirtd.service +Requires=firewalld.service After=libvirtd.service [Service] diff --git a/src/Makefile.am b/src/Makefile.am index 7d29e28..e3938a7 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -24,6 +24,7 @@ SUBDIRS = kimchi distros.d EXTRA_DIST = kimchid.in \ kimchi.conf.in \ + kimchid.xml \ $(NULL) bin_SCRIPTS = kimchid diff --git a/src/kimchid.xml b/src/kimchid.xml new file mode 100644 index 0000000..dee4599 --- /dev/null +++ b/src/kimchid.xml @@ -0,0 +1,7 @@ +<?xml version="1.0" encoding="utf-8"?> +<service> + <short>kimchid</short> + <description>Kimchid is a daemon service for kimchi whichi is a HTML5 based management tool for KVM. It is designed to make it as easy as possible to get started with KVM and create your first guest.</description> + <port protocol="tcp" port="8000"/> + <port protocol="tcp" port="8001"/> +</service> -- 1.7.1

6 7

[PATCH V2 0/2] check and set search permission for a directory
by shaohef＠linux.vnet.ibm.com 24 Dec '13

24 Dec '13

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> V1 -> V2 resend: qemu user tests rebase: add a method to fix search permissions ShaoHe Feng (2): qemu user tests: probe the username of qemu process started by libvirt add a method to fix search permissions src/kimchi/kvmusertests.py | 63 ++++++++++++++++++++++++ src/kimchi/utils.py | 116 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 178 insertions(+), 1 deletion(-) create mode 100644 src/kimchi/kvmusertests.py -- 1.8.4.2

3 4

[PATCH 0/2] Add the iscsi pool UI support
by zhoumeina 24 Dec '13

24 Dec '13

Include create storage pool UI and translation files. zhoumeina (2): Add UI support of iscsi Add the ISCSI translation po files po/en_US.po | 31 +++++++++++++---- po/kimchi.pot | 30 ++++++++++++---- po/pt_BR.po | 31 +++++++++++++---- po/zh_CN.po | 31 +++++++++++++---- ui/js/src/kimchi.storagepool_add_main.js | 54 ++++++++++++++++++++++++----- ui/pages/i18n.html.tmpl | 7 ++-- ui/pages/storagepool-add.html.tmpl | 19 ++++++++++ 7 files changed, 158 insertions(+), 45 deletions(-) mode change 100644 => 100755 po/kimchi.pot

3 5

[PATCH 2/2] Add the translate messages
by zhoumeina 24 Dec '13

24 Dec '13

Add the nfs server messages in po files Signed-off-by: zhoumeina <zhoumein(a)linux.vnet.ibm.com> --- po/en_US.po | 16 ++++++++++++++-- po/kimchi.pot | 15 +++++++++++++-- po/pt_BR.po | 18 +++++++++++++++--- po/zh_CN.po | 16 ++++++++++++++-- 4 files changed, 56 insertions(+), 9 deletions(-) diff --git a/po/en_US.po b/po/en_US.po index f2810db..79b095b 100644 --- a/po/en_US.po +++ b/po/en_US.po @@ -6,14 +6,14 @@ msgid "" msgstr "" "Project-Id-Version: kimchi 0.1\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-12-18 16:04-0200\n" +"POT-Creation-Date: 2013-12-24 10:17+0800\n" "PO-Revision-Date: 2013-07-11 17:32-0400\n" "Last-Translator: Crístian Viana <vianac(a)linux.vnet.ibm.com>\n" "Language-Team: English\n" -"Language: en_US\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" +"Language: en_US\n" "Generated-By: pygettext.py 1.5\n" "Plural-Forms: nplurals=2; plural=(n != 1);\n" @@ -407,6 +407,9 @@ msgstr "" "It will format your disk and you will loose any data in there, are you sure " "to continue? " +msgid "Please choose" +msgstr "Please choose" + msgid "Log out" msgstr "Log out" @@ -459,9 +462,18 @@ msgstr "" msgid "NFS server IP" msgstr "NFS server IP" +msgid "I want to input the server myself." +msgstr "I want to input the server myself." + +msgid "I want to choose a server I used before." +msgstr "I want to choose a server I used before." + msgid "NFS server IP or hostname. It should not be empty." msgstr "NFS server IP or hostname. It should not be empty." +msgid "Please choose the nfs server you want to create storage pool." +msgstr "Please choose the nfs server you want to create storage pool." + msgid "NFS Path" msgstr "NFS Path" diff --git a/po/kimchi.pot b/po/kimchi.pot index 762f4e4..78fd77b 100644 --- a/po/kimchi.pot +++ b/po/kimchi.pot @@ -8,11 +8,10 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-12-18 16:04-0200\n" +"POT-Creation-Date: 2013-12-24 10:17+0800\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" "Language-Team: LANGUAGE <LL(a)li.org>\n" -"Language: \n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=CHARSET\n" "Content-Transfer-Encoding: 8bit\n" @@ -392,6 +391,9 @@ msgid "" "to continue? " msgstr "" +msgid "Please choose" +msgstr "" + msgid "Log out" msgstr "" @@ -439,9 +441,18 @@ msgstr "" msgid "NFS server IP" msgstr "" +msgid "I want to input the server myself." +msgstr "" + +msgid "I want to choose a server I used before." +msgstr "" + msgid "NFS server IP or hostname. It should not be empty." msgstr "" +msgid "Please choose the nfs server you want to create storage pool." +msgstr "" + msgid "NFS Path" msgstr "" diff --git a/po/pt_BR.po b/po/pt_BR.po index 7d59503..f790154 100644 --- a/po/pt_BR.po +++ b/po/pt_BR.po @@ -20,14 +20,14 @@ msgid "" msgstr "" "Project-Id-Version: kimchi 1.0\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-12-18 16:04-0200\n" +"POT-Creation-Date: 2013-12-24 10:17+0800\n" "PO-Revision-Date: 2013-06-27 10:48+0000\n" "Last-Translator: Alexandre Hirata <hirata(a)linux.vnet.ibm.com>\n" "Language-Team: Aline Manera <alinefm(a)br.ibm.com>\n" -"Language: pt_BR\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" +"Language: pt_BR\n" "Generated-By: pygettext.py 1.5\n" "X-Poedit-Country: Brazil\n" "X-Poedit-Language: Portuguese\n" @@ -424,6 +424,9 @@ msgstr "" "Isso formatará seu disco e você perderá toda informação, você tem certeza " "que quer continuar?" +msgid "Please choose" +msgstr "" + msgid "Log out" msgstr "Sair" @@ -475,8 +478,17 @@ msgstr "" msgid "NFS server IP" msgstr "Endereço IP do servidor NFS" +msgid "I want to input the server myself." +msgstr "" + +msgid "I want to choose a server I used before." +msgstr "" + msgid "NFS server IP or hostname. It should not be empty." -msgstr "Endereço IP ou nome do servidor NFS. Não deve ser vazio. " +msgstr "" + +msgid "Please choose the nfs server you want to create storage pool." +msgstr "" msgid "NFS Path" msgstr "Caminho do NFS" diff --git a/po/zh_CN.po b/po/zh_CN.po index de759ef..890bfb6 100644 --- a/po/zh_CN.po +++ b/po/zh_CN.po @@ -20,14 +20,14 @@ msgid "" msgstr "" "Project-Id-Version: kimchi 0.1\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-12-18 16:04-0200\n" +"POT-Creation-Date: 2013-12-24 10:17+0800\n" "PO-Revision-Date: 2013-06-27 10:48+0000\n" "Last-Translator: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>\n" "Language-Team: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>\n" -"Language: zh_CN\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" +"Language: zh_CN\n" "Generated-By: pygettext.py 1.5\n" "X-Poedit-Country: CHINA\n" "X-Poedit-Language: Chinese\n" @@ -408,6 +408,9 @@ msgid "" "to continue? " msgstr "你的磁盘将会格式化，磁盘上的数据会丢失，你确定要继续吗？" +msgid "Please choose" +msgstr "请选择" + msgid "Log out" msgstr "登出" @@ -457,9 +460,18 @@ msgstr "存储池的路径.每个存储池的路径是唯一的。" msgid "NFS server IP" msgstr "NFS服务器IP" +msgid "I want to input the server myself." +msgstr "我想自己输入服务器" + +msgid "I want to choose a server I used before." +msgstr "我想选择一个我曾经用过的服务器" + msgid "NFS server IP or hostname. It should not be empty." msgstr "NFS服务器IP或者主机名，不能为空。" +msgid "Please choose the nfs server you want to create storage pool." +msgstr "请选择想要创建存储池的服务器" + msgid "NFS Path" msgstr "NFS 路径" -- 1.7.1

1 0

Strategy to leverage jquery UI
by Yu Xin Huo 23 Dec '13

23 Dec '13

Hi, Adam and Aline For my workitem below in sprint one, as I am not sure whether the title is exactly reflecting the content, I want to clarify the scope of it. Originally, we have discussed our strategy to leverage jquery ui and we got below initiatives. 1. Make use of jquery ui widgets wherever it is possible in kimchi. 2. For any reusable common UI component in Kimchi, make it a jquery widget. Whether this workitem is just the one to execute our jquery-ui strategy above or it means some special content for some other narrow-defined scope?

2 1

[PATCH 1/2] Bug #265 fix: Avoid remove 'default' storagepool
by Rodrigo Trujillo 23 Dec '13

23 Dec '13

This patch disables the "undefine" button if the storagepool is the 'default'. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.storage_main.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js index 169e32a..70ea9a3 100644 --- a/ui/js/src/kimchi.storage_main.js +++ b/ui/js/src/kimchi.storage_main.js @@ -113,6 +113,8 @@ kimchi.storageBindClick = function() { var deleteButton = storage_action.find('.pool-delete'); if ('active' === deleteButton.data('stat')) { deleteButton.attr('disabled', 'disabled'); + } else if ('default' === $(this).data('name')) { + deleteButton.attr('disabled', 'disabled'); } else { deleteButton.removeAttr('disabled'); } -- 1.8.1.4

2 2

[PATCH] pep8 cleanup for auth.py
by Aline Manera 23 Dec '13

23 Dec '13

From: Aline Manera <alinefm(a)br.ibm.com> This patch cleans up pep8 style issue in auth.py Signed-off-by: Aline Manera <alinefm(a)br.ibm.com> --- Makefile.am | 1 + src/kimchi/auth.py | 10 ++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index e57d3b6..7770ba7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -39,6 +39,7 @@ EXTRA_DIST = \ # So it will be checked from now on. PEP8_WHITELIST = \ src/kimchi/asynctask.py \ + src/kimchi/auth.py \ src/kimchi/config.py.in \ src/kimchi/disks.py \ src/kimchi/server.py \ diff --git a/src/kimchi/auth.py b/src/kimchi/auth.py index b665f21..f38d3d6 100644 --- a/src/kimchi/auth.py +++ b/src/kimchi/auth.py @@ -20,7 +20,7 @@ # # You should have received a copy of the GNU Lesser General Public # License along with this library; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA import base64 import cherrypy @@ -53,9 +53,9 @@ def authenticate(username, password, service="passwd"): elif qtype == PAM.PAM_PROMPT_ERROR_MSG: cherrypy.log.error_log.error("PAM authenticate prompt error " "message: %s" % query) - resp.append(('', 0)); + resp.append(('', 0)) elif qtype == PAM.PAM_PROMPT_TEXT_INFO: - resp.append(('', 0)); + resp.append(('', 0)) else: return None return resp @@ -72,6 +72,7 @@ def authenticate(username, password, service="passwd"): return True + def from_browser(): # Enable Basic Authentication for REST tools. # Ajax request sent from jQuery in browser will have "X-Requested-With" @@ -79,6 +80,7 @@ def from_browser(): requestHeader = cherrypy.request.headers.get("X-Requested-With", None) return (requestHeader == "XMLHttpRequest") + def check_auth_session(): """ A user is considered authenticated if we have an established session open @@ -99,7 +101,7 @@ def check_auth_httpba(): """ REST API users may authenticate with HTTP Basic Auth. This is not allowed for the UI because web browsers would cache the credentials and make it - impossible for the user to log out without closing their browser completely. + impossible for the user to log out without closing their browser completely """ if from_browser() or not template.can_accept('application/json'): return False -- 1.7.10.4

2 3

[PATCH] pep8 cleanup for cachebust.py
by Aline Manera 23 Dec '13

23 Dec '13

From: Aline Manera <alinefm(a)br.ibm.com> This patch cleans up pep8 style issue in cachebust.py Signed-off-by: Aline Manera <alinefm(a)br.ibm.com> --- Makefile.am | 1 + src/kimchi/cachebust.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index e57d3b6..2c390c4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -39,6 +39,7 @@ EXTRA_DIST = \ # So it will be checked from now on. PEP8_WHITELIST = \ src/kimchi/asynctask.py \ + src/kimchi/cachebust.py \ src/kimchi/config.py.in \ src/kimchi/disks.py \ src/kimchi/server.py \ diff --git a/src/kimchi/cachebust.py b/src/kimchi/cachebust.py index 4dcfb56..9a71f4f 100644 --- a/src/kimchi/cachebust.py +++ b/src/kimchi/cachebust.py @@ -18,7 +18,7 @@ # # You should have received a copy of the GNU Lesser General Public # License along with this library; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA import os @@ -28,6 +28,6 @@ from kimchi.config import get_prefix def href(url): # for error.html, url is absolute path - f = os.path.join(get_prefix(),'ui', url.lstrip("/")) + f = os.path.join(get_prefix(), 'ui', url.lstrip("/")) mtime = os.path.getmtime(f) return "%s?cacheBust=%s" % (url, mtime) -- 1.7.10.4

2 2

[PATCH V4 (rebase) ] Bug fix: Kimchi will try to create directory for 'DIR' storagepool
by Rodrigo Trujillo 23 Dec '13

23 Dec '13

When you create a 'DIR' storagepool, kimchi does not check if the path exists, returning errors when you try to activate the SP. This path makes kimchi check the path and created the directory, if it does not exist. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- src/kimchi/model.py | 8 ++++---- ui/pages/storagepool-add.html.tmpl | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/kimchi/model.py b/src/kimchi/model.py index d5d0dd8..a6790b8 100644 --- a/src/kimchi/model.py +++ b/src/kimchi/model.py @@ -1009,16 +1009,16 @@ class Model(object): return name pool = conn.storagePoolDefineXML(xml, 0) - if params['type'] == 'logical': - pool.setAutostart(1) + if params['type'] in ['logical', 'dir']: pool.build(libvirt.VIR_STORAGE_POOL_BUILD_NEW) - if params['type'] == 'dir': - # autostart dir storage pool created from kimchi + # autostart dir and logical storage pool created from kimchi pool.setAutostart(1) else: # disable autostart for others pool.setAutostart(0) except libvirt.libvirtError as e: + msg = "Problem creating Storage Pool: %s" + kimchi_log.error(msg, e) raise OperationFailed(e.get_error_message()) return name diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 3ab9ae5..5a2dd45 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -63,6 +63,8 @@ <div class="field"> <p class="text-help"> $_("The path of the Storage Pool. Each Storage Pool must have a unique path.")</p> + <p class="text-help"> + $_("Kimchi will try to create the directory when it does not already exist in your system.")</p> <input id="pathId" type="text" class="text" style="width: 300px"> </div> <div class="clear"></div> @@ -116,4 +118,4 @@ </div> </script> </body> -</html> \ No newline at end of file +</html> -- 1.8.1.4

2 2

[RFC] FIBRE CHANNEL StoragePool
by Rodrigo Trujillo 23 Dec '13

23 Dec '13

Hi all, continuing the discussion: So, what to do ? Create/Enable SCSI StoragePool ?, then list FC devices on it ? ############## from previous emails ################ - Fibre Channel is used as a subtype of SCSI - FC LUNs will be mapped as /dev/sdX devices - Those devices can be used as PV in a VG , or as a Logical StoragePool - LUNs can also be mapped as /dev/disk/by-id/wwn-0x600507680280865df800000000000060 Links: http://wiki.libvirt.org/page/NPIV_in_libvirt#NPIV_in_libvirt http://libvirt.org/formatstorage.html (search for 'fc_host') ##############################################

3 2