December 2015 - Kimchi-devel - oVirt List Archives

[PATCH] [Kimchi] Issue 776: Adding filter on Guest screen
by sguimaraes943＠gmail.com 15 Dec '15

15 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> This patch adds Filter to Guests screen. samhenri (1): Issue 776: Adding filter on Guest screen ui/js/src/kimchi.guest_main.js | 56 +++++++++++++++++++++++++++++++++++++----- ui/pages/tabs/guests.html.tmpl | 32 ++++++++++++++---------- 2 files changed, 69 insertions(+), 19 deletions(-) -- 1.9.3

2 2

[PATCH] [Kimchi] Moved Kimchi SCSS files from Wok to Kimchi
by sguimaraes943＠gmail.com 15 Dec '15

15 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> Removed unused Kimchi files (mostly images) and added some SCSS files that were on Wok project to Kimchi. samhenri (1): Moved Kimchi SCSS files from Wok to Kimchi .gitignore | 1 + configure.ac | 1 - ui/css/Makefile.am | 11 +- ui/css/src/kimchi.scss | 43 +++ ui/css/src/modules/_edit-guests.scss | 367 ++++++++++++++++++++++ ui/css/src/modules/_guests.scss | 353 +++++++++++++++++++++ ui/css/src/modules/_iso-list.scss | 126 ++++++++ ui/css/src/modules/_network.scss | 121 ++++++++ ui/css/src/modules/_storage.scss | 390 ++++++++++++++++++++++++ ui/css/src/modules/_templates.scss | 315 +++++++++++++++++++ ui/css/theme-default/icon.css | 106 ------- ui/css/theme-default/storage.css | 52 ---- ui/images/Makefile.am | 2 - ui/images/theme-default/Makefile.am | 20 -- ui/images/theme-default/ac22_pause.png | Bin 1219 -> 0 bytes ui/images/theme-default/ac22_pause_grey.png | Bin 1175 -> 0 bytes ui/images/theme-default/ac24_resume.png | Bin 1341 -> 0 bytes ui/images/theme-default/ac24_resume_grey.png | Bin 1282 -> 0 bytes ui/images/theme-default/arrow-down-black.png | Bin 2942 -> 0 bytes ui/images/theme-default/arrow-down-disable.png | Bin 472 -> 0 bytes ui/images/theme-default/arrow-down.png | Bin 537 -> 0 bytes ui/images/theme-default/arrow-up.png | Bin 510 -> 0 bytes ui/images/theme-default/arrow_out.png | Bin 3048 -> 0 bytes ui/images/theme-default/group.png | Bin 1703 -> 0 bytes ui/images/theme-default/host-icon-sprite.png | Bin 1034 -> 0 bytes ui/images/theme-default/icon-back.png | Bin 244 -> 0 bytes ui/images/theme-default/icon-camera.png | Bin 4860 -> 0 bytes ui/images/theme-default/icon-design.png | Bin 4562 -> 0 bytes ui/images/theme-default/icon-detail.png | Bin 3079 -> 0 bytes ui/images/theme-default/icon-iso.png | Bin 4188 -> 0 bytes ui/images/theme-default/icon-list.png | Bin 2983 -> 0 bytes ui/images/theme-default/icon-load.png | Bin 3678 -> 0 bytes ui/images/theme-default/icon-local.png | Bin 425 -> 0 bytes ui/images/theme-default/icon-power-down.png | Bin 4372 -> 0 bytes ui/images/theme-default/icon-power-up.png | Bin 4367 -> 0 bytes ui/images/theme-default/icon-qcow2.png | Bin 4684 -> 0 bytes ui/images/theme-default/icon-raw.png | Bin 4679 -> 0 bytes ui/images/theme-default/icon-remote.png | Bin 1005 -> 0 bytes ui/images/theme-default/icon-reset.png | Bin 4576 -> 0 bytes ui/images/theme-default/icon-search.png | Bin 4197 -> 0 bytes ui/images/theme-default/icon-sort.png | Bin 3421 -> 0 bytes ui/images/theme-default/icon-tree.png | Bin 3526 -> 0 bytes ui/images/theme-default/icon-user.png | Bin 5366 -> 0 bytes ui/images/theme-default/icon-volume-default.png | Bin 4265 -> 0 bytes ui/images/theme-default/kimchi-loading15x15.gif | Bin 1653 -> 0 bytes ui/images/theme-default/loading.gif | Bin 2190 -> 0 bytes ui/images/theme-default/user.png | Bin 1322 -> 0 bytes ui/pages/guest-edit.html.tmpl | 5 + ui/pages/guest-storage-add.html.tmpl | 7 + ui/pages/network-add.html.tmpl | 4 + ui/pages/storagepool-add-volume.html.tmpl | 4 + ui/pages/storagepool-add.html.tmpl | 3 +- ui/pages/tabs/guests.html.tmpl | 4 +- ui/pages/tabs/network.html.tmpl | 3 +- ui/pages/tabs/storage.html.tmpl | 4 +- ui/pages/tabs/templates.html.tmpl | 1 + ui/pages/template-add.html.tmpl | 1 - ui/pages/template-edit.html.tmpl | 5 +- 58 files changed, 1753 insertions(+), 196 deletions(-) create mode 100644 ui/css/src/kimchi.scss create mode 100644 ui/css/src/modules/_edit-guests.scss create mode 100644 ui/css/src/modules/_guests.scss create mode 100644 ui/css/src/modules/_iso-list.scss create mode 100644 ui/css/src/modules/_network.scss create mode 100644 ui/css/src/modules/_storage.scss create mode 100644 ui/css/src/modules/_templates.scss delete mode 100644 ui/css/theme-default/icon.css delete mode 100644 ui/css/theme-default/storage.css delete mode 100644 ui/images/theme-default/Makefile.am delete mode 100644 ui/images/theme-default/ac22_pause.png delete mode 100644 ui/images/theme-default/ac22_pause_grey.png delete mode 100644 ui/images/theme-default/ac24_resume.png delete mode 100644 ui/images/theme-default/ac24_resume_grey.png delete mode 100644 ui/images/theme-default/arrow-down-black.png delete mode 100644 ui/images/theme-default/arrow-down-disable.png delete mode 100644 ui/images/theme-default/arrow-down.png delete mode 100644 ui/images/theme-default/arrow-up.png delete mode 100644 ui/images/theme-default/arrow_out.png delete mode 100644 ui/images/theme-default/group.png delete mode 100644 ui/images/theme-default/host-icon-sprite.png delete mode 100644 ui/images/theme-default/icon-back.png delete mode 100644 ui/images/theme-default/icon-camera.png delete mode 100644 ui/images/theme-default/icon-design.png delete mode 100644 ui/images/theme-default/icon-detail.png delete mode 100644 ui/images/theme-default/icon-iso.png delete mode 100644 ui/images/theme-default/icon-list.png delete mode 100644 ui/images/theme-default/icon-load.png delete mode 100644 ui/images/theme-default/icon-local.png delete mode 100644 ui/images/theme-default/icon-power-down.png delete mode 100644 ui/images/theme-default/icon-power-up.png delete mode 100644 ui/images/theme-default/icon-qcow2.png delete mode 100644 ui/images/theme-default/icon-raw.png delete mode 100644 ui/images/theme-default/icon-remote.png delete mode 100644 ui/images/theme-default/icon-reset.png delete mode 100644 ui/images/theme-default/icon-search.png delete mode 100644 ui/images/theme-default/icon-sort.png delete mode 100644 ui/images/theme-default/icon-tree.png delete mode 100644 ui/images/theme-default/icon-user.png delete mode 100644 ui/images/theme-default/icon-volume-default.png delete mode 100644 ui/images/theme-default/kimchi-loading15x15.gif delete mode 100644 ui/images/theme-default/loading.gif delete mode 100644 ui/images/theme-default/user.png -- 1.9.3

2 2

[PATCH] [Wok] Removed Kimchi references and SCSS files from Wok
by sguimaraes943＠gmail.com 15 Dec '15

15 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> This patch removes all the old Kimchi references from Wok. The removed files will be added to Kimchi in another patch. samhenri (1): Removed Kimchi references and SCSS files from Wok ui/css/src/modules/_edit-guests.scss | 367 -------------------------------- ui/css/src/modules/_guests.scss | 364 -------------------------------- ui/css/src/modules/_iso-list.scss | 126 ----------- ui/css/src/modules/_line-chart.scss | 210 ------------------- ui/css/src/modules/_loaders.scss | 10 + ui/css/src/modules/_network.scss | 121 ----------- ui/css/src/modules/_storage.scss | 391 ----------------------------------- ui/css/src/modules/_templates.scss | 315 ---------------------------- ui/css/src/modules/_utils.scss | 28 +++ ui/css/src/modules/_validation.scss | 17 ++ ui/css/src/wok.scss | 45 +--- ui/pages/wok-ui.html.tmpl | 2 +- 12 files changed, 59 insertions(+), 1937 deletions(-) delete mode 100644 ui/css/src/modules/_edit-guests.scss delete mode 100644 ui/css/src/modules/_guests.scss delete mode 100644 ui/css/src/modules/_iso-list.scss delete mode 100644 ui/css/src/modules/_line-chart.scss delete mode 100644 ui/css/src/modules/_network.scss delete mode 100644 ui/css/src/modules/_storage.scss delete mode 100644 ui/css/src/modules/_templates.scss create mode 100644 ui/css/src/modules/_utils.scss -- 1.9.3

2 2

[PATCH] [Kimchi] Update Kimchi objectstore versioning.
by pvital＠linux.vnet.ibm.com 15 Dec '15

15 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch is part of the solution for the Ginger Issue #51 and it depends on Wok's "Upgrade objectstore schema" patch. With the new structure of the objectstore changed in Wok 2.0.0, the schema of the objectstore file needs to be checked and, if necessary, updated to reflect the new structure. This patch removes from Kimchi the methods used to check the objectstore schema and upgrade it if necessary. These methods are now present in wok.plugins and are common to any Wok plugin. Paulo Vital (1): Update Kimchi objectstore versioning. root.py | 4 ++-- utils.py | 40 ---------------------------------------- 2 files changed, 2 insertions(+), 42 deletions(-) -- 2.5.0

4 7

[PATCH] [Wok] Upgrade objectstore schema.
by pvital＠linux.vnet.ibm.com 15 Dec '15

15 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch is part of the solution for the Ginger Issue #51 and it's a basic dependence for the following plugins' patches: + [Kimchi] Update Kimchi objectstore versioning. + [Ginger] Issue #51 - Update objectstores with 'Version' field. + [GingerBase] Issue #51 - Update objectstores with 'Version' field. With the new structure of the objectstore changed in Wok 2.0.0, the schema of the objectstore file (when used by any plugin) needs to be checked and, if necessary, updated to reflect the new structure. This patch adds to utils.py file some common methods to support the operations in the plugin's objectstore files. These methods were moved from Kimchi plugin since they will be used by other plugins to do the same. Paulo Vital (1): Upgrade objectstore schema. src/wok/utils.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) -- 2.5.0

3 3

[PATCH] [Wok] Upgrade objectstore schema.
by pvital＠linux.vnet.ibm.com 15 Dec '15

15 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> With the new structure of the objectstore changed in Wok 2.0.0, the schema of the objectstore file (when used by any plugin) needs to be checked and, if necessary, updated to reflect the new structure. This patch adds to utils.py file some common methods to support the operations in the plugin's objectstore files. These methods were moved from Kimchi plugin since they will be used by other plugins to do the same. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- src/wok/utils.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/src/wok/utils.py b/src/wok/utils.py index 8c8973a..997adf3 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -26,6 +26,7 @@ import os import psutil import pwd import re +import sqlite3 import subprocess import traceback import xml.etree.ElementTree as ET @@ -504,3 +505,47 @@ def convert_data_size(value, from_unit, to_unit='B'): break return ret + + +def get_objectstore_fields(objstore=None): + """ + Return a list with all fields from the objectstore. + """ + if objstore is None: + wok_log.error("No objectstore set up.") + return None + conn = sqlite3.connect(objstore, timeout=10) + cursor = conn.cursor() + schema_fields = [] + sql = "PRAGMA table_info('objects')" + cursor.execute(sql) + for row in cursor.fetchall(): + schema_fields.append(row[1]) + return schema_fields + + +def upgrade_objectstore_schema(objstore=None, field=None): + """ + Add a new column (of type TEXT) in the objectstore schema. + """ + if (field or objstore) is None: + wok_log.error("Cannot upgrade objectstore schema.") + return False + + if field in get_objectstore_fields(objstore): + # field already exists in objectstore schema. Nothing to do. + return False + try: + conn = sqlite3.connect(objstore, timeout=10) + cursor = conn.cursor() + sql = "ALTER TABLE objects ADD COLUMN %s TEXT" % field + cursor.execute(sql) + wok_log.info("Objectstore schema sucessfully upgraded: %s" % objstore) + conn.close() + except sqlite3.Error, e: + if conn: + conn.rollback() + conn.close() + wok_log.error("Cannot upgrade objectstore schema: %s" % e.args[0]) + return False + return True -- 2.5.0

4 3

[PATCH] [Kimchi] Use correct gettext package for building
by Lucio Correia 15 Dec '15

15 Dec '15

The correct gettext package needs to be installed in each distro in order autogen does not show the following error messages: warning: macro 'AM_GNU_GETTEXT' not found in library warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- docs/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/README.md b/docs/README.md index bdfbd81..dc58556 100644 --- a/docs/README.md +++ b/docs/README.md @@ -48,7 +48,7 @@ Install Dependencies **For fedora and RHEL:** - $ sudo yum install wok libvirt-python libvirt \ + $ sudo yum install wok libvirt-python libvirt gettext-devel \ libvirt-daemon-config-network python-imaging \ qemu-kvm python-ethtool sos python-ipaddr \ nfs-utils iscsi-initiator-utils pyparted \ @@ -81,14 +81,14 @@ channel at RHN Classic or Red Hat Satellite. qemu-kvm python-parted python-ethtool sosreport \ xsltproc python-ipaddr python-lxml open-iscsi \ python-guestfs libguestfs-tools spice-html5 \ - python-magic python-paramiko \ + python-magic python-paramiko gettext \ # These dependencies are only required if you want to run the tests: $ sudo apt-get install pep8 pyflakes python-requests python-mock **For openSUSE:** - $ sudo zypper install wok libvirt-python libvirt \ + $ sudo zypper install wok libvirt-python libvirt gettext-tools \ libvirt-daemon-config-network python-imaging \ kvm python-ethtool python-ipaddr nfs-client \ open-iscsi python-parted python-libguestfs \ -- 1.9.1

1 0

[PATCH] [Kimchi 0/9] Kimchi bugfixes
by sguimaraes943＠gmail.com 15 Dec '15

15 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> This patch-set fixes some issues that were reported on Github and adds some enhancements. Before applying this patch, make sure you have "Media Query v2 and Bug Fixes" for Wok applied in your branch. samhenri (9): Removed theme-default.min.css reference Issue 770: New template is not shown right after creation Issue 772: Template tab and Template edit window - Some problems Issue 773: Snapshot error message showed behind edit window Issue 783: Error message hidden by the modal window Issue 776: Adding filter on Templates screen New i18n strings in PT-BR Issue 777: Network tab not being updated after exclude a network Issue 784: Display a 'loading gif' when waiting for data po/pt_BR.po | 60 ++++- ui/js/src/kimchi.api.js | 38 +-- ui/js/src/kimchi.guest_edit_main.js | 75 +++--- ui/js/src/kimchi.guest_storage_add.main.js | 38 +-- ui/js/src/kimchi.network.js | 7 +- ui/js/src/kimchi.storage_main.js | 34 +-- ui/js/src/kimchi.storagepool_add_main.js | 43 ++-- ui/js/src/kimchi.storagepool_add_volume_main.js | 27 ++- ui/js/src/kimchi.template_add_main.js | 305 +++++++++++++----------- ui/js/src/kimchi.template_edit_main.js | 17 +- ui/js/src/kimchi.template_main.js | 50 ++-- ui/pages/guest-storage-add.html.tmpl | 1 + ui/pages/i18n.json.tmpl | 6 + ui/pages/storagepool-add-volume.html.tmpl | 1 + ui/pages/storagepool-add.html.tmpl | 3 +- ui/pages/tabs/network.html.tmpl | 19 +- ui/pages/tabs/storage.html.tmpl | 14 +- ui/pages/tabs/templates.html.tmpl | 89 ++++--- ui/pages/template-add.html.tmpl | 68 ++---- 19 files changed, 497 insertions(+), 398 deletions(-) -- 1.9.3

2 10

[PATCH 0/2] [Wok] Media Queries and wok.message
by sguimaraes943＠gmail.com 15 Dec '15

15 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> This patch corrects some screen width problems with small screens in desktos / laptops. Please note that these changes were made without any mockup for different sets of screen resolutions other than the design spec. This doesn't include mobile support yet. The second patch fixes the wok.message.js delay and fade-out. It was too fast for long messages. Delay was changed to 10s and fade-out to 4s. Regards, Samuel samhenri (2): [Wok] Adding Media Queries for different screen sizes [Wok] Fixed wok.message.js fade-out timing ui/css/src/bootstrap.custom.scss | 1 - ui/css/src/modules/_guests.scss | 52 ++++++++-- ui/css/src/modules/_menu-flat.scss | 3 +- ui/css/src/modules/_navbar-flat.scss | 106 ++++++++------------- ui/css/src/modules/_network.scss | 6 +- ui/css/src/modules/_toolbar.scss | 25 ++++- ui/css/src/modules/_wok-variables.scss | 15 +-- .../vendor/bootstrap-sass/bootstrap/_alerts.scss | 17 +++- .../src/vendor/bootstrap-sass/bootstrap/_grid.scss | 2 + ui/css/src/wok.scss | 83 ++++++++-------- ui/js/src/wok.message.js | 4 +- 11 files changed, 180 insertions(+), 134 deletions(-) -- 1.9.3

2 4

[PATCH] [Wok 00/10] Media Queries v2 and Bug fixes
by sguimaraes943＠gmail.com 15 Dec '15

15 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> The following patchesfixes some minor issues with CSS and JS, including CSS Media Queries support on desktops for Wok and Kimchi (supported screen width: 1024, 1280, 1366, 1440, 1680 and 1920). Bugfixes: *wok.message.js - Increased fade-out timing *Moved Loader classes to a new SCSS module and created classes to support loading screen (Kimchi Issue: #784) *Edit Guests - Snapshots grid when generating a new Snapshot *Moved wok-checkbox and wok-radio to a new SCSS module *Added List.JS library to enable Filtering and Sorting in Templates and Guests *Updated Templates styles to support Filters *Removed unused SCSS files *Prevented all Bootstrap modal windows from closing when clicking on the backdrop (Ginger Issue: #59) *About Window (Wok Issue: #5 / Kimchi Issue: #706) samhenri (10): Adding Media Queries for different screen sizes Fixed wok.message.js fade-out timing 'Loading' mask and backdrop SCSS Fix Snapshots grid in Edit Guests modal Moved .wok-radio and .wok-checkbox to a new SCSS module Adding List.js lib for Filters in Templates and Guests Updated Templates styles to support filter Removed unused files Prevented modals from closing when clicking on the backdrop About Window configure.ac | 1 + ui/css/src/bootstrap.custom.scss | 1 - ui/css/src/modules/_about.scss | 32 +++++ ui/css/src/modules/_datagrid.scss | 9 +- ui/css/src/modules/_edit-guests.scss | 5 + ui/css/src/modules/_guests.scss | 67 ++++++++--- ui/css/src/modules/_jqueryui.scss | 0 ui/css/src/modules/_loaders.scss | 55 +++++++++ ui/css/src/modules/_menu-flat.scss | 3 +- ui/css/src/modules/_navbar-flat.scss | 132 ++++++++++----------- ui/css/src/modules/_network.scss | 6 +- ui/css/src/modules/_templates.scss | 39 +++--- ui/css/src/modules/_toolbar.scss | 25 +++- ui/css/src/modules/_wok-forms.scss | 55 +++++++++ ui/css/src/modules/_wok-grid.scss | 31 ----- ui/css/src/modules/_wok-variables.scss | 17 +-- .../vendor/bootstrap-sass/bootstrap/_alerts.scss | 17 ++- .../src/vendor/bootstrap-sass/bootstrap/_grid.scss | 2 + ui/css/src/wok.scss | 101 +++------------- ui/js/src/wok.main.js | 5 +- ui/js/src/wok.message.js | 6 +- ui/js/src/wok.window.js | 5 + ui/libs/Makefile.am | 2 +- ui/libs/list-js/LICENSE | 21 ++++ ui/libs/list-js/Makefile.am | 22 ++++ ui/libs/list-js/list.min.js | 1 + ui/pages/wok-ui.html.tmpl | 41 ++++--- 27 files changed, 433 insertions(+), 268 deletions(-) create mode 100644 ui/css/src/modules/_about.scss delete mode 100644 ui/css/src/modules/_jqueryui.scss create mode 100644 ui/css/src/modules/_loaders.scss create mode 100644 ui/css/src/modules/_wok-forms.scss create mode 100644 ui/libs/list-js/LICENSE create mode 100644 ui/libs/list-js/Makefile.am create mode 100644 ui/libs/list-js/list.min.js -- 1.9.3

2 11