April 2016 - Kimchi-devel - oVirt List Archives

[PATCH] [Kimchi] Disable Template when it has invalid parameters
by peterpnns＠gmail.com 05 May '16

05 May '16

From: peterpennings <peterpnns(a)gmail.com> This patch adds a block behavior on the action to select invalid templates when creating a guest peterpennings (1): Disable Template when it has invalid parameters ui/css/kimchi.css | 28 ++++++++++++++++++--- ui/css/src/modules/_guests.scss | 6 +++++ ui/css/src/modules/_templates.scss | 18 +++++++++++--- ui/js/src/kimchi.guest_add_main.js | 8 ++++++ ui/js/src/kimchi.network_add_main.js | 48 +++++++++++++++++++++++++----------- ui/js/src/kimchi.template_main.js | 9 +++++-- ui/pages/guest-add.html.tmpl | 7 +++--- ui/pages/tabs/templates.html.tmpl | 6 +++-- 8 files changed, 102 insertions(+), 28 deletions(-) -- 2.5.0

2 4

Wok Debian/Ubuntu integration
by Frederic Bonnard 03 May '16

03 May '16

Hi, with the new version 2.1.0 of wok/kimchi/gingerbase, I updated my packaging. I'm still having a few issues and as there is a github issue concerning having wok related projects inside Ubuntu, I'd like to share some concerns so far. Here are the details : https://github.com/kimchi-project/wok/issues/25#issuecomment-211483696 - For the "relative URLs" issue, I've got some packages done and installed. Anyone could help on fixing those ? I've got a server I can give access to a wok developer, or I can send the .deb to someone willing to install them on his machine. - For the second issue, is it worth I send an updated patch against wok, or do you see other ways of doing to disable launching a specific instance of nginx ? F.

2 1

[PATCH v2] [Kimchi] Disable Template when it has invalid parameters
by sguimaraes943＠gmail.com 03 May '16

03 May '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch adds a block behavior on the action to select invalid templates when creating a guest peterpennings (1): Disable Template when it has invalid parameters Samuel Guimarães (1): Disable Template when it has invalid parameters v2: - Removed reference to kimchi.network_add_main.js - Fixed warning icon position in list and gallery views - Remoed tooltip when template is valid - Added front-end form validation when user attempts to save invalid storage pool (must apply "Enabled .has-feedback icons" patch sent to Wok first) - Added form control error class when template has invalid cdrom (reported issue #933 for vm-image not showing in invalid key) ui/css/kimchi.css | 97 ++++++++++++++++++++++++++++++++-- ui/css/src/modules/_guests.scss | 6 +++ ui/css/src/modules/_iso-list.scss | 22 +++++++- ui/css/src/modules/_templates.scss | 53 +++++++++++++++++-- ui/js/src/kimchi.guest_add_main.js | 7 +++ ui/js/src/kimchi.template_edit_main.js | 52 ++++++++++++++---- ui/js/src/kimchi.template_main.js | 9 +++- ui/pages/guest-add.html.tmpl | 11 ++-- ui/pages/i18n.json.tmpl | 1 + ui/pages/tabs/templates.html.tmpl | 24 +++++---- ui/pages/template-edit.html.tmpl | 6 ++- 11 files changed, 255 insertions(+), 33 deletions(-) -- 1.9.3

2 3

[PATCH] [Wok] Form validation: Enabled .has-feedback icons
by sguimaraes943＠gmail.com 02 May '16

02 May '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch enables Font-Awesome icons when a .from-group has .has-feedback and .has-error or .has-warning classes. This is required to "Disable Template when it has invalid parameters" v2 that will be sent in this list. Samuel Guimarães (1): Enabled .has-feedback icons ui/css/src/modules/_wok-forms.scss | 6 ++++++ ui/css/wok.css | 6 ++++++ 2 files changed, 12 insertions(+) -- 1.9.3

2 2

[PATCH][Wok] Sort user request log output
by Rodrigo Trujillo 30 Apr '16

30 Apr '16

There is an issue in user request log output when you have backup files in your system. The values from backup logs are included in the return list and showed before latest events. Then user has to use UI sort buttons in order to see what is happening. This patch sorts the output, ensuring that latest events will be returned on 'top' of the list and be showed firstly in the UI. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- src/wok/reqlogger.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/wok/reqlogger.py b/src/wok/reqlogger.py index 1294be1..1145dbd 100644 --- a/src/wok/reqlogger.py +++ b/src/wok/reqlogger.py @@ -105,7 +105,9 @@ class RequestParser(object): filename = ".".join([self.baseFile, str(count + 1)]) records.extend(self.getRecordsFromFile(filename)) - return records + # Return ordered by latest events first + return sorted(records, key=lambda k: k['date'] + k['time'], + reverse=True) def getRecordsFromFile(self, filename): """ -- 2.1.0

3 2

[PATCH][Wok] Move local log path from 'log' to 'data/logs'
by Rodrigo Trujillo 30 Apr '16

30 Apr '16

When run wok from local build (not installed), use data/logs as the default log directory. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- src/wok/config.py.in | 2 +- tests/test_config.py.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wok/config.py.in b/src/wok/config.py.in index 6bc0c1e..0c3acdd 100644 --- a/src/wok/config.py.in +++ b/src/wok/config.py.in @@ -91,7 +91,7 @@ class Paths(object): else: self.nginx_conf_dir = self.add_prefix('src/nginx') self.state_dir = self.add_prefix('data') - self.log_dir = self.add_prefix('log') + self.log_dir = self.add_prefix('data/logs') self.conf_dir = self.add_prefix('src') self.src_dir = self.add_prefix('src/wok') self.plugins_dir = self.add_prefix('src/wok/plugins') diff --git a/tests/test_config.py.in b/tests/test_config.py.in index 3020c53..1e7cc72 100644 --- a/tests/test_config.py.in +++ b/tests/test_config.py.in @@ -57,7 +57,7 @@ class ConfigTests(unittest.TestCase): Paths.get_prefix = lambda self: '/home/user/wok' paths = Paths() self.assertEquals(paths.state_dir, '/home/user/wok/data') - self.assertEquals(paths.log_dir, '/home/user/wok/log') + self.assertEquals(paths.log_dir, '/home/user/wok/data/logs') self.assertEquals(paths.conf_dir, '/home/user/wok/src') self.assertEquals(paths.src_dir, '/home/user/wok/src/wok') self.assertEquals(paths.plugins_dir, '/home/user/wok/src/wok/plugins') -- 2.1.0

3 2

[PATCH][Kimchi] Fix logging and error messages in objectstore upgrade
by Rodrigo Trujillo 30 Apr '16

30 Apr '16

There are bugs in excepts in objectstore upgrade functions: - wok_log is in wrong position, after raise, and is never called; - log message misses '%s' operator Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utils.py b/utils.py index 3837e74..c4cd07d 100644 --- a/utils.py +++ b/utils.py @@ -111,8 +111,8 @@ def upgrade_objectstore_data(item, old_uri, new_uri): except sqlite3.Error, e: if conn: conn.rollback() + wok_log.error("Error while upgrading objectstore data: %s", e.args[0]) raise OperationFailed("KCHUTILS0006E") - wok_log.error("Error while upgrading objectstore data:", e.args[0]) finally: if conn: conn.close() @@ -157,8 +157,8 @@ def upgrade_objectstore_template_disks(libv_conn): except sqlite3.Error, e: if conn: conn.rollback() + wok_log.error("Error while upgrading objectstore data: %s", e.args[0]) raise OperationFailed("KCHUTILS0006E") - wok_log.error("Error while upgrading objectstore data:", e.args[0]) finally: if conn: conn.close() @@ -200,8 +200,8 @@ def upgrade_objectstore_memory(): except sqlite3.Error, e: if conn: conn.rollback() + wok_log.error("Error while upgrading objectstore data: %s", e.args[0]) raise OperationFailed("KCHUTILS0006E") - wok_log.error("Error while upgrading objectstore data:", e.args[0]) finally: if conn: conn.close() -- 2.1.0

3 2

[PATCH v3] [Wok] Changes in wok.list.js widget to allow multiple selection
by sguimaraes943＠gmail.com 28 Apr '16

28 Apr '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch updates wok.list.js widget to allow multiple selection in Debug Reports and Repositories in Gingerbase. Another patch was sent to Ginger Dev List covering the changes necessary. This patch also includes changes in Wok SCSS and CSS aiming accessibility and responsive design. v2 - Displays checkbox on all screen sizes and platforms. Fixed spinner icon position when generating a new log. v3 - Fixed spinner position in desktop. Samuel Guimarães (1): Changes in wok.list.js widget to allow multiple selection ui/css/bootstrap.custom.css | 8 +- ui/css/src/modules/_buttons.scss | 8 ++ ui/css/src/modules/_wok-forms.scss | 1 + ui/css/src/modules/_wok-grid.scss | 250 +++++++++++++++++++++++++++----- ui/css/src/modules/_wok-variables.scss | 4 +- ui/css/wok.css | 254 ++++++++++++++++++++++++++++----- ui/js/src/wok.list.js | 174 +++++++++++----------- 7 files changed, 531 insertions(+), 168 deletions(-) -- 1.9.3

3 4

[PATCH v3] [Wok] Changes in wok.list.js widget to allow multiple selection
by sguimaraes943＠gmail.com 28 Apr '16

28 Apr '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch updates wok.list.js widget to allow multiple selection in Debug Reports and Repositories in Gingerbase. Another patch was sent to Ginger Dev List covering the changes necessary. This patch also includes changes in Wok SCSS and CSS aiming accessibility and responsive design. v2 - Displays checkbox on all screen sizes and platforms. Fixed spinner icon position when generating a new log. v3 - Fixed spinner position in desktop. Samuel Guimarães (1): Changes in wok.list.js widget to allow multiple selection ui/css/bootstrap.custom.css | 8 +- ui/css/src/modules/_buttons.scss | 8 ++ ui/css/src/modules/_wok-forms.scss | 1 + ui/css/src/modules/_wok-grid.scss | 250 +++++++++++++++++++++++++++----- ui/css/src/modules/_wok-variables.scss | 4 +- ui/css/wok.css | 254 ++++++++++++++++++++++++++++----- ui/js/src/wok.list.js | 174 +++++++++++----------- 7 files changed, 531 insertions(+), 168 deletions(-) -- 1.9.3

2 2

[RFC] Issue 201 - Kimchi should handle libvirt connection failures
by Paulo Ricardo Paz Vital 28 Apr '16

28 Apr '16

Today, Kimchi (and Ginger) has a strong dependency with Libvirt, well described in the kimchid.service.{fedora,ubuntu} file that extends the wokd.service configuration to make it dependent of libvirt service. The current configuration stops wokd service automatically if libvirt service is stopped. To prevent wokd to stop automatically if libvirt stops, a new configuration must be set up and loaded, making wokd service still available to user. This is the easiest part to solve this issue. The real issue is that most of the Kimchi operations need to connect to libvirt service and the current implementation, simple stops the cherrypy server if a connection is not available (after 10 seconds trying to connect), causing a "502 bad gateway" error from NGINX. With this implementation from Kimchi, Wok and GingerBase (and Ginger if installed) will not be available to user even though they don't depend on the libvirt service. Basically, the proposal to solve the issue is: 1) Modify the kimchid.service.{fedora,ubuntu} files to "reduce" the dependency on libvirt service while wokd is already running - none change will modify the start up dependency; and 2) Modify how Kimchi handle the missing libvirt connection to no stop the cherrypy server and provide information to user by Virtualization tab and its sub-tabs, keeping all other plugins enabled and operating. Feel free to make any suggestion. Patches will be submitted by the end of this week. Thanks and best regards, -- Paulo Ricardo Paz Vital Linux Technology Center, IBM Systems http://www.ibm.com/linux/ltc/

3 6