May 2016 - Kimchi-devel - oVirt List Archives

[PATCH] [Kimchi] Create template error message not being displayed in panel
by Socorro Stoppler 06 May '16

06 May '16

When an error occurs in Create Template, the error message is being displayed on its parent rather than the Create Template panel. This patch fixes that so the error is now being displayed in the create template panel. Signed-off-by: Socorro Stoppler <socorro(a)linux.vnet.ibm.com> --- ui/pages/template-add.html.tmpl | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/pages/template-add.html.tmpl b/ui/pages/template-add.html.tmpl index 670c7a2..2a8fdb7 100644 --- a/ui/pages/template-add.html.tmpl +++ b/ui/pages/template-add.html.tmpl @@ -29,6 +29,7 @@ </div> <div class="modal-body"> <div class="template-modal-container"> + <div id="alert-modal-container"></div> </div> <div class="template-pager"> <div class="page-list"> -- 2.5.0

3 2

[PATCH] [Kimchi 0/2] *** DEPENDS ON GINGERBASE NETINFO PATCH *** migrating to Gingerbase netinfo
by dhbarboza82＠gmail.com 05 May '16

05 May '16

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> This patch set adapts Kimchi source code to uses the netinfo module from Gingerbase. Daniel Henrique Barboza (2): Migration to Gingerbase netinfo: import changes Migration to Gingerbase netinfo: removing netinfo.py model/interfaces.py | 2 +- model/networks.py | 6 +- netinfo.py | 265 ---------------------------------------------------- tests/test_model.py | 2 +- 4 files changed, 5 insertions(+), 270 deletions(-) delete mode 100644 netinfo.py -- 2.5.5

3 4

[PATCH] [Kimchi] VEPA network UI: fixing network creation
by dhbarboza82＠gmail.com 05 May '16

05 May '16

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> VEPA has a multiple interface select. This wasn't being considered when assigning the value of network.interface element being used to call the network creation API. Result was an error "Interface should be bare NIC or bonding" because the backend was receiving an array of array. Signed-off-by: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> --- ui/js/src/kimchi.network_add_main.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ui/js/src/kimchi.network_add_main.js b/ui/js/src/kimchi.network_add_main.js index 99e42c1..4eb5c5b 100644 --- a/ui/js/src/kimchi.network_add_main.js +++ b/ui/js/src/kimchi.network_add_main.js @@ -35,6 +35,10 @@ kimchi.startNetworkCreation = function() { interfaces: [ network.interface ], vlan_id: network.vlan_id }; + // in VEPA connection case, network.interface is already an array + if (data.connection === kimchi.NETWORK_TYPE_VEPA) { + data.interfaces = network.interface; + } kimchi.createNetwork(data, function(result) { network.state = result.state === "active" ? "up" : "down"; -- 2.5.5

4 3

[PATCH] [Kimchi] Disable Template when it has invalid parameters
by peterpnns＠gmail.com 05 May '16

05 May '16

From: peterpennings <peterpnns(a)gmail.com> This patch adds a block behavior on the action to select invalid templates when creating a guest peterpennings (1): Disable Template when it has invalid parameters ui/css/kimchi.css | 28 ++++++++++++++++++--- ui/css/src/modules/_guests.scss | 6 +++++ ui/css/src/modules/_templates.scss | 18 +++++++++++--- ui/js/src/kimchi.guest_add_main.js | 8 ++++++ ui/js/src/kimchi.network_add_main.js | 48 +++++++++++++++++++++++++----------- ui/js/src/kimchi.template_main.js | 9 +++++-- ui/pages/guest-add.html.tmpl | 7 +++--- ui/pages/tabs/templates.html.tmpl | 6 +++-- 8 files changed, 102 insertions(+), 28 deletions(-) -- 2.5.0

2 4

[PATCH V2] [Kimchi] Remove cherrypy configuration from kimchi.conf file
by Aline Manera 05 May '16

05 May '16

This patch depends on Wok patch "[PATCH] [Wok 3/3] Add root configuration as default for PluginConfig" V1 - V2: - update tes case Aline Manera (1): Remove cherrypy configuration from kimchi.conf file kimchi.conf | 13 ------------- tests/test_config.py.in | 5 ++--- 2 files changed, 2 insertions(+), 16 deletions(-) -- 2.5.5

2 3

[PATCH] [Wok 0/3] Make session timeout configurable
by Aline Manera 05 May '16

05 May '16

Aline Manera (3): Add wok-robot header to /notifications requests Issue #19: Make session timeout configurable Add root configuration as default for PluginConfig src/wok.conf.in | 4 ++++ src/wok/auth.py | 2 +- src/wok/config.py.in | 16 +++++++++++++--- src/wokd.in | 5 +++++ tests/test_config.py.in | 2 -- ui/js/src/wok.api.js | 1 + 6 files changed, 24 insertions(+), 6 deletions(-) -- 2.5.5

3 6

[Wok][PATCH 0/7] Multi-Culture Support
by pkulkark＠linux.vnet.ibm.com 05 May '16

05 May '16

From: Pooja Kulkarni <pkulkark(a)linux.vnet.ibm.com> co-authored by: Archana Singh <archus(a)linux.vnet.ibm.com> This patch set provides multi-culture support by adding another drop down list during login for user locale selection. The numeric data and datetime fields are formatted based on the locale selected. Pooja Kulkarni (7): Multi-Culture Support - Add a separate drop down list for locale Multi-Culture support - Add methods to get and set locales in wok.lang.js Multi-Culture support - Add locale in format settings in wok.line-chart.js Multi-Culture support : Format datetime as per locale in wok.list.js Multi-Culture support : Implement new drop down list for locale in wok.login.js Multi-Culture support : Modify wok.formatMeasurement util to include formatting based on locale Multi-Culture support : Format datetime in user activity log as per locale ui/js/src/wok.lang.js | 8 ++++++++ ui/js/src/wok.line-chart.js | 3 ++- ui/js/src/wok.list.js | 4 ++++ ui/js/src/wok.login.js | 9 +++++++++ ui/js/src/wok.utils.js | 10 +++++++--- ui/js/wok.bootgrid.js | 10 +++++++++- ui/js/wok.user-log.js | 3 ++- ui/pages/login.html.tmpl | 34 ++++++++++++++++++++++++++++++++++ 8 files changed, 75 insertions(+), 6 deletions(-) -- 2.1.0

3 10

[PATCH] [Kimchi] Remove cherrypy configuration from kimchi.conf file
by Aline Manera 04 May '16

04 May '16

This patch depends on Wok patch "[PATCH] [Wok 3/3] Add root configuration as default for PluginConfig" Aline Manera (1): Remove cherrypy configuration from kimchi.conf file kimchi.conf | 13 ------------- 1 file changed, 13 deletions(-) -- 2.5.5

2 3

Wok Debian/Ubuntu integration
by Frederic Bonnard 03 May '16

03 May '16

Hi, with the new version 2.1.0 of wok/kimchi/gingerbase, I updated my packaging. I'm still having a few issues and as there is a github issue concerning having wok related projects inside Ubuntu, I'd like to share some concerns so far. Here are the details : https://github.com/kimchi-project/wok/issues/25#issuecomment-211483696 - For the "relative URLs" issue, I've got some packages done and installed. Anyone could help on fixing those ? I've got a server I can give access to a wok developer, or I can send the .deb to someone willing to install them on his machine. - For the second issue, is it worth I send an updated patch against wok, or do you see other ways of doing to disable launching a specific instance of nginx ? F.

2 1

[PATCH v2] [Kimchi] Disable Template when it has invalid parameters
by sguimaraes943＠gmail.com 03 May '16

03 May '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch adds a block behavior on the action to select invalid templates when creating a guest peterpennings (1): Disable Template when it has invalid parameters Samuel Guimarães (1): Disable Template when it has invalid parameters v2: - Removed reference to kimchi.network_add_main.js - Fixed warning icon position in list and gallery views - Remoed tooltip when template is valid - Added front-end form validation when user attempts to save invalid storage pool (must apply "Enabled .has-feedback icons" patch sent to Wok first) - Added form control error class when template has invalid cdrom (reported issue #933 for vm-image not showing in invalid key) ui/css/kimchi.css | 97 ++++++++++++++++++++++++++++++++-- ui/css/src/modules/_guests.scss | 6 +++ ui/css/src/modules/_iso-list.scss | 22 +++++++- ui/css/src/modules/_templates.scss | 53 +++++++++++++++++-- ui/js/src/kimchi.guest_add_main.js | 7 +++ ui/js/src/kimchi.template_edit_main.js | 52 ++++++++++++++---- ui/js/src/kimchi.template_main.js | 9 +++- ui/pages/guest-add.html.tmpl | 11 ++-- ui/pages/i18n.json.tmpl | 1 + ui/pages/tabs/templates.html.tmpl | 24 +++++---- ui/pages/template-edit.html.tmpl | 6 ++- 11 files changed, 255 insertions(+), 33 deletions(-) -- 1.9.3

2 3