December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: if connect storage pool fails on version mismatch, d...
by yzaslavs＠redhat.com 31 Dec '12

31 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: if connect storage pool fails on version mismatch, do reconstruct master ...................................................................... engine: if connect storage pool fails on version mismatch, do reconstruct master The following patch will allow to perform reconstruct from InitVdsOnUp, in case that we can not connect to pool because of wrong master version or missing master domain. Using of event queue will protect from parallel reconstructs and from other races. The flow is a following: 1. Try connect to pool 2. If failed on wrong master domain or its version - do reconstruct 3. If success move host to UP Please note: I remove an update of vms at spm after reconstruct, because of it will be removed at the future and that code is actually failed a one host scenario. Change-Id: Ia0d11c068399664daf85a6b03e67d25cd382707e Bug-Url: https://bugzilla.redhat.com/882837 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 9 files changed, 118 insertions(+), 40 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d11c068399664daf85a6b03e67d25cd382707e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Introducing a queue for failovers event
by yzaslavs＠redhat.com 31 Dec '12

31 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Introducing a queue for failovers event ...................................................................... engine: Introducing a queue for failovers event The following patch will introduce a queue for failovers event. The Idea is to use the follwoing queue in order to ensure a correct order of the following operations: reconstruct, domain recovery, domain monitoring, etc... The appropriate event should be submitted to queue and will be executed accorrding to internal logic of the queue. Because of the execution of events is done in a separate thread no deadlock should occurred, also no need for excplicit additional locking This is the first patch it will introduce a queue and all stuff should work as before, but using of queue with small change will allow: to reject unneeded events when some othe event is running, ensure order, ensure appropriate release of quartz threads, fix a races The following patch also introduce a using of queue, from different places, including RecoveryStoragePoolCommand Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff Bug-Url: https://bugzilla.redhat.com/882837 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RecoveryStoragePoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventQueue.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventResult.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsBroker.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 17 files changed, 538 insertions(+), 244 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0

Change in ovirt-engine[master]: tools: Change default of use_dns_lookup to true
by yzaslavs＠redhat.com 31 Dec '12

31 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Change default of use_dns_lookup to true ...................................................................... tools: Change default of use_dns_lookup to true Chagning default of this flag to true, as part of the bz handling Change-Id: Ia56ff4afac11803ac0753dbf88fcfbfd24e2e565 Bug-Url: https://bugzilla.redhat.com/868852 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/resources/engine-manage-domains.conf 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia56ff4afac11803ac0753dbf88fcfbfd24e2e565 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ReconstructMasterDomain -connect/disconnect hosts simu...
by tnisan＠redhat.com 31 Dec '12

31 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: core: ReconstructMasterDomain -connect/disconnect hosts simultaneously ...................................................................... core: ReconstructMasterDomain -connect/disconnect hosts simultaneously When running ReconstructMasterDomain/RecoveryStoragePool commands - any connect/disconnect operations can be done simultaneously by different threads in order to improve the runtime. There's no need to make use here of the runSynchronizeOperation() , it will require to add few classes, handle with parameter passing when this flow is relevant to the Reconstruct flow, in many places in the code we execute runnables using ThreadPoolUtils class so I prefer to keep the implementation simple rather then complicate it and add classes that will be never used again just to use CountDownLatch. Change-Id: I3c8dac368d60eac85a92762dffc5dbb8062b85ef Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 52 insertions(+), 39 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c8dac368d60eac85a92762dffc5dbb8062b85ef Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add executor for execution of runnables with CountDown...
by tnisan＠redhat.com 31 Dec '12

31 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: core: add executor for execution of runnables with CountDownLatch ...................................................................... core: add executor for execution of runnables with CountDownLatch This patch adds LatchedRunnableExecuter to be able to execute LatchedRunnableWrapper (pre existing class) instances using CountDownLatch. 1. LatchedRunnableExecuter basically could have been implemented as class whose instances cannot be created and with static methods only - it's has been implemented like this in order to provide proper testing (creating instances of it is rare, so it shouldn't matter in terms of garbage collection), a singleton isn't used as well as it's being used only from Reconstruct flow which is rare, so I prefer to create instance when needed instead of having permanent instance of it. 2. Handle of rejected submission of runnables was removed last patch because its abnormal situation that we shouldn't reach at all in that case according to infra so there's no need to submit runnable again if it failed. 3. Handle of InterruptedException : right now it's caught only as it's being taken care of in other places in the code. Change-Id: Ia56ff4afac01803ac0753dbf88fcfbfd34e2e56d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/thread/LatchedRunnableExecutor.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/thread/LatchedRunnableWrapperTest.java 2 files changed, 167 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia56ff4afac01803ac0753dbf88fcfbfd34e2e56d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: perform connectStorageServer to hosts after during reconstru...
by tnisan＠redhat.com 31 Dec '12

31 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: perform connectStorageServer to hosts after during reconstruct/recovery(#880180) ...................................................................... perform connectStorageServer to hosts after during reconstruct/recovery(#880180) When performing reconstruct/reinitialize DC, a copy of the pool metadata is being done to a data domain, if hosts doesn't have the needed 'connections' to the new master storage server they will move eventually to non-operational state. This patch adds execution of connectStorageServer to all hosts other then the host that executed the reconstruct/recovery (as this host managed to perform reconstruct successfully, it means that he has the needed 'connections' to the storage server). Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=880180 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: User queries improvements
by yzaslavs＠redhat.com 31 Dec '12

31 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: User queries improvements ...................................................................... engine: User queries improvements The following patch contains two improvements: 1. Removed unneeded calls to some functions at permissions_view, by creating the internal_permissions_view - permissions_view should be used for UI purposes , for engine/internal permission check, internal_permissions_view should be used. 2. Introduction of new splitter function. Bug-Url: https://bugzilla.redhat.com/880969 Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/multi_level_administration_sp.sql M backend/manager/dbscripts/storages_sp.sql M backend/manager/dbscripts/tags_sp.sql M backend/manager/dbscripts/tags_vm_pool_map_sp.sql M backend/manager/dbscripts/user_sp.sql M backend/manager/dbscripts/vms_sp.sql 9 files changed, 87 insertions(+), 152 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: add GetGuestAgentQueryExpectations to the missed te...
by alkaplan＠redhat.com 31 Dec '12

31 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: add GetGuestAgentQueryExpectations to the missed tests ...................................................................... restapi: add GetGuestAgentQueryExpectations to the missed tests setGetGuestAgentQueryExpectations was missing in some of the new tests. Change-Id: I7556528a2cd1cc85c550dc9418a97335f2b90633 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7556528a2cd1cc85c550dc9418a97335f2b90633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: create db fails on rhel 6.4 using postgres..
by emesika＠redhat.com 31 Dec '12

31 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core: create db fails on rhel 6.4 using postgres.. ...................................................................... core: create db fails on rhel 6.4 using postgres.. create db fails on rhel 6.4 using postgresql-8.4.13-1.el6_3.x86_64 This patch fix a failure on postgres 8.4 that fails to update a parameter to a SP on postgres 8.4 while the same modification is OK for postgres 9.x. The solution uses a local SO variable to do the modifications and be used later on on the INSERT statement. This patch also modified the message data type to be text and not varchar(4000) to match the audit_table definitions. Change-Id: I4451f5bdf118efc02bb9100c59e0729283c4c2b5 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=890982 --- M backend/manager/dbscripts/audit_log_sp.sql 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4451f5bdf118efc02bb9100c59e0729283c4c2b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix error message when exporting to a non export domai...
by tnisan＠redhat.com 31 Dec '12

31 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error message when exporting to a non export domain ...................................................................... core: Fix error message when exporting to a non export domain Change-Id: Iffe15389360d6233655056dcfd94880f8033b741 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe15389360d6233655056dcfd94880f8033b741 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0