Change in ovirt-engine[master]: Revert "core: VdsSelector simplification"
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: Revert "core: VdsSelector simplification"
......................................................................
Revert "core: VdsSelector simplification"
This reverts commit 959292e26073a642f17c0183e28ff748e7fcda83.
By examining ListUtils' and TransformedList documentation, it appears as
though objects ALREADY in a list are not transformed, therefore this
patch is faulty, and causes a regression so it's impossible to run a VM.
Change-Id: Ie862a9425c43ee093325836da3dff66d161168b5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
1 file changed, 14 insertions(+), 16 deletions(-)
Approvals:
Allon Mureinik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie862a9425c43ee093325836da3dff66d161168b5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Fix the location of the engine.conf file
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix the location of the engine.conf file
......................................................................
core: Fix the location of the engine.conf file
The code tries to use /etc/engine/engine.conf but the file is
located in /etc/ovirt-engine/engine.conf, so the engine is always
using the defaults, regardless of what is the content of the file.
Change-Id: I43169199ef5bd17f495767b209184b49e5f6c7e9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43169199ef5bd17f495767b209184b49e5f6c7e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core:vm migration in case of failure ...(#818289)
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:vm migration in case of failure ...(#818289)
......................................................................
core:vm migration in case of failure ...(#818289)
vm migration in case of failure is not logged in task manager
https://bugzilla.redhat.com/show_bug.cgi?id=818289
When we have Host A and Host B where Host A is SPM and we have HA VM
running on Host A, if Host A is going to non-operational (can not access
the storage for example) the HA VM will be migrated to Host B and Host B
will become the SPM but we will not see the Migration under the
SetNonOperational job.
The reason is that the SetNonOperational ExceutionContext is not passed
to MigrateAllVms method in order to use this context as the parent job
context and to associate all migration steps with the SetNonOperational
job.
This patch changes the MigrateAllVms call to pass the parent
SetNonOperational job ExceutionContext, this context is used as the
parent ExceutionContext when migration steps are created for each VM.
Change-Id: I437893ccf373af863810696d14ce8fd1ffb0253b
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
3 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I437893ccf373af863810696d14ce8fd1ffb0253b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Fixing canDoAction of DeactiveStorageDomainCommand
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing canDoAction of DeactiveStorageDomainCommand
......................................................................
core: Fixing canDoAction of DeactiveStorageDomainCommand
With this fix - tasks are associated with their entities, there is no need to query
VDSM for HSM task statuses.
This both saves network communication, and in addition, the VDSM call does not provide
any information on the storage domain, so using it allows only to check if the data
center has running tasks.
With the fix, a query to db to check if the storage domain is associated with
tasks replaces the described above VDSM call.
Change-Id: Ic5841d558a7a5267a67cc9547bac187f9773b87b
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 10 insertions(+), 23 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5841d558a7a5267a67cc9547bac187f9773b87b
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: Associating tasks to storage domains
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Associating tasks to storage domains
......................................................................
Associating tasks to storage domains
The following patch associates storage domains to task ID
during task persistence due to task creation.
Change-Id: I879ff98fdb61ff0da180136fad305bf825d1858d
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
11 files changed, 54 insertions(+), 16 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I879ff98fdb61ff0da180136fad305bf825d1858d
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Refactoring AsyncTaskManager
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Refactoring AsyncTaskManager
......................................................................
core: Refactoring AsyncTaskManager
This patch performs the following refactors:
a. Refactors createTask to return an SPMAsyncTask object (SPMAsyncTask is the base class for tasks)
and not the task Id (guid).
b. Takes out DB related code from the CTOR of SPMAsyncTask.
c. Introduces AsyncTaskUtils to hold some common logic for async tasks
d. Introduces entity IDs and entity type to SPMAsyncTask in order to store entity association with tasks
Change-Id: Ia820fd378331b1360cb2766feda80d8c2878310e
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
20 files changed, 338 insertions(+), 159 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia820fd378331b1360cb2766feda80d8c2878310e
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: db changes to add association between tasks and entiti...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: db changes to add association between tasks and entities
......................................................................
core: db changes to add association between tasks and entities
This patch is the beginning of entity association to
tasks that relate to it.
The patch introduces the table asyc_task_entities that holds in
each record ID of async task, ID of entity ID and the type of the entity.
It adds a psql function, used by AsyncTaskDao, to get all taskIDs for a
given entity.
Change-Id: I7a711e932ffb7bcc6920a3456ac97f8b8fc18a76
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/dbscripts/async_tasks_sp.sql
A backend/manager/dbscripts/upgrade/03_01_1280_add_async_task_entities_table.sql
2 files changed, 37 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5994
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a711e932ffb7bcc6920a3456ac97f8b8fc18a76
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: Removing Logger from CustomFieldSerializer
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Removing Logger from CustomFieldSerializer
......................................................................
webadmin: Removing Logger from CustomFieldSerializer
Removing 'java.util.logging.Logger' from
'VdcQueryReturnValue_CustomFieldSerializer'
(causes serialization problems).
Change-Id: Ie2cbaf2cd60d464aa5e2adaec046f5a6b5d71748
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2cbaf2cd60d464aa5e2adaec046f5a6b5d71748
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-log-collector[master]: tools: More information in time_diff file
by kroberts＠redhat.com
Keith Robertson has submitted this change and it was merged.
Change subject: tools: More information in time_diff file
......................................................................
tools: More information in time_diff file
Add a header to time_diff.txt, the time of the node
in ISO8601 format, the time of the engine in ISO8601 format,
and the drift seen between the node and the engine.
Change-Id: Iedac60d0dbefb99c610892ea616c996a7c9dce62
Signed-off-by: Keith Robertson <kroberts(a)redhat.com>
---
M ovirt-log-collector.spec.in
M src/rhev/logcollector.py
2 files changed, 24 insertions(+), 8 deletions(-)
Approvals:
Keith Robertson: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedac60d0dbefb99c610892ea616c996a7c9dce62
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months
Change in ovirt-log-collector[master]: tools: Collect memory info from engine and HV
by kroberts＠redhat.com
Keith Robertson has submitted this change and it was merged.
Change subject: tools: Collect memory info from engine and HV
......................................................................
tools: Collect memory info from engine and HV
Launch the SoS plugin that collects system
memory information when gathering data from
the engine and from the hypervisors.
Change-Id: Id61ef6a856f74e0f28d5537443d789b8ac4ce837
Signed-off-by: Keith Robertson <kroberts(a)redhat.com>
---
M src/rhev/logcollector.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Keith Robertson: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5755
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id61ef6a856f74e0f28d5537443d789b8ac4ce837
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months