Change in ovirt-log-collector[master]: tools: Collect HTTPD logs (#808882)
by kroberts@redhat.com
Keith Robertson has submitted this change and it was merged.
Change subject: tools: Collect HTTPD logs (#808882)
......................................................................
tools: Collect HTTPD logs (#808882)
https://bugzilla.redhat.com/808882
Collect all HTTPd log and conf files.
Change-Id: I34b04827e2a53867a19ed33f0abca3ab7db57089
Signed-off-by: Keith Robertson <kroberts(a)redhat.com>
---
M src/rhev/logcollector.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Keith Robertson: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34b04827e2a53867a19ed33f0abca3ab7db57089
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: tools: engine-config bug fixes
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: engine-config bug fixes
......................................................................
tools: engine-config bug fixes
1. password file can be set via -s option
2. delete created temp file
3. add help description to engine-config script file
4. Fixed chmod path retrieval
Change-Id: Iae961ccb45fb43ebbe8f01e51d2262540ed338a9
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java
1 file changed, 15 insertions(+), 9 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae961ccb45fb43ebbe8f01e51d2262540ed338a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Fixing CompositePasswordValueHelper
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing CompositePasswordValueHelper
......................................................................
core: Fixing CompositePasswordValueHelper
CompositePasswordValueHelper should support --admin-pass-file as well
Change-Id: Ia75fb5e5a21f24ef87bf2c940d5f95d6e64c4f0a
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
2 files changed, 19 insertions(+), 9 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia75fb5e5a21f24ef87bf2c940d5f95d6e64c4f0a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: cleanup AddVmCommand.areParametersLegal
by lhornyak@redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: cleanup AddVmCommand.areParametersLegal
......................................................................
core: cleanup AddVmCommand.areParametersLegal
Simplification of the decision logic.
Change-Id: Ifd22b88e602cf9ee34be948286520dcf4f97fb84
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 21 insertions(+), 24 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd22b88e602cf9ee34be948286520dcf4f97fb84
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: tools: engine-config bug fixes
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: tools: engine-config bug fixes
......................................................................
tools: engine-config bug fixes
1. password file can be set via -s option
2. delete created temp file
3. add help description to engine-config script file
4. ignore case when checking for "interactive" mode
Change-Id: I3003f20a51bb5a62387593d914894d62b012c70b
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
M backend/manager/tools/engine-config/src/main/resources/engine-config
3 files changed, 53 insertions(+), 13 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3003f20a51bb5a62387593d914894d62b012c70b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: lowering log level of repetitive messages
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: lowering log level of repetitive messages
......................................................................
webadmin: lowering log level of repetitive messages
* Lowering messages log level to FINE for reducing clutter.
* Logger level can be adjusted in '.gwt.xml' files
(gwt.logging.logLevel property).
Change-Id: Ia665d2a0f0299e67ae743fce72226b151785d217
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/TimerFactory.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimer.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
6 files changed, 27 insertions(+), 19 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia665d2a0f0299e67ae743fce72226b151785d217
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: Disks - adding tool-tips to icon columns
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks - adding tool-tips to icon columns
......................................................................
webadmin: Disks - adding tool-tips to icon columns
Adding tool-tips to icon columns:
VM/Template, bootable, shareable and LUN.
Change-Id: Ifac85e2ddc881a44f2cc75380e57f8646a46f87e
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifac85e2ddc881a44f2cc75380e57f8646a46f87e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: adding support for ImageCell tool-tip
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adding support for ImageCell tool-tip
......................................................................
webadmin: adding support for ImageCell tool-tip
ImageResourceColumn:
* setTitle - adds a tool-tip by a string
* setEnumTitle - adds a tool-tip by a enum object
(trying to apply translation).
Change-Id: I342cb752edf1537f5284e805347f1a68f7415e6c
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ImageResourceColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java
2 files changed, 31 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I342cb752edf1537f5284e805347f1a68f7415e6c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine:Validate if disk plugged on detach.(#838960)
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine:Validate if disk plugged on detach.(#838960)
......................................................................
engine:Validate if disk plugged on detach.(#838960)
If disk is already deactivate from VM, there is no need to deactivate it
again when trying to detach it from VM.
In the proposed solution I re-factor the condition to be in a separate
method, and also validate that the disk is not already detached from the
VM.
Change-Id: I681a6feb7e7cbf010d7c37453efe1ccab40af98e
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6152
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I681a6feb7e7cbf010d7c37453efe1ccab40af98e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 4 months
Change in ovirt-dwh[master]: packaging: updated setup to use correct DB name.
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: updated setup to use correct DB name.
......................................................................
packaging: updated setup to use correct DB name.
Updated setup to use ovirt_engine_history db name
instead of ovirt_history
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
Change-Id: I56fba6531d3dc70d8329d6a3af5a8fed050b414b
---
M packaging/ovirt-engine-dwh-setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56fba6531d3dc70d8329d6a3af5a8fed050b414b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
12 years, 4 months