Change in ovirt-engine[master]: engine: Change iteration to foreach (#849971)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Change iteration to foreach (#849971)
......................................................................
engine: Change iteration to foreach (#849971)
https://bugzilla.redhat.com/849971
Iterate using foreach instead of LinqUtils.
This way the loop can be extended to do other things as well, besides
finding a single element.
Change-Id: I2fbb9bf14ed5f94b2e74ab6bfde39e959300b31d
Signed-off-by: Mike …
[View More]Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fbb9bf14ed5f94b2e74ab6bfde39e959300b31d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine[master]: core: Add message that more than one network attached (#8499...
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add message that more than one network attached (#849971)
......................................................................
core: Add message that more than one network attached (#849971)
https://bugzilla.redhat.com/849971
The message is necessary to stop actions (such as update network on
interfaces) where there is more than one network attached, where there
is no support for such a situation.
Change-Id:…
[View More] I22a75bb644367921a7ef69d44cd3316e7f9f8fb0
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22a75bb644367921a7ef69d44cd3316e7f9f8fb0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine[master]: engine: Use interfaceBasedOn where appropriate (#849971)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Use interfaceBasedOn where appropriate (#849971)
......................................................................
engine: Use interfaceBasedOn where appropriate (#849971)
https://bugzilla.redhat.com/849971
Use the new interfaceBasedOn method where it is appropriate.
Change-Id: I5698cf5e76aaac20e84f4283165d13406b1f981c
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/…
[View More]modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllChildVlanInterfacesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVlanParanetQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
5 files changed, 7 insertions(+), 12 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5698cf5e76aaac20e84f4283165d13406b1f981c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine[master]: core: Add interfaceBasedOn method (#849971)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add interfaceBasedOn method (#849971)
......................................................................
core: Add interfaceBasedOn method (#849971)
https://bugzilla.redhat.com/849971
This method will be used to identify if a proposed VLAN if in fact a
VLAN of the given interface or the interface, or is it an unrelated
interface.
Change-Id: Ic479acc3179622b60efe921522dcb2115838557f
Signed-off-by: Mike …
[View More]Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
2 files changed, 53 insertions(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic479acc3179622b60efe921522dcb2115838557f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine[master]: core: Add lock to a disk in attach to VM command (#834888)
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add lock to a disk in attach to VM command (#834888)
......................................................................
core: Add lock to a disk in attach to VM command (#834888)
https://bugzilla.redhat.com/834888
Added lock to the disk entity when attaching a disk to a VM in
case the disk is not shareable, also added a validation to the cando
action in case when the disk is not shareable and already attached …
[View More]to
another VM, for some reason this was not checked and the only thing
blocking from attaching a non shareable disk to multiple VM was the UI
Change-Id: Ib9e47fe370b230b4bd69f108954031cda3bba6a3
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 21 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9e47fe370b230b4bd69f108954031cda3bba6a3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine[master]: core: Usage as Lowercase and in Caps (#817798)
by msalem@redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Usage as Lowercase and in Caps (#817798)
......................................................................
core: Usage as Lowercase and in Caps (#817798)
https://bugzilla.redhat.com/817798
This patch changes the mapping of Network to
display the usage property in lowercase. Also,
it adds the property to /capabilities.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: …
[View More]Ia806eff46e1a8982a2cc4e7de485ea2c8b07c953
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
4 files changed, 18 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia806eff46e1a8982a2cc4e7de485ea2c8b07c953
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine[master]: restapi: SetupNetworks missing action link #806916
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: SetupNetworks missing action link #806916
......................................................................
restapi: SetupNetworks missing action link #806916
This patch adds generic support for actionin links
generation under collection context
https://bugzilla.redhat.com/show_bug.cgi?id=806916
Change-Id: Iea197cc0c6219061a3b83b5aa8fccbf18de29802
Signed-off-by: Michael Pasternak <mpastern(a)…
[View More]redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ActionsBuilder.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ArrayUtils.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java
8 files changed, 140 insertions(+), 28 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7461
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea197cc0c6219061a3b83b5aa8fccbf18de29802
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine-cli[master]: cli: implement /filter flag
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement /filter flag
......................................................................
cli: implement /filter flag
sdk resource /api invoked on /connect has few queries (such as
GetSystemStatistics, etc.) which require admin permissions, raising
/filter flag will signal to turn on permission based filtering and
not call this queries what will allow non-admin users connecting to
the shell.
Change-Id: …
[View More]Ic9c7671d8f779a343257ecfba3d3dfe5df630dfa
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/connect.py
M src/ovirtcli/options.py
M src/ovirtcli/settings.py
M src/ovirtcli/shell/connectcmdshell.py
4 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9c7671d8f779a343257ecfba3d3dfe5df630dfa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
[View Less]
12 years, 7 months
Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: rebase to latest api
......................................................................
sdk: rebase to latest api
- added create/update/delete methods to template.nics
- brokers module classes been reordered due to links
sorting in latest RSDL
Change-Id: I53a813c75eb236bdd873723be5ad23ee033218c1
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtsdk/infrastructure/brokers.py
…
[View More]1 file changed, 511 insertions(+), 464 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53a813c75eb236bdd873723be5ad23ee033218c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months
Change in ovirt-engine-sdk[master]: sdk: clean context on disconnect
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: clean context on disconnect
......................................................................
sdk: clean context on disconnect
Change-Id: Ic1f8f8b035cd68cf411ae7f0802827d62cc6e537
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/entrypoint/entrypoint.py
M src/ovirtsdk/api.py
M src/ovirtsdk/infrastructure/contextmanager.py
3 files changed, 20 insertions(+), 9 deletions(-)
…
[View More]Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1f8f8b035cd68cf411ae7f0802827d62cc6e537
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
12 years, 7 months