Change in ovirt-engine[master]: utils: ForwardServlet: fix generic forward to use path info
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: utils: ForwardServlet: fix generic forward to use path info
......................................................................
utils: ForwardServlet: fix generic forward to use path info
requestURI is no good as we may need to forward into different uris.
cleanup serlvet initialization.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677
Change-Id: I7307d57792fb966c8acb6ac0bdcad9302c0e3a65
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java
2 files changed, 17 insertions(+), 20 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7307d57792fb966c8acb6ac0bdcad9302c0e3a65
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: rearrange product uris
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: core: rearrange product uris
......................................................................
core: rearrange product uris
MISSION
Advanced farther into well behaved web application, install as much as
we can into /ovirt-engine URI name space, removing / abuse.
Synchronize between jboss and apache URI layouts so that development
setup will be as similar as possible to production.
NEW LAYOUT
-+- / (root.war) Redirect: ovirt-engine
|
+--- api/ (api.war)
|
+-+- ovirt-engine/ (welcome.war) [NEW]
| |
| +--- docs/ (docs.war) [NEW]
| |
| +-+- services(services.war) [NEW]
| | |
| | +-+- attachment/
| | |
| | +-+- files/
| | |
| | +--- get-session-user
| | |
| | +--- health
| | |
| | +--- host-register
| | |
| | +--- pki-resource
| | |
| | +--- reports-redirect
| |
| +--- userportal/ (userportal.war)
| |
| +--- webadmin/ (webadmin.war)
|
+-+- OvirtEngineWeb/
| |
| +--- HealthStatus.aspx Forward: ovirt-engine/services/health
| |
| +--- HealthStatus/* Forward: ovirt-engine/services/health
| |
| +--- VdsAutoRegistration.aspx Forward: ovirt-engine/services/host-register
| |
| +--- register Forward: ovirt-engine/services/host-register
|
+-+- RHEVManagerWeb/
| |
| +--- VdsAutoRegistration.aspx Forward: ovirt-engine/services/host-register
|
+--- ca.crt Forward: ovirt-engine/serivces/pki-resource
|
+--- engine.ssh.key.txt Forward: ovirt-engine/serivces/pki-resource
|
+--- rhevm.ssh.key.txt Forward: ovirt-engine/serivces/pki-resource
LAYOUT NOTES
HealthStatus servlet is used by python using urllib2 which supports
redirect, it does not accept extra path, so it is redirected into
servlet at services.
Registration uses python httplib which does not support redirect, so
these uris are forwarded into servlets at services.
/ValidateSession is gone as reports can be modified to support the new
servlet name at /services/get-session-user.
GWT NOTES
- Generate GWT files in-place so that application name is user friendly
and there is no extra nesting, so we end up with:
/ovirt-engine/webadmin
/ovirt-engine/userportal
- Added client side BaseContextPathData class to read base context path
from host page.
CONFIGURATION
ENGINE_URI was added to be able to configure URI at runtime, jboss
upstream has some bugs regarding variable substitution within resources,
once this is resolved we can have fully configured URI.
Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677
Signed-off-by: Alexander Wels <awels(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
A backend/manager/modules/docs/exclude-filters.xml
A backend/manager/modules/docs/pom.xml
A backend/manager/modules/docs/src/main/resources/META-INF/MANIFEST.MF
R backend/manager/modules/docs/src/main/resources/messages.properties
R backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp
A backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/pom.xml
D backend/manager/modules/root/exclude-filters.xml
M backend/manager/modules/root/pom.xml
D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java
M backend/manager/modules/root/src/main/resources/META-INF/MANIFEST.MF
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
A backend/manager/modules/services/exclude-filters.xml
A backend/manager/modules/services/pom.xml
R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAttachmentServlet.java
R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java
R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/HealthStatus.java
A backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java
R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ReportsRedirectServlet.java
A backend/manager/modules/services/src/main/resources/META-INF/MANIFEST.MF
A backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
R backend/manager/modules/services/src/main/webapp/novnc-main.html
R backend/manager/modules/services/src/main/webapp/spicehtml5-main.html
M backend/manager/modules/utils/exclude-filters.xml
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/DocsServlet.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/FileServlet.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/PageNotFoundForwardServlet.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/DocsServletTest.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/FileServletTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java
R backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/filetest/en-US/index.html
R backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/filetest/fr/index.html
R backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/filetest/index.html
A backend/manager/modules/welcome/pom.xml
R backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
A backend/manager/modules/welcome/src/main/resources/META-INF/MANIFEST.MF
A backend/manager/modules/welcome/src/main/resources/messages.properties
R backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp
R backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
A backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml
R backend/manager/modules/welcome/src/main/webapp/splash.js
R backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
M ear/pom.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServlet.java
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/BaseContextPathData.java
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
D frontend/webadmin/modules/userportal-gwtp/src/main/webapp/index.html
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
D frontend/webadmin/modules/webadmin/src/main/webapp/index.html
M ovirt-engine.spec.in
M packaging/branding/ovirt.brand/welcome_page.template
M packaging/conf/ovirt-engine-proxy.conf.v2.in
M packaging/services/ovirt-engine/ovirt-engine.conf.in
70 files changed, 1,283 insertions(+), 629 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: rename fence methods to start with lowercase.
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: rename fence methods to start with lowercase.
......................................................................
core: rename fence methods to start with lowercase.
Cleans some findbugs warnings.
Change-Id: I0efff7949a568367a5c40507d19fd26b2e233c21
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
5 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0efff7949a568367a5c40507d19fd26b2e233c21
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: core+ui: Support lowering cluster CPU level
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core+ui: Support lowering cluster CPU level
......................................................................
core+ui: Support lowering cluster CPU level
This patch removes the validation of not lowering down the cluster CPU
level while VMs are running. A proper warning and confirmation window is
displayed instead.
Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c
Bug-Url: https://bugzilla.redhat.com/1006209
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfActiveVmsInVdsGroupByVdsGroupIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 119 insertions(+), 13 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: webadmin: Remove NICs from VM Guide Me
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Remove NICs from VM Guide Me
......................................................................
webadmin: Remove NICs from VM Guide Me
Since virtual network interfaces can now be added in the add VM dialog
itself, there's no longer need for them to take part in the following
Guide Me flow.
Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b
Bug-Url: https://bugzilla.redhat.com/1024249
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideDiskModel.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideVmInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
4 files changed, 11 insertions(+), 184 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-log-collector[ovirt-log-collector-3.3]: Use max=1000 option return results when calling the oVirt API.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Use max=1000 option return results when calling the oVirt API.
......................................................................
Use max=1000 option return results when calling the oVirt API.
When calling the API the LC does not provide a max value, limiting
the results to 100 by default. For environments with 100+ DCs,
Clusters or hosts this leads to incomplete LCs being collected.
This change introduces the max=1000 option to each .list() call to allow
a greater number of results to be returned.
Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34
Bug-Url: https://bugzilla.redhat.com/1014379
Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .gitignore
M src/helper/hypervisors.py
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-log-collector[master]: Use max=1000 option return results when calling the oVirt API.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Use max=1000 option return results when calling the oVirt API.
......................................................................
Use max=1000 option return results when calling the oVirt API.
When calling the API the LC does not provide a max value, limiting
the results to 100 by default. For environments with 100+ DCs,
Clusters or hosts this leads to incomplete LCs being collected.
This change introduces the max=1000 option to each .list() call to allow
a greater number of results to be returned.
Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34
Bug-Url: https://bugzilla.redhat.com/1014379
Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .gitignore
M src/helper/hypervisors.py
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
humble devassy: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/19759
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: engine, frontend: localize snapshot type on FE
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine,frontend: localize snapshot type on FE
......................................................................
engine,frontend: localize snapshot type on FE
The problem was that the "Activet VM before preview" and "Active VM" Strings
were hardcoded in the backend and written to the DB as a description. The
problem with this was that the strings were taken on the frontend "as is"
and were not localized.
This patch localizes this strings on FE but leaves tham on BE to provide them
to REST.
Change-Id: I26866fd4dd91d034e7ae5afee054080a4ab864a1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1010122
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/snapshot/SnapshotsViewColumns.java
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26866fd4dd91d034e7ae5afee054080a4ab864a1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: restapi: Add "permissions" sub-collections to vnic profiles
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: Add "permissions" sub-collections to vnic profiles
......................................................................
restapi: Add "permissions" sub-collections to vnic profiles
The "permissions" sub-collections is added to vnic profiles
under the networks top collection:
api/networks/{network:id}/vnicprofiles
api/networks/{network:id}/vnicprofiles/{profile:id}/permissions
api/networks/{network:id}/vnicprofiles/{profile:id}/permissions/{permission:id}
Change-Id: I02573ec87a40c7e017a24f334083044b051613ac
Bug-Url: https://bugzilla.redhat.com/1014985
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedVnicProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResource.java
7 files changed, 30 insertions(+), 19 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02573ec87a40c7e017a24f334083044b051613ac
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: restapi: Fix incorrect api description
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: Fix incorrect api description
......................................................................
restapi: Fix incorrect api description
The permissions delete api of vnic profile is fixed
to describe the action correctly.
Change-Id: I87c11586ff2b89c034884a0559703d31922ac122
Bug-Url: https://bugzilla.redhat.com/1022433
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87c11586ff2b89c034884a0559703d31922ac122
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 1 month