October 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: tools: Utilze SENSITIVE_KEYS to prevent logging of notifier'...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: tools: Utilze SENSITIVE_KEYS to prevent logging of notifier's MAIL_PASSWORD ...................................................................... tools: Utilze SENSITIVE_KEYS to prevent logging of notifier's MAIL_PASSWORD Change-Id: Ic15eccae95c7d30667a9fefe0c6a43188887ad99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020871 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15eccae95c7d30667a9fefe0c6a43188887ad99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: NPE in Import*Model

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: frontend: NPE in Import*Model ...................................................................... frontend: NPE in Import*Model There was a NPE vulnerability in ImportTemplateModel and ImportVmModel. The problem was that the VmBackupModel.restore() called first the setItems() and than init(). The setItems have done some async call and set the result to the super.setItems(), while the init() already needed this in initDisksStorageDomainsList() method (which is also called in a callback). So if the callback from setItems returned sooner than the ones in init() it worked. If not, the initDisksStorageDomainsList failed on NPE. Fixed by calling the real init() logic only when the data are really prepared. Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019862 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 3 files changed, 68 insertions(+), 63 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Set uniform width to vNIC entries

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Set uniform width to vNIC entries ...................................................................... webadmin: Set uniform width to vNIC entries Added a set width for the vNIC entries in the add/edit VM dialog, to avoid longer vNIC names indenting the other UI fields. Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6 Bug-Url: https://bugzilla.redhat.com/1023035 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Remove duplicate properties of VmTemplate

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Remove duplicate properties of VmTemplate ...................................................................... engine: Remove duplicate properties of VmTemplate Remove fields interfaces and diskList with corresponding accessor methods duplicitly declared on VmTemplate while being inherited from VmBase with no additional logic except for overriding said accessor methods to the same implementation. Change-Id: I765da987d21ddf7153715322be9b9156b2a0ddca Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 2 files changed, 7 insertions(+), 31 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I765da987d21ddf7153715322be9b9156b2a0ddca Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fail import vm if mac addresses are missing

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fail import vm if mac addresses are missing ...................................................................... engine: Fail import vm if mac addresses are missing When a vm is imported as new entity, there is a mac allocation for any imported vnic. If the mac addresses pool has insufficient addresses, the action fails during the execution. The patch fails the operation on can-do-action with a proper message to the user for the failure reason. Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Bug-Url: https://bugzilla.redhat.com/1008168 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: update admin user password prompt

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: update admin user password prompt ...................................................................... packaging: setup: update admin user password prompt Change-Id: I8a018455accb52d70938d89a5f59eddc21d3effc Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a018455accb52d70938d89a5f59eddc21d3effc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Don't display DCs that imported external network

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Don't display DCs that imported external network ...................................................................... webadmin: Don't display DCs that imported external network Changed the import networks dialog so that the choice of DC to import an external network to, will only include DCs where the network doesn't exist yet. This required modification of the backend query to not only retrieve all the external networks that exist on a provider, but also map each network to the set of DCs where that network had already been imported. This set is then used to efficiently check whether a certain external network had been imported to a certain DC. Change-Id: Ifd76b527500957ec47db6d60894b0d7316d17058 Bug-Url: https://bugzilla.redhat.com/989909 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQueryTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/03_04_0070_index_network_by_external_id.sql 12 files changed, 136 insertions(+), 18 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd76b527500957ec47db6d60894b0d7316d17058 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Allow different options for different entries

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Allow different options for different entries ...................................................................... webadmin: Allow different options for different entries ListModelListBoxCell used to have one set of options for all of the entries. Now it only sets the options in the last minute, when a specific entry is rendered, according to the items in the ListModel backing the specific entry, which enables to have different options for different entries. Change-Id: I703ab631ef959fa3ca3ad5bb6dd878634993a3b2 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 4 files changed, 8 insertions(+), 44 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I703ab631ef959fa3ca3ad5bb6dd878634993a3b2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: fix parameters order in ReconstructMasterParameters

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: fix parameters order in ReconstructMasterParameters ...................................................................... core: fix parameters order in ReconstructMasterParameters in change I752c8065ee15faaeb6ffd41909d349297b8a3a58 the wrong patchset was merged without the changes done in a further patchset(#1 instead of #2) This change applies those changes. This is related to change I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9 which was merged incomplete Change-Id: Ie3b3445537d8fcaf3efe99803dae91b9ff993743 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3b3445537d8fcaf3efe99803dae91b9ff993743 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: Remove duplicate read of TimeZone in OvfVmReader

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: backend: Remove duplicate read of TimeZone in OvfVmReader ...................................................................... backend: Remove duplicate read of TimeZone in OvfVmReader Removed duplicate read of TimeZone ovf-field which was not sanitized against empty strings causing creation of Vm with invalid timezone "" (correctly should be normalized to null). Also removed the temporary fix in TimeZoneValidator since now all cases should be covered and the empty string time-zone always normalized to null. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015049 Change-Id: I9152bc347a5358ca794ee8c237e4486f444862ee Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/TimeZoneValidator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9152bc347a5358ca794ee8c237e4486f444862ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2013