Change in ovirt-engine[master]: core: revert the addition of linux windows os
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: revert the addition of linux windows os
......................................................................
core: revert the addition of linux windows os
commit I09d817323c8b6a7d2ca02c29c200dc4507d6b94c mistakenly added those
oss back to osinfo props.
Change-Id: Ia09156e21e17f853aee37fe15d70a52d028211ca
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20583
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia09156e21e17f853aee37fe15d70a52d028211ca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Disk hotplug validation - Patch 1 of 2
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Disk hotplug validation - Patch 1 of 2
......................................................................
core: Disk hotplug validation - Patch 1 of 2
In the method isInterfaceSupportedForPlugUnPlug a hard-coded validation
was replaced by information from the osinfo file.
Change-Id: Ic2e4c792b607429daf077c11820b43f171d376b7
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
M packaging/conf/osinfo-defaults.properties
9 files changed, 87 insertions(+), 5 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19601
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2e4c792b607429daf077c11820b43f171d376b7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: host-deploy: output stderr content as error in audit log
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: host-deploy: output stderr content as error in audit log
......................................................................
host-deploy: output stderr content as error in audit log
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021222
Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
2 files changed, 16 insertions(+), 7 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: engine: Copying a quota drops consumers and permissions
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Copying a quota drops consumers and permissions
......................................................................
engine: Copying a quota drops consumers and permissions
Add a option to copy consumers and permissions while cloning
a Quota.
A check box (copy consumers and permissions) added to clone quota
dialog.
Change-Id: Ide6f9ded5c19d16f7b4c7e373df9664e59fb1419
Bug-Url: https://bugzilla.redhat.com/908835
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/QuotaCRUDParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml
7 files changed, 91 insertions(+), 5 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide6f9ded5c19d16f7b4c7e373df9664e59fb1419
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Remove advanced parameters from vNIC dialog
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Remove advanced parameters from vNIC dialog
......................................................................
webadmin: Remove advanced parameters from vNIC dialog
Since the port mirroring checkbox moved to the vNIC profile dialog,
the advanced parameters section in the vNIC dialog only includes
plug/unplug at the moment, rendering it quite unnecessary. Also
rearranged some of the widget declarations so hitting tab will move
between them in a more logical order.
Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa
Bug-Url: https://bugzilla.redhat.com/1011999
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
2 files changed, 40 insertions(+), 54 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-live[master]: ovirt-live fix makefile iso path
by obasan＠redhat.com
Ohad Basan has submitted this change and it was merged.
Change subject: ovirt-live fix makefile iso path
......................................................................
ovirt-live fix makefile iso path
the oVirtLiveFiles is the liveuser's home directory
therefore the iso has to be placed in there in order to be available in
the live environment for usage
Change-Id: I915d26aaeac14145f316ff9fa5cb1b71e7811327
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
---
D .gitignore
M centos/.gitignore
M centos/Makefile
3 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Ohad Basan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I915d26aaeac14145f316ff9fa5cb1b71e7811327
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: host-deploy: output stderr content as error in audit log
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: host-deploy: output stderr content as error in audit log
......................................................................
host-deploy: output stderr content as error in audit log
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021222
Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
2 files changed, 16 insertions(+), 7 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: core: os repository - remove "linux" and "windows"
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: os repository - remove "linux" and "windows"
......................................................................
core: os repository - remove "linux" and "windows"
"linux" and "windows" introduced to be the base oss but dosn't really
have a use as real OSs.
* remove linux and windows os from osinfo
* refactor each os which rely on linux and windows to rely on other_linux and windows_xp respectivly
* upgrade db records in vm_static.
* this change will break import/export but since this change introduced
in 3.3 and is removed in 3.3 I'm not suppling handling in the code for
that.
to fix the import its enough to add to
$PREFIX/etc/ovirt-engine/osinfo.conf.d/20-import-export-linux-windows-fix.properties
20-import-export-linux-windows-fix.properties
backwardCompatibility.linux = 5
backwardCompatibility.windows = 1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009013
Change-Id: I9c32efc276fa32af39b35ce081a7bd2003afc129
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
A packaging/dbscripts/upgrade/03_03_0970_move_rename_of_other_linux_type.sql
2 files changed, 22 insertions(+), 26 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c32efc276fa32af39b35ce081a7bd2003afc129
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: removing comment
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: removing comment
......................................................................
core: removing comment
Change-Id: I1c9ecf44c7e1d1ad99a3cdf222399a079304d168
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20572
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c9ecf44c7e1d1ad99a3cdf222399a079304d168
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix findbugs boolean comprasion warning
......................................................................
core: fix findbugs boolean comprasion warning
Change-Id: I68e6b0453d8e599e3516de8832096c4b37300fda
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68e6b0453d8e599e3516de8832096c4b37300fda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month