Change in ovirt-live[master]: ovirt-live: change application mode to virt and gluster
by obasan@redhat.com
Ohad Basan has submitted this change and it was merged.
Change subject: ovirt-live: change application mode to virt and gluster
......................................................................
ovirt-live: change application mode to virt and gluster
Change-Id: I0056ae0f31a9a823b8ddd8e58ab4809336266532
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
---
M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
…
[View More] Ohad Basan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20488
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0056ae0f31a9a823b8ddd8e58ab4809336266532
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: core: empty quota causes FK violation
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: empty quota causes FK violation
......................................................................
core: empty quota causes FK violation
When creating a disk in Foreman, the disk object is sent via
REST with empty string in id attribute:
<quota id=""/>
REST creates an empty UUID (000...) out of empty string, and causes
FK violation, since there is no quota with that id.
This patch fixes it by …
[View More]ignoring empty quota for adding disk.
Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Bug-Url: https://bugzilla.redhat.com/1021393
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-3.3]: Suggest using filters if there are more than 10 hosts.
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: Suggest using filters if there are more than 10 hosts.
......................................................................
Suggest using filters if there are more than 10 hosts.
Suggest using filters if there are more than 10 hypervisors
to collect from.
Added:
* MAX_WARN_HOSTS_COUNT - to define max hypervisors count.
Change-Id: I05fad1b52c1672b45d0199091cb60b9642581621
Bug-Url: https://bugzilla.redhat.com/…
[View More]1015022
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M src/__main__.py
1 file changed, 31 insertions(+), 8 deletions(-)
Approvals:
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05fad1b52c1672b45d0199091cb60b9642581621
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.3
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Only close provider dialog if action succeeds
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Only close provider dialog if action succeeds
......................................................................
webadmin: Only close provider dialog if action succeeds
Give the dialog a chance to display an error message from the backend
before closing.
Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6
Bug-Url: https://bugzilla.redhat.com/987949
Signed-off-by: Lior Vernia <lvernia(a)redhat.com…
[View More]>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20393
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-log-collector[master]: Suggest using filters if there are more than 10 hosts.
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: Suggest using filters if there are more than 10 hosts.
......................................................................
Suggest using filters if there are more than 10 hosts.
Suggest using filters if there are more than 10 hypervisors
to collect from.
Added:
* MAX_WARN_HOSTS_COUNT - to define max hypervisors count.
Change-Id: I05fad1b52c1672b45d0199091cb60b9642581621
Bug-Url: https://bugzilla.redhat.com/…
[View More]1015022
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M src/__main__.py
1 file changed, 31 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05fad1b52c1672b45d0199091cb60b9642581621
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: core: Custom properties code cleanup
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Custom properties code cleanup
......................................................................
core: Custom properties code cleanup
Removes member initialization.
Renames attributes to match Java Code conventions.
Adds missing Javadoc.
Change-Id: I045a6ae15cd3bb840ae1fa2561f90e35b2c00fa6
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/…
[View More]engine/core/utils/customprop/CustomPropertiesUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java
3 files changed, 69 insertions(+), 27 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I045a6ae15cd3bb840ae1fa2561f90e35b2c00fa6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-3.2]: Add a controlling TTY for ausearch
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add a controlling TTY for ausearch
......................................................................
Add a controlling TTY for ausearch
The ausearch command required a controlling TTY in order to finish
execution propely. This fix adds the '-t' flag to the ssh command
used in the log-collector
Signed-off-by: James W. Mills <jamills(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1022505
Change-Id: …
[View More]I5b7b04c037d44c6d699db670d1d98b0db678fccf
---
M src/__main__.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/20456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: James W. Mills <jamills(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: engine: Clarifying CDA message of adding vnic profile
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Clarifying CDA message of adding vnic profile
......................................................................
engine: Clarifying CDA message of adding vnic profile
The patch clarifies the can-do-action of adding a vnic profile
to a non-vm network.
Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc
Bug-Url: https://bugzilla.redhat.com/1012009
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
…
[View More]M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: restapi: Update VM pool fail with NPE
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: Update VM pool fail with NPE
......................................................................
restapi: Update VM pool fail with NPE
Need to set the SingleQxlPci when editing pool from Rest.
Bug-Url: https://bugzilla.redhat.com/1006884
Change-Id: I989fdf6816095c4d607c94331f54f4effb10f03e
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/…
[View More]org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20464
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I989fdf6816095c4d607c94331f54f4effb10f03e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 6 months
Change in ovirt-engine[master]: packaging: engine-backup: Refuse restoring to non-empty db
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Refuse restoring to non-empty db
......................................................................
packaging: engine-backup: Refuse restoring to non-empty db
Revert I8bdd8c01349b3cb2a4b1ab79a048c09479c23f27 .
Refuse to restore to a non-empty database.
Bug-Url: https://bugzilla.redhat.com/1020277
Change-Id: I83d500e2a59e30d40c15cbde82b84d12206028dd
Signed-off-by: Yedidyah Bar David …
[View More]<didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/20455
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83d500e2a59e30d40c15cbde82b84d12206028dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
[View Less]
11 years, 6 months