Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: clean '&' in jdbcTlsOptions
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: clean '&' in jdbcTlsOptions
......................................................................
packaging: setup: clean '&' in jdbcTlsOptions
Without this change, we might get an '&' immediately after the '?' in
ENGINE_DB_URL.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1002401
Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/config/database.py
1 file changed, 15 insertions(+), 12 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20442
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: quote database variables
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: quote database variables
......................................................................
packaging: setup: quote database variables
best to quote anything, especially if it contains special characters
such as '&'.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1002401
Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/config/database.py
1 file changed, 10 insertions(+), 8 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: remove quota comsumer is broken
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: remove quota comsumer is broken
......................................................................
webadmin: remove quota comsumer is broken
Although we use MLA dialogs, there is another treatment for
consume_quota role (i.e. hiding it). generalizing it with
other remove permission dialog creates an error.
Bug-Url: https://bugzilla.redhat.com/1017740
Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Einav Cohen: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/20440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: Engine: Remove OS that have illegal parent from osinfo
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: Engine: Remove OS that have illegal parent from osinfo
......................................................................
Engine: Remove OS that have illegal parent from osinfo
Change-Id: If3fe1d802b4e01f5d29f146d55fbcc906e3629e2
Bug-Url: https://bugzilla.redhat.com/980879
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/MapBackedPreferences.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
4 files changed, 35 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3fe1d802b4e01f5d29f146d55fbcc906e3629e2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: Quote values in /etc/sysconfig/nfs
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Quote values in /etc/sysconfig/nfs
......................................................................
packaging: setup: Quote values in /etc/sysconfig/nfs
Quote values in variable assignments in /etc/sysconfig/nfs.
Unquoted values might break sysvinit-based nfs init sh scripts.
Bug-Url: https://bugzilla.redhat.com/1013347
Change-Id: Ie62b0f47b0244434967e9af13fcde7614280825b
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie62b0f47b0244434967e9af13fcde7614280825b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: quote database variables
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: quote database variables
......................................................................
packaging: setup: quote database variables
best to quote anything, especially if it contains special characters
such as '&'.
Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/config/database.py
1 file changed, 10 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: add README file to configuration drop dirs
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: add README file to configuration drop dirs
......................................................................
packaging: setup: add README file to configuration drop dirs
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020675
Change-Id: I17797e329be28ba938fbc4c57703aa2d3517ec15
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M .gitignore
M Makefile
M ovirt-engine.spec.in
A packaging/etc/engine.conf.d/README.in
A packaging/etc/notifier/notifier.conf.d/README.in
A packaging/etc/ovirt-websocket-proxy.conf.d/README.in
6 files changed, 36 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17797e329be28ba938fbc4c57703aa2d3517ec15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: turn engine.conf to ghost
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: turn engine.conf to ghost
......................................................................
packaging: setup: turn engine.conf to ghost
this file should not be used as drop dir resolves the rpmnew/rpmsave
hell.
it must remain as ghost for backward compatibility.
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675
Change-Id: I68ada5e69ec8fc255013b29ad47134f30bacd758
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
D packaging/etc/engine.conf
2 files changed, 2 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20380
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68ada5e69ec8fc255013b29ad47134f30bacd758
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: cleanup: sort generated files
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: cleanup: sort generated files
......................................................................
packaging: setup: cleanup: sort generated files
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675
Change-Id: I69e8e030e8619282804cf1990af199941211b3d4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M .gitignore
M Makefile
2 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69e8e030e8619282804cf1990af199941211b3d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: Do not fail with missing /etc/sysconfig/nfs
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Do not fail with missing /etc/sysconfig/nfs
......................................................................
packaging: setup: Do not fail with missing /etc/sysconfig/nfs
Make engine-setup do not fail if /etc/sysconfig/nfs does not exist,
instead behave as if it was empty. engine-cleanup leaves it behind
empty.
Change-Id: I62b22a12b9abd408657696caa8d34243ae521cbd
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20402
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62b22a12b9abd408657696caa8d34243ae521cbd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month